bankiru / doctrine-api-client

Proxy/ApiCollection.php

Doc Comments +4 added lines, -1 removed lines

@@ -188,6 +188,9 @@ 
         return $this->snapshot;
     }
 
+    /**
+     * @param boolean $state
+     */
     public function setInitialized($state)
     {
         $this->initialized = (bool)$state;
@@ -452,7 +455,7 @@ 
      * Internal note: Tried to implement Serializable first but that did not work well
      *                with circular references. This solution seems simpler and works well.
      *
-     * @return array
+     * @return string[]
      */
     public function __sleep()
     {

Spacing +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
         return array_udiff_assoc(
             $this->snapshot,
             $this->collection->toArray(),
-            function ($a, $b) {
+            function($a, $b) {
                 return $a === $b ? 0 : 1;
             }
         );
@@ -221,7 +221,7 @@ 
         return array_udiff_assoc(
             $this->collection->toArray(),
             $this->snapshot,
-            function ($a, $b) {
+            function($a, $b) {
                 return $a === $b ? 0 : 1;
             }
         );

Cache/KeyStrategyInterface.php

Spacing +1 added lines, -1 removed lines

@@ -24,5 +24,5 @@
      *
      * @return string
      */
-    public function getEntityKey(ApiMetadata $metadata,array $identifier);
+    public function getEntityKey(ApiMetadata $metadata, array $identifier);
 }

Utility/ReflectionPropertiesGetter.php

Spacing +2 added lines, -2 removed lines

@@ -155,9 +155,9 @@
         }
 
         if ($property->isProtected()) {
-            return "\0*\0".$propertyName;
+            return "\0*\0" . $propertyName;
         }
 
-        return "\0".$property->getDeclaringClass()->getName()."\0".$propertyName;
+        return "\0" . $property->getDeclaringClass()->getName() . "\0" . $propertyName;
     }
 }

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     }
 
     /**
-     * @param $className
+     * @param string $className
      *
      * @return \ReflectionProperty[] indexed by property internal name
      */

Proxy/ProxyFactory.php

Spacing +2 added lines, -2 removed lines

@@ -89,7 +89,7 @@ 
     {
         $wakeupProxy = $classMetadata->getReflectionClass()->hasMethod('__wakeup');
 
-        return function (Proxy $proxy) use ($classMetadata, $wakeupProxy, $persister) {
+        return function(Proxy $proxy) use ($classMetadata, $wakeupProxy, $persister) {
             $initializer = $proxy->__getInitializer();
             $cloner      = $proxy->__getCloner();
 
@@ -130,7 +130,7 @@ 
      */
     private function createCloner(ApiMetadata $classMetadata, ApiPersister $persister)
     {
-        return function (Proxy $proxy) use ($classMetadata, $persister) {
+        return function(Proxy $proxy) use ($classMetadata, $persister) {
             if ($proxy->__isInitialized()) {
                 return;
             }

Tests/CustomRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
         $repository = $this->getManager()->getRepository(CustomEntity::class);
         $this->getClient()->push(
             $this->getResponseMock(true, (object)['customField' => 'custom-response']),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('custom-entity/custom', $request->getMethod());
                 self::assertEquals(
                     ['param1' => 'value1'],

Tests/IndirectFieldsTest.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
                     'payload'                  => 'test',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('indirect-entity/find', $request->getMethod());
                 self::assertEquals(['some-long-api-field-name' => 241], $request->getParameters());
 

Tests/ProxyTest.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
                     'sub-payload' => 'sub-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 2], $request->getParameters());
 
@@ -67,7 +67,7 @@ 
                     'sub-payload' => 'sub-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 2], $request->getParameters());
 

Tests/EntityFactoryTest.php

Spacing +3 added lines, -3 removed lines

@@ -21,7 +21,7 @@ 
                     'payload' => 'test-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 1], $request->getParameters());
 
@@ -50,7 +50,7 @@ 
                     'sub-payload' => 'sub-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 2], $request->getParameters());
 
@@ -79,7 +79,7 @@ 
                     'payload'    => 'test-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('composite-key-entity/find', $request->getMethod());
                 self::assertEquals(['first_key' => 2, 'second_key' => 'test'], $request->getParameters());
 

Tests/EntityCacheTest.php

Spacing +4 added lines, -4 removed lines

@@ -23,7 +23,7 @@ 
                     'payload' => 'test-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('custom-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 1], $request->getParameters());
 
@@ -98,7 +98,7 @@ 
         $cache = $this->prophesize(CacheItemPoolInterface::class);
         $that  = $this;
         $cache->getItem(Argument::type('string'))->will(
-            function ($args) use (&$items, $that) {
+            function($args) use (&$items, $that) {
                 $key = $args[0];
                 if (!array_key_exists($key, $items)) {
                     $item = $that->prophesize(CacheItemInterface::class);
@@ -106,7 +106,7 @@ 
                     $item->isHit()->willReturn(false);
                     $item->get()->willReturn(null);
                     $item->set(Argument::any())->will(
-                        function ($args) use ($item) {
+                        function($args) use ($item) {
                             $item->get()->willReturn($args[0]);
 
                             return $item;
@@ -123,7 +123,7 @@ 
             }
         );
         $cache->save(Argument::type(CacheItemInterface::class))->will(
-            function ($args) use (&$items) {
+            function($args) use (&$items) {
                 $item = $args[0];
                 $items[$item->getKey()]->isHit()->willReturn(true);
             }