CollectionLoadingTest::testFindBy() - Code Metrics - Inspection of "Insight fixes" - bankiru/doctrine-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

by Pavel

created 2016-08-08 18:36 UTC

CollectionLoadingTest::testFindBy() A

↳ Parent: CollectionLoadingTest

Complexity

Conditions	3
Paths	3

Size

Total Lines	53
Code Lines	31

Duplication

Lines	10
Ratio	18.87 %

Code Coverage

Tests	41
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	10
loc	53
ccs	41
cts	41
cp	1
rs	9.5797
cc	3
eloc	31
nc	3
nop	0
crap	3

How to fix Long Method

<?php

namespace Bankiru\Api\Tests;

use Bankiru\Api\Doctrine\Proxy\ApiCollection;
use Bankiru\Api\Test\Entity\Sub\SubEntity;
use Doctrine\Common\Collections\ArrayCollection;
use GuzzleHttp\Psr7\Response;

class CollectionLoadingTest extends AbstractEntityManagerTest
{
    protected function getClientNames()
    {
        return [self::DEFAULT_CLIENT, 'test-reference-client'];
    }

    public function testLazyCollections()
    {
        $repository = $this->getManager()->getRepository(SubEntity::class);
        /** @var SubEntity[]|ArrayCollection|ApiCollection $entities */
        $entities = $repository->findBy(['subPayload' => 'sub-payload']);

        self::assertInstanceOf(ApiCollection::class, $entities);
        self::assertFalse($entities->isInitialized());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        try {
            $entities->count();
        } catch (\OutOfBoundsException $exception) {
            self::assertEquals('Mock queue is empty', $exception->getMessage());
        }
    }

    public function testFindBy()
    {
        $repository = $this->getManager()->getRepository(SubEntity::class);

        $this->getResponseMock()->append(
            new Response(
                200,
                [],
                json_encode(
                    [
                        'jsonrpc' => '2.0',
                        'id'      => 'test',
                        'result'  => [
                            [
                                'id'             => '1',
                                'payload'        => 'test-payload-1',
                                'sub-payload'    => 'sub-payload',
                                'string-payload' => null,
                            ],
                            [
                                'id'             => '2',
                                'payload'        => 'test-payload-2',
                                'sub-payload'    => 'sub-payload',
                                'string-payload' => 123456,
                            ],
                            [
                                'id'             => '3',
                                'payload'        => 'test-payload-3',
                                'sub-payload'    => 'sub-payload',
                                'string-payload' => 'sub-payload',
                            ],
                        ],
                    ]
                )
            )
        );

        /** @var SubEntity[]|ArrayCollection $entities */
        $entities = $repository->findBy(['subPayload' => 'sub-payload']);
        self::assertInstanceOf(\Countable::class, $entities);
        self::assertCount(3, $entities);

        foreach ($entities as $entity) {

            self::assertInternalType('int', $entity->getId());
            self::assertInstanceOf(SubEntity::class, $entity);
            self::assertEquals('test-payload-' . $entity->getId(), $entity->getPayload());
            self::assertEquals('sub-payload', $entity->getSubPayload());

            if (null !== $entity->getStringPayload()) {
                self::assertInternalType('string', $entity->getStringPayload());
            }
        }
    }
}


1			<?php
2
3			namespace Bankiru\Api\Tests;
4
5			use Bankiru\Api\Doctrine\Proxy\ApiCollection;
6			use Bankiru\Api\Test\Entity\Sub\SubEntity;
7			use Doctrine\Common\Collections\ArrayCollection;
8			use GuzzleHttp\Psr7\Response;
9
10			class CollectionLoadingTest extends AbstractEntityManagerTest
11			{
12	2		protected function getClientNames()
13			{
14	2		return [self::DEFAULT_CLIENT, 'test-reference-client'];
15			}
16
17	1		public function testLazyCollections()
18			{
19	1		$repository = $this->getManager()->getRepository(SubEntity::class);
20			/** @var SubEntity[]\|ArrayCollection\|ApiCollection $entities */
21	1		$entities = $repository->findBy(['subPayload' => 'sub-payload']);
22
23	1		self::assertInstanceOf(ApiCollection::class, $entities);
24	1		self::assertFalse($entities->isInitialized());
			0 ignored issues – show Bug introduced 2016-05-12 09:51 UTC by Report Bug Copy Issue Report The method `isInitialized` does only exist in `Bankiru\Api\Doctrine\Proxy\ApiCollection`, but not in `Doctrine\Common\Collections\ArrayCollection`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
25
26			try {
27	1		$entities->count();
28	1		} catch (\OutOfBoundsException $exception) {
29	1		self::assertEquals('Mock queue is empty', $exception->getMessage());
30			}
31	1		}
32
33	2		public function testFindBy()
34			{
35	1		$repository = $this->getManager()->getRepository(SubEntity::class);
36
37	1		$this->getResponseMock()->append(
38	1		new Response(
39	1		200,
40	1		[],
41	1		json_encode(
42			[
43	1		'jsonrpc' => '2.0',
44	1		'id' => 'test',
45			'result' => [
46			[
47	1		'id' => '1',
48	1		'payload' => 'test-payload-1',
49	1		'sub-payload' => 'sub-payload',
50	1		'string-payload' => null,
51	1		],
52			[
53	1		'id' => '2',
54	1		'payload' => 'test-payload-2',
55	1		'sub-payload' => 'sub-payload',
56	1		'string-payload' => 123456,
57	1		],
58			[
59	1		'id' => '3',
60	1		'payload' => 'test-payload-3',
61	1		'sub-payload' => 'sub-payload',
62	1		'string-payload' => 'sub-payload',
63	1		],
64	1		],
65			]
66	1		)
67	1		)
68	1		);
69
70			/** @var SubEntity[]\|ArrayCollection $entities */
71	1		$entities = $repository->findBy(['subPayload' => 'sub-payload']);
72	1		self::assertInstanceOf(\Countable::class, $entities);
73	1		self::assertCount(3, $entities);
74
75	1	View Code Duplication	foreach ($entities as $entity) {
			0 ignored issues – show Duplication introduced 2016-05-12 09:51 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76	1		self::assertInternalType('int', $entity->getId());
77	1		self::assertInstanceOf(SubEntity::class, $entity);
78	1		self::assertEquals('test-payload-' . $entity->getId(), $entity->getPayload());
79	2		self::assertEquals('sub-payload', $entity->getSubPayload());
80
81	1		if (null !== $entity->getStringPayload()) {
82	1		self::assertInternalType('string', $entity->getStringPayload());
83	1		}
84	1		}
85	1		}
86			}
87

bankiru / doctrine-api-client

Pull Request — master (#8)

CollectionLoadingTest::testFindBy() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like