bankiru / doctrine-api-client

Proxy/ApiCollection.php

Doc Comments +4 added lines, -1 removed lines

@@ -188,6 +188,9 @@ 
         return $this->snapshot;
     }
 
+    /**
+     * @param boolean $state
+     */
     public function setInitialized($state)
     {
         $this->initialized = (bool)$state;
@@ -452,7 +455,7 @@ 
      * Internal note: Tried to implement Serializable first but that did not work well
      *                with circular references. This solution seems simpler and works well.
      *
-     * @return array
+     * @return string[]
      */
     public function __sleep()
     {

UnitOfWork.php

Doc Comments +2 added lines, -2 removed lines

@@ -172,7 +172,7 @@ 
     }
 
     /**
-     * @param             $className
+     * @param             string $className
      * @param \stdClass   $data
      *
      * @return ObjectManagerAware|object
@@ -230,7 +230,7 @@ 
      * INTERNAL:
      * Registers an entity as managed.
      *
-     * @param object         $entity The entity.
+     * @param Proxy         $entity The entity.
      * @param array          $id     The identifier values.
      * @param \stdClass|null $data   The original entity data.
      *

Utility/ReflectionPropertiesGetter.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     }
 
     /**
-     * @param $className
+     * @param string $className
      *
      * @return \ReflectionProperty[] indexed by property internal name
      */

Exception/MappingException.php

Doc Comments +43 added lines

@@ -6,11 +6,17 @@ 
 
 class MappingException extends BaseMappingException implements DoctrineApiException
 {
+    /**
+     * @param string $alias
+     */
     public static function unknownAlias($alias)
     {
         return new self(sprintf('Unknown namespace alias "%s"', $alias));
     }
 
+    /**
+     * @param string $class
+     */
     public static function noSuchProperty($property, $class)
     {
         return new self(
@@ -20,6 +26,9 @@ 
         );
     }
 
+    /**
+     * @param string $class
+     */
     public static function noClientSpecified($class)
     {
         return new self(sprintf('Client not specified for %s or any parent', $class));
@@ -30,6 +39,9 @@ 
         return new self(sprintf('Could not resolve client "%s": %s', $name, $message));
     }
 
+    /**
+     * @param string $class
+     */
     public static function noApiSpecified($class)
     {
         return new self(sprintf('API factory not specified for %s or any parent', $class));
@@ -40,11 +52,18 @@ 
         return new self(sprintf('Could not resolve API factory "%s": %s', $name, $message));
     }
 
+    /**
+     * @param string $class
+     */
     public static function unknownField($field, $class)
     {
         return new self(sprintf('No mapping for field "%s" in %s', $field, $class));
     }
 
+    /**
+     * @param string $field
+     * @param string $class
+     */
     public static function unknownAssociation($field, $class)
     {
         return new self(sprintf('No mapping for association "%s" in %s', $field, $class));
@@ -65,31 +84,51 @@ 
         return new static(sprintf('Unknown factory to create API: %s', $alias));
     }
 
+    /**
+     * @param string $alias
+     */
     public static function nameIsMandatoryForDiscriminatorColumns($alias)
     {
         return new static(sprintf('Name is mandatory for discriminator column: %s', $alias));
     }
 
+    /**
+     * @param string $alias
+     */
     public static function duplicateColumnName($alias, $column)
     {
         return new static(sprintf('Duplicate column name "%s": %s', $column, $alias));
     }
 
+    /**
+     * @param string $alias
+     * @param string $type
+     */
     public static function invalidDiscriminatorColumnType($alias, $type)
     {
         return new static(sprintf('Invalud discriminator column type "%s": %s', $type, $alias));
     }
 
+    /**
+     * @param string $name
+     * @param string $rootEntityName
+     */
     public static function mappedClassNotPartOfDiscriminatorMap($name, $rootEntityName)
     {
         return new static(sprintf('Mapped class "%s" is not a part of discriminator map: %s', $name, $rootEntityName));
     }
 
+    /**
+     * @param string $alias
+     */
     public static function unknownDiscriminatorValue($value, $alias)
     {
         return new static(sprintf('Unknown discriminator value "%s": %s', $value, $alias));
     }
 
+    /**
+     * @param string $name
+     */
     public static function duplicateDiscriminatorEntry($name, array $duplicates, array $map)
     {
         return new static(
@@ -97,6 +136,10 @@ 
         );
     }
 
+    /**
+     * @param string $className
+     * @param string $name
+     */
     public static function invalidClassInDiscriminatorMap($className, $name)
     {
         return new static(

Tests/AbstractEntityManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     private $factoryRegistry;
 
     /**
-     * @return mixed
+     * @return ClientRegistryInterface
      */
     public function getClientRegistry()
     {

Unused Use Statements -2 removed lines

@@ -13,14 +13,12 @@
 use Bankiru\Api\Doctrine\EntityManager;
 use Bankiru\Api\Doctrine\EntityMetadataFactory;
 use Bankiru\Api\Doctrine\Mapping\Driver\YmlMetadataDriver;
-use Bankiru\Api\Doctrine\Test\TestApiFactory;
 use Bankiru\Api\Doctrine\Type\BaseTypeRegistry;
 use Bankiru\Api\Doctrine\Type\TypeRegistry;
 use Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain;
 use Doctrine\Common\Persistence\Mapping\Driver\SymfonyFileLocator;
 use PHPUnit\Framework\TestCase;
 use ScayTrase\Api\Rpc\Test\RpcMockClient;
-use ScayTrase\Api\Rpc\Tests\AbstractRpcTest;
 use ScayTrase\Api\Rpc\Tests\RpcRequestTrait;
 
 abstract class AbstractEntityManagerTest extends TestCase