CommitTest - Code Metrics - Inspection of "[WIP] Release 2.0" - bankiru/doctrine-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Pavel

created 2016-10-28 11:40 UTC

CommitTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	186
Duplicated Lines	27.96 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	6
dl	52
loc	186
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	testSimpleCommit()	26	26	1
B	testExtendedIdIsSameAsSimpleCommit()	26	26	1
A	testChainCommitWithRelation()	0	52	1
A	testChainUpdateWithRelation()	0	53	1
A	testRemove()	0	17	1
A	getClientNames()	0	4	1

How to fix Duplicated Code

<?php

namespace Bankiru\Api\Doctrine\Tests;

use Bankiru\Api\Doctrine\Test\Entity\TestEntity;
use Bankiru\Api\Doctrine\Test\Entity\TestReference;
use ScayTrase\Api\Rpc\RpcRequestInterface;

class CommitTest extends AbstractEntityManagerTest
{
    public function testSimpleCommit()

    {
        $entity = new TestReference();

        $this->getClient('test-reference-client')->push(
            $this->getResponseMock(true, 241),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-reference/create', $request->getMethod());
                self::assertEquals(
                    [
                        'reference-payload' => '',
                        'owner'             => null,
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );

        $this->getManager()->persist($entity);
        $this->getManager()->flush();

        self::assertNotNull($entity->getId());
        self::assertEquals(241, $entity->getId());
    }

    public function testExtendedIdIsSameAsSimpleCommit()

    {
        $entity = new TestReference();

        $this->getClient('test-reference-client')->push(
            $this->getResponseMock(true, ['id' => 241]),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-reference/create', $request->getMethod());
                self::assertEquals(
                    [
                        'reference-payload' => '',
                        'owner'             => null,
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );

        $this->getManager()->persist($entity);
        $this->getManager()->flush();

        self::assertNotNull($entity->getId());
        self::assertEquals(241, $entity->getId());
    }

    public function testChainCommitWithRelation()
    {
        $entity = new TestReference();
        $parent = new TestEntity();
        $entity->setOwner($parent);

        $this->getClient()->push(
            $this->getResponseMock(true, ['id' => 42]),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-entity/create', $request->getMethod());
                self::assertEquals(
                    [
                        'payload' => '',
                        'parent'  => null,
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );

        $this->getClient('test-reference-client')->push(
            $this->getResponseMock(true, ['id' => 241]),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-reference/create', $request->getMethod());
                self::assertEquals(
                    [
                        'reference-payload' => '',
                        'owner'             => 42,
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );

        $this->getManager()->persist($entity);
        $this->getManager()->persist($parent);
        $this->getManager()->flush();

        self::assertNotNull($parent->getId());
        self::assertEquals(42, $parent->getId());

        self::assertNotNull($entity->getId());
        self::assertEquals(241, $entity->getId());

        self::assertEquals($entity->getOwner(), $parent);

        return $entity;
    }

    public function testChainUpdateWithRelation()
    {
        $entity = $this->testChainCommitWithRelation();

        $oldParent = $entity->getOwner();
        $newParent = new TestEntity();
        $this->getClient()->push(
            $this->getResponseMock(true, ['id' => 17]),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-entity/create', $request->getMethod());
                self::assertEquals(
                    [
                        'payload' => '',
                        'parent'  => null,
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );
        $this->getClient('test-reference-client')->push(
            $this->getResponseMock(true, null),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-reference/patch', $request->getMethod());
                self::assertEquals(
                    [
                        'identifier' => ['id' => 241],
                        'patch'      => ['owner' => 17],
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );

        $entity->setOwner($newParent);

        $this->getManager()->persist($newParent);
        $this->getManager()->flush();

        self::assertNotNull($newParent->getId());
        self::assertEquals(17, $newParent->getId());

        self::assertNotNull($entity->getId());
        self::assertEquals(241, $entity->getId());

        self::assertEquals($entity->getOwner(), $newParent);

        self::assertNotSame($newParent, $oldParent);
        self::assertFalse($oldParent->getReferences()->contains($entity));
    }

    public function testRemove()
    {
        $entity = new TestReference();

        $this->getClient('test-reference-client')->push($this->getResponseMock(true, 241));

        $this->getManager()->persist($entity);
        $this->getManager()->flush();

        self::assertNotNull($entity->getId());
        self::assertEquals(241, $entity->getId());

        $this->getClient('test-reference-client')->push($this->getResponseMock(true, null));

        $this->getManager()->remove($entity);
        $this->getManager()->flush();
    }

    protected function getClientNames()
    {
        return array_merge(parent::getClientNames(), ['test-reference-client']);
    }
}


1		<?php
2
3		namespace Bankiru\Api\Doctrine\Tests;
4
5		use Bankiru\Api\Doctrine\Test\Entity\TestEntity;
6		use Bankiru\Api\Doctrine\Test\Entity\TestReference;
7		use ScayTrase\Api\Rpc\RpcRequestInterface;
8
9		class CommitTest extends AbstractEntityManagerTest
10		{
11	View Code Duplication	public function testSimpleCommit()
		0 ignored issues – show Duplication introduced 2016-10-28 11:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		$entity = new TestReference();
14
15		$this->getClient('test-reference-client')->push(
16		$this->getResponseMock(true, 241),
17		function (RpcRequestInterface $request) {
18		self::assertEquals('test-reference/create', $request->getMethod());
19		self::assertEquals(
20		[
21		'reference-payload' => '',
22		'owner' => null,
23		],
24		$request->getParameters()
25		);
26
27		return true;
28		}
29		);
30
31		$this->getManager()->persist($entity);
32		$this->getManager()->flush();
33
34		self::assertNotNull($entity->getId());
35		self::assertEquals(241, $entity->getId());
36		}
37
38	View Code Duplication	public function testExtendedIdIsSameAsSimpleCommit()
		0 ignored issues – show Duplication introduced 2016-10-28 11:44 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		$entity = new TestReference();
41
42		$this->getClient('test-reference-client')->push(
43		$this->getResponseMock(true, ['id' => 241]),
44		function (RpcRequestInterface $request) {
45		self::assertEquals('test-reference/create', $request->getMethod());
46		self::assertEquals(
47		[
48		'reference-payload' => '',
49		'owner' => null,
50		],
51		$request->getParameters()
52		);
53
54		return true;
55		}
56		);
57
58		$this->getManager()->persist($entity);
59		$this->getManager()->flush();
60
61		self::assertNotNull($entity->getId());
62		self::assertEquals(241, $entity->getId());
63		}
64
65		public function testChainCommitWithRelation()
66		{
67		$entity = new TestReference();
68		$parent = new TestEntity();
69		$entity->setOwner($parent);
70
71		$this->getClient()->push(
72		$this->getResponseMock(true, ['id' => 42]),
73		function (RpcRequestInterface $request) {
74		self::assertEquals('test-entity/create', $request->getMethod());
75		self::assertEquals(
76		[
77		'payload' => '',
78		'parent' => null,
79		],
80		$request->getParameters()
81		);
82
83		return true;
84		}
85		);
86
87		$this->getClient('test-reference-client')->push(
88		$this->getResponseMock(true, ['id' => 241]),
89		function (RpcRequestInterface $request) {
90		self::assertEquals('test-reference/create', $request->getMethod());
91		self::assertEquals(
92		[
93		'reference-payload' => '',
94		'owner' => 42,
95		],
96		$request->getParameters()
97		);
98
99		return true;
100		}
101		);
102
103		$this->getManager()->persist($entity);
104		$this->getManager()->persist($parent);
105		$this->getManager()->flush();
106
107		self::assertNotNull($parent->getId());
108		self::assertEquals(42, $parent->getId());
109
110		self::assertNotNull($entity->getId());
111		self::assertEquals(241, $entity->getId());
112
113		self::assertEquals($entity->getOwner(), $parent);
114
115		return $entity;
116		}
117
118		public function testChainUpdateWithRelation()
119		{
120		$entity = $this->testChainCommitWithRelation();
121
122		$oldParent = $entity->getOwner();
123		$newParent = new TestEntity();
124		$this->getClient()->push(
125		$this->getResponseMock(true, ['id' => 17]),
126		function (RpcRequestInterface $request) {
127		self::assertEquals('test-entity/create', $request->getMethod());
128		self::assertEquals(
129		[
130		'payload' => '',
131		'parent' => null,
132		],
133		$request->getParameters()
134		);
135
136		return true;
137		}
138		);
139		$this->getClient('test-reference-client')->push(
140		$this->getResponseMock(true, null),
141		function (RpcRequestInterface $request) {
142		self::assertEquals('test-reference/patch', $request->getMethod());
143		self::assertEquals(
144		[
145		'identifier' => ['id' => 241],
146		'patch' => ['owner' => 17],
147		],
148		$request->getParameters()
149		);
150
151		return true;
152		}
153		);
154
155		$entity->setOwner($newParent);
156
157		$this->getManager()->persist($newParent);
158		$this->getManager()->flush();
159
160		self::assertNotNull($newParent->getId());
161		self::assertEquals(17, $newParent->getId());
162
163		self::assertNotNull($entity->getId());
164		self::assertEquals(241, $entity->getId());
165
166		self::assertEquals($entity->getOwner(), $newParent);
167
168		self::assertNotSame($newParent, $oldParent);
169		self::assertFalse($oldParent->getReferences()->contains($entity));
170		}
171
172		public function testRemove()
173		{
174		$entity = new TestReference();
175
176		$this->getClient('test-reference-client')->push($this->getResponseMock(true, 241));
177
178		$this->getManager()->persist($entity);
179		$this->getManager()->flush();
180
181		self::assertNotNull($entity->getId());
182		self::assertEquals(241, $entity->getId());
183
184		$this->getClient('test-reference-client')->push($this->getResponseMock(true, null));
185
186		$this->getManager()->remove($entity);
187		$this->getManager()->flush();
188		}
189
190		protected function getClientNames()
191		{
192		return array_merge(parent::getClientNames(), ['test-reference-client']);
193		}
194		}
195

bankiru / doctrine-api-client

Pull Request — master (#14)

CommitTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like