bankiru / doctrine-api-client

UnitOfWork.php

Doc Comments +2 added lines, -2 removed lines

@@ -172,7 +172,7 @@ 
     }
 
     /**
-     * @param             $className
+     * @param             string $className
      * @param \stdClass   $data
      *
      * @return ObjectManagerAware|object
@@ -230,7 +230,7 @@ 
      * INTERNAL:
      * Registers an entity as managed.
      *
-     * @param object         $entity The entity.
+     * @param Proxy         $entity The entity.
      * @param array          $id     The identifier values.
      * @param \stdClass|null $data   The original entity data.
      *

Spacing +5 added lines, -5 removed lines

@@ -1740,7 +1740,7 @@ 
         $class               = $this->manager->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->getAssociationMappings(),
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeRefresh'];
             }
         );
@@ -1779,7 +1779,7 @@ 
         $class               = $this->manager->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->getAssociationMappings(),
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeDetach'];
             }
         );
@@ -1819,7 +1819,7 @@ 
         $class               = $this->manager->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->getAssociationMappings(),
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeMerge'];
             }
         );
@@ -1857,11 +1857,11 @@ 
         $class               = $this->manager->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->getAssociationMappings(),
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeRemove'];
             }
         );
-        $entitiesToCascade   = [];
+        $entitiesToCascade = [];
         foreach ($associationMappings as $assoc) {
             if ($entity instanceof Proxy && !$entity->__isInitialized__) {
                 $entity->__load();

Utility/ReflectionPropertiesGetter.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     }
 
     /**
-     * @param $className
+     * @param string $className
      *
      * @return \ReflectionProperty[] indexed by property internal name
      */

Exception/MappingException.php

Doc Comments +43 added lines

@@ -6,11 +6,17 @@ 
 
 class MappingException extends BaseMappingException implements DoctrineApiException
 {
+    /**
+     * @param string $alias
+     */
     public static function unknownAlias($alias)
     {
         return new self(sprintf('Unknown namespace alias "%s"', $alias));
     }
 
+    /**
+     * @param string $class
+     */
     public static function noSuchProperty($property, $class)
     {
         return new self(
@@ -20,6 +26,9 @@ 
         );
     }
 
+    /**
+     * @param string $class
+     */
     public static function noClientSpecified($class)
     {
         return new self(sprintf('Client not specified for %s or any parent', $class));
@@ -30,6 +39,9 @@ 
         return new self(sprintf('Could not resolve client "%s": %s', $name, $message));
     }
 
+    /**
+     * @param string $class
+     */
     public static function noApiSpecified($class)
     {
         return new self(sprintf('API factory not specified for %s or any parent', $class));
@@ -40,11 +52,18 @@ 
         return new self(sprintf('Could not resolve API factory "%s": %s', $name, $message));
     }
 
+    /**
+     * @param string $class
+     */
     public static function unknownField($field, $class)
     {
         return new self(sprintf('No mapping for field "%s" in %s', $field, $class));
     }
 
+    /**
+     * @param string $field
+     * @param string $class
+     */
     public static function unknownAssociation($field, $class)
     {
         return new self(sprintf('No mapping for association "%s" in %s', $field, $class));
@@ -65,31 +84,51 @@ 
         return new static(sprintf('Unknown factory to create API: %s', $alias));
     }
 
+    /**
+     * @param string $alias
+     */
     public static function nameIsMandatoryForDiscriminatorColumns($alias)
     {
         return new static(sprintf('Name is mandatory for discriminator column: %s', $alias));
     }
 
+    /**
+     * @param string $alias
+     */
     public static function duplicateColumnName($alias, $column)
     {
         return new static(sprintf('Duplicate column name "%s": %s', $column, $alias));
     }
 
+    /**
+     * @param string $alias
+     * @param string $type
+     */
     public static function invalidDiscriminatorColumnType($alias, $type)
     {
         return new static(sprintf('Invalud discriminator column type "%s": %s', $type, $alias));
     }
 
+    /**
+     * @param string $name
+     * @param string $rootEntityName
+     */
     public static function mappedClassNotPartOfDiscriminatorMap($name, $rootEntityName)
     {
         return new static(sprintf('Mapped class "%s" is not a part of discriminator map: %s', $name, $rootEntityName));
     }
 
+    /**
+     * @param string $alias
+     */
     public static function unknownDiscriminatorValue($value, $alias)
     {
         return new static(sprintf('Unknown discriminator value "%s": %s', $value, $alias));
     }
 
+    /**
+     * @param string $name
+     */
     public static function duplicateDiscriminatorEntry($name, array $duplicates, array $map)
     {
         return new static(
@@ -97,6 +136,10 @@ 
         );
     }
 
+    /**
+     * @param string $className
+     * @param string $name
+     */
     public static function invalidClassInDiscriminatorMap($className, $name)
     {
         return new static(

Tests/AbstractEntityManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     private $factoryRegistry;
 
     /**
-     * @return mixed
+     * @return ClientRegistryInterface
      */
     public function getClientRegistry()
     {

Unused Use Statements -2 removed lines

@@ -13,14 +13,12 @@
 use Bankiru\Api\Doctrine\EntityManager;
 use Bankiru\Api\Doctrine\EntityMetadataFactory;
 use Bankiru\Api\Doctrine\Mapping\Driver\YmlMetadataDriver;
-use Bankiru\Api\Doctrine\Test\TestApiFactory;
 use Bankiru\Api\Doctrine\Type\BaseTypeRegistry;
 use Bankiru\Api\Doctrine\Type\TypeRegistry;
 use Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain;
 use Doctrine\Common\Persistence\Mapping\Driver\SymfonyFileLocator;
 use PHPUnit\Framework\TestCase;
 use ScayTrase\Api\Rpc\Test\RpcMockClient;
-use ScayTrase\Api\Rpc\Tests\AbstractRpcTest;
 use ScayTrase\Api\Rpc\Tests\RpcRequestTrait;
 
 abstract class AbstractEntityManagerTest extends TestCase

Spacing +2 added lines, -2 removed lines

@@ -120,14 +120,14 @@
         $configuration->setClientRegistry($this->clientRegistry);
         $configuration->setTypeRegistry(new BaseTypeRegistry(new TypeRegistry()));
         $configuration->setFactoryRegistry($this->factoryRegistry);
-        $configuration->setProxyDir(CACHE_DIR.'/doctrine/proxy/');
+        $configuration->setProxyDir(CACHE_DIR . '/doctrine/proxy/');
         $configuration->setProxyNamespace('Bankiru\Api\Doctrine\Test\Proxy');
         $driver = new MappingDriverChain();
         $driver->addDriver(
             new YmlMetadataDriver(
                 new SymfonyFileLocator(
                     [
-                        __DIR__.'/../Test/Resources/config/api/' => 'Bankiru\Api\Doctrine\Test\Entity',
+                        __DIR__ . '/../Test/Resources/config/api/' => 'Bankiru\Api\Doctrine\Test\Entity',
                     ],
                     '.api.yml',
                     DIRECTORY_SEPARATOR

Tests/CountingTest.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     {
         $this->getClient()->push(
             $this->getResponseMock(true, 5),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('prefixed-entity/count', $request->getMethod());
                 self::assertEquals(
                     [

Tests/DiscriminatorTest.php

Spacing +4 added lines, -4 removed lines

@@ -65,7 +65,7 @@ 
                     ],
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('discriminator/search', $request->getMethod());
                 self::assertEquals(
                     [
@@ -134,7 +134,7 @@ 
                     ],
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('discriminator/search', $request->getMethod());
                 self::assertEquals(
                     [
@@ -177,7 +177,7 @@ 
     {
         $this->getClient()->push(
             $this->getResponseMock(true, ['id_field' => 241]),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('discriminator/create', $request->getMethod());
                 self::assertEquals(
                     [
@@ -199,7 +199,7 @@ 
 
         $this->getClient()->push(
             $this->getResponseMock(true, ['id_field' => 241]),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('discriminator/patch', $request->getMethod());
                 self::assertEquals(
                     [

Tests/CommitTest.php

Spacing +6 added lines, -6 removed lines

@@ -14,7 +14,7 @@ 
 
         $this->getClient('test-reference-client')->push(
             $this->getResponseMock(true, 241),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-reference/create', $request->getMethod());
                 self::assertEquals(
                     [
@@ -41,7 +41,7 @@ 
 
         $this->getClient('test-reference-client')->push(
             $this->getResponseMock(true, ['id' => 241]),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-reference/create', $request->getMethod());
                 self::assertEquals(
                     [
@@ -70,7 +70,7 @@ 
 
         $this->getClient()->push(
             $this->getResponseMock(true, (object)['id' => 42]),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/create', $request->getMethod());
                 self::assertEquals(
                     [
@@ -86,7 +86,7 @@ 
 
         $this->getClient('test-reference-client')->push(
             $this->getResponseMock(true, (object)['id' => 241]),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-reference/create', $request->getMethod());
                 self::assertEquals(
                     [
@@ -123,7 +123,7 @@ 
         $newParent = new TestEntity();
         $this->getClient()->push(
             $this->getResponseMock(true, (object)['id' => 17]),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/create', $request->getMethod());
                 self::assertEquals(
                     [
@@ -138,7 +138,7 @@ 
         );
         $this->getClient('test-reference-client')->push(
             $this->getResponseMock(true, null),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-reference/patch', $request->getMethod());
                 self::assertEquals(
                     [

Dehydration/SearchDehydrator.php

Spacing +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
                 /** @var EntityMetadata $target */
                 $target = $this->manager->getClassMetadata($mapping['target']);
 
-                $converter = function ($value) use ($target) {
+                $converter = function($value) use ($target) {
                     if (!is_object($value)) {
                         return $value;
                     }
@@ -70,7 +70,7 @@ 
                     $values = $converter($values);
                 }
             } else {
-                $caster = function ($value) use ($field) {
+                $caster = function($value) use ($field) {
                     $type = $this->manager
                         ->getConfiguration()
                         ->getTypeRegistry()->get($this->metadata->getTypeOfField($field));

Tests/ReferenceLoadingTest.php

Spacing +5 added lines, -5 removed lines

@@ -187,7 +187,7 @@ 
                     ],
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertNull($request->getParameters()['criteria']['parent']);
 
                 return true;
@@ -208,7 +208,7 @@ 
                     ],
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertNull($request->getParameters()['criteria']['payload']);
 
                 return true;
@@ -232,7 +232,7 @@ 
                     'sub-payload' => 'sub-payload',
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-entity/find', $request->getMethod());
                 self::assertEquals(['id' => 1], $request->getParameters());
 
@@ -256,7 +256,7 @@ 
                     ],
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-reference/search', $request->getMethod());
                 self::assertEquals(
                     [
@@ -300,7 +300,7 @@ 
                     'owner'             => null,
                 ]
             ),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('test-reference/find', $request->getMethod());
                 self::assertEquals(['id' => 1], $request->getParameters());