bankiru / doctrine-api-client

EntityManager.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use Bankiru\Api\Doctrine\Proxy\ApiCollection;
 use Bankiru\Api\Doctrine\Proxy\ProxyFactory;
 use Bankiru\Api\Doctrine\Utility\IdentifierFixer;
-use Doctrine\Common\Collections\AbstractLazyCollection;
 use Doctrine\Common\Persistence\ObjectRepository;
 use Doctrine\Common\Proxy\Proxy;
 

EntityRepository.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace Bankiru\Api\Doctrine;
 
 use Bankiru\Api\Doctrine\Mapping\ApiMetadata;
-use Bankiru\Api\Doctrine\Proxy\ApiCollection;
-use Doctrine\Common\Collections\Collection;
 use Doctrine\Common\Persistence\ObjectRepository;
 use ScayTrase\Api\Rpc\RpcClientInterface;
 

Proxy/ApiCollection.php

Doc Comments +4 added lines, -1 removed lines

@@ -188,6 +188,9 @@ 
         return $this->snapshot;
     }
 
+    /**
+     * @param boolean $state
+     */
     public function setInitialized($state)
     {
         $this->initialized = (bool)$state;
@@ -452,7 +455,7 @@ 
      * Internal note: Tried to implement Serializable first but that did not work well
      *                with circular references. This solution seems simpler and works well.
      *
-     * @return array
+     * @return string[]
      */
     public function __sleep()
     {

Spacing +2 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
         return array_udiff_assoc(
             $this->snapshot,
             $this->collection->toArray(),
-            function ($a, $b) {
+            function($a, $b) {
                 return $a === $b ? 0 : 1;
             }
         );
@@ -221,7 +221,7 @@ 
         return array_udiff_assoc(
             $this->collection->toArray(),
             $this->snapshot,
-            function ($a, $b) {
+            function($a, $b) {
                 return $a === $b ? 0 : 1;
             }
         );

Tests/AbstractEntityManagerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     private $clients = [];
 
     /**
-     * @return mixed
+     * @return ClientRegistryInterface
      */
     public function getRegistry()
     {

Spacing +2 added lines, -2 removed lines

@@ -101,14 +101,14 @@
         $configuration->setRegistry($this->registry);
         $configuration->setTypeRegistry(new BaseTypeRegistry(new TypeRegistry()));
         $configuration->setResolver(new ConstructorFactoryResolver());
-        $configuration->setProxyDir(CACHE_DIR.'/doctrine/proxy/');
+        $configuration->setProxyDir(CACHE_DIR . '/doctrine/proxy/');
         $configuration->setProxyNamespace('Bankiru\Api\Doctrine\Test\Proxy');
         $driver = new MappingDriverChain();
         $driver->addDriver(
             new YmlMetadataDriver(
                 new SymfonyFileLocator(
                     [
-                        __DIR__.'/../Test/Resources/config/api/' => 'Bankiru\Api\Doctrine\Test\Entity',
+                        __DIR__ . '/../Test/Resources/config/api/' => 'Bankiru\Api\Doctrine\Test\Entity',
                     ],
                     '.api.yml',
                     DIRECTORY_SEPARATOR

UnitOfWork.php

Doc Comments +1 added lines, -1 removed lines

@@ -167,7 +167,7 @@
     }
 
     /**
-     * @param             $className
+     * @param             string $className
      * @param \stdClass   $data
      *
      * @return ObjectManagerAware|object

Spacing +5 added lines, -5 removed lines

@@ -1683,7 +1683,7 @@ 
         $class               = $this->em->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->associationMappings,
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeRefresh'];
             }
         );
@@ -1722,7 +1722,7 @@ 
         $class               = $this->em->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->associationMappings,
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeDetach'];
             }
         );
@@ -1762,7 +1762,7 @@ 
         $class               = $this->manager->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->getAssociationMappings(),
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeMerge'];
             }
         );
@@ -1800,11 +1800,11 @@ 
         $class               = $this->em->getClassMetadata(get_class($entity));
         $associationMappings = array_filter(
             $class->associationMappings,
-            function ($assoc) {
+            function($assoc) {
                 return $assoc['isCascadeRemove'];
             }
         );
-        $entitiesToCascade   = [];
+        $entitiesToCascade = [];
         foreach ($associationMappings as $assoc) {
             if ($entity instanceof Proxy && !$entity->__isInitialized__) {
                 $entity->__load();

Cache/KeyStrategyInterface.php

Spacing +1 added lines, -1 removed lines

@@ -24,5 +24,5 @@
      *
      * @return string
      */
-    public function getEntityKey(ApiMetadata $metadata,array $identifier);
+    public function getEntityKey(ApiMetadata $metadata, array $identifier);
 }

Mapping/EntityMetadata.php

Spacing +1 added lines, -1 removed lines

@@ -491,7 +491,7 @@
         }
 
         // Fetch mode. Default fetch mode to LAZY, if not set.
-        if ( ! isset($mapping['fetch'])) {
+        if (!isset($mapping['fetch'])) {
             $mapping['fetch'] = self::FETCH_LAZY;
         }
 

Rpc/SearchArgumentsTransformer.php

Spacing +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
                 /** @var EntityMetadata $target */
                 $target = $this->manager->getClassMetadata($mapping['target']);
 
-                $converter = function ($value) use ($target) {
+                $converter = function($value) use ($target) {
                     if (!is_object($value)) {
                         return $value;
                     }
@@ -70,7 +70,7 @@ 
                     $values = $converter($values);
                 }
             } else {
-                $caster = function ($value) use ($field) {
+                $caster = function($value) use ($field) {
                     $type = $this->manager
                         ->getConfiguration()
                         ->getTypeRegistry()->get($this->metadata->getTypeOfField($field));

Tests/CustomRepositoryTest.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
         $repository = $this->getManager()->getRepository(CustomEntity::class);
         $this->getClient()->push(
             $this->getResponseMock(true, (object)['customField' => 'custom-response']),
-            function (RpcRequestInterface $request) {
+            function(RpcRequestInterface $request) {
                 self::assertEquals('custom-entity/custom', $request->getMethod());
                 self::assertEquals(
                     ['param1' => 'value1'],