Bankiru\Api\Doctrine\UnitOfWork::commit()

Complexity

Conditions	23
Paths	644

Size

Total Lines	77
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function commit($entity = null)
    {
        // Compute changes done since last commit.
        if ($entity === null) {
            $this->computeChangeSets();
        } elseif (is_object($entity)) {
            $this->computeSingleEntityChangeSet($entity);
        } elseif (is_array($entity)) {
            foreach ((array)$entity as $object) {
                $this->computeSingleEntityChangeSet($object);
            }
        }
        if (!($this->entityInsertions ||

The expression $this->entityInsertions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

              $this->entityDeletions ||

The expression $this->entityDeletions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

              $this->entityUpdates ||

The expression $this->entityUpdates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

              $this->collectionUpdates ||

The expression $this->collectionUpdates of type Bankiru\Api\Doctrine\Proxy\ApiCollection[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

              $this->collectionDeletions ||

The expression $this->collectionDeletions of type Bankiru\Api\Doctrine\Proxy\ApiCollection[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

              $this->orphanRemovals)

The expression $this->orphanRemovals of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

        ) {
            return; // Nothing to do.
        }
        if ($this->orphanRemovals) {

The expression $this->orphanRemovals of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->orphanRemovals as $orphan) {
                $this->remove($orphan);

The method remove() does not exist on Bankiru\Api\Doctrine\UnitOfWork. Did you maybe mean removeFromIdentityMap()?

            }
        }
        // Now we need a commit order to maintain referential integrity
        $commitOrder = $this->getCommitOrder();

        // Collection deletions (deletions of complete collections)
        // foreach ($this->collectionDeletions as $collectionToDelete) {

58% of this comment could be valid code. Did you maybe forget this after debugging?

        //       //fixme: collection mutations
        //       $this->getCollectionPersister($collectionToDelete->getMapping())->delete($collectionToDelete);

77% of this comment could be valid code. Did you maybe forget this after debugging?

        // }
        if ($this->entityInsertions) {

The expression $this->entityInsertions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($commitOrder as $class) {
                $this->executeInserts($class);
            }
        }
        if ($this->entityUpdates) {

The expression $this->entityUpdates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($commitOrder as $class) {
                $this->executeUpdates($class);
            }
        }
        // Extra updates that were requested by persisters.
        if ($this->extraUpdates) {

The expression $this->extraUpdates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->executeExtraUpdates();
        }
        // Collection updates (deleteRows, updateRows, insertRows)
        foreach ($this->collectionUpdates as $collectionToUpdate) {

This foreach statement is empty and can be removed.

            //fixme: decide what to do with collection mutation if API does not support this
            //$this->getCollectionPersister($collectionToUpdate->getMapping())->update($collectionToUpdate);

82% of this comment could be valid code. Did you maybe forget this after debugging?

        }
        // Entity deletions come last and need to be in reverse commit order
        if ($this->entityDeletions) {

The expression $this->entityDeletions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            for ($count = count($commitOrder), $i = $count - 1; $i >= 0 && $this->entityDeletions; --$i) {

The expression $this->entityDeletions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $this->executeDeletions($commitOrder[$i]);
            }
        }

        // Take new snapshots from visited collections
        foreach ($this->visitedCollections as $coll) {
            $coll->takeSnapshot();
        }

        // Clear up
        $this->entityInsertions =
        $this->entityUpdates =
        $this->entityDeletions =
        $this->extraUpdates =
        $this->entityChangeSets =
        $this->collectionUpdates =
        $this->collectionDeletions =
        $this->visitedCollections =
        $this->scheduledForSynchronization =
        $this->orphanRemovals = [];
    }