ProxyTestAbstract::getClientNames() - Code Metrics - Inspection of "[WIP] Release 2.0" - bankiru/doctrine-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Pavel

created 2016-10-27 08:14 UTC

ProxyTestAbstract::getClientNames() A

↳ Parent: ProxyTestAbstract

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Bankiru\Api\Doctrine\Tests;

use Bankiru\Api\Doctrine\Test\Entity\Sub\SubEntity;
use Doctrine\Common\Proxy\Proxy;
use ScayTrase\Api\Rpc\RpcRequestInterface;

class ProxyTestAbstract extends AbstractEntityManagerTest
{
    public function testLazyProxy()
    {
        $manager = $this->getManager();

        $this->getClient()->push(
            $this->getResponseMock(
                true,
                (object)[
                    'id'          => 2,
                    'payload'     => 'test-payload',
                    'sub-payload' => 'sub-payload',
                ]
            ),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-entity/find', $request->getMethod());
                self::assertEquals(['id' => 2], $request->getParameters());

                return true;
            }
        );

        /** @var SubEntity|Proxy $entity */
        $entity = $manager->getReference(SubEntity::class, 2);

        //Test that entity is a proxy and request was not send
        self::assertInstanceOf(Proxy::class, $entity);
        self::assertFalse($entity->__isInitialized());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        self::assertCount(1, $this->getClient());

        //Test that we can obtain ID and request was still not sent
        self::assertEquals(2, $entity->getId());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        self::assertInstanceOf(Proxy::class, $entity);
        self::assertFalse($entity->__isInitialized());
        self::assertCount(1, $this->getClient());

        //Test that we can obtain data and request was sent
        self::assertInstanceOf(SubEntity::class, $entity);
        self::assertEquals('test-payload', $entity->getPayload());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        self::assertEquals('sub-payload', $entity->getSubPayload());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        //Test that we are still a Proxy object
        self::assertInstanceOf(Proxy::class, $entity);
        self::assertTrue($entity->__isInitialized());
        self::assertCount(0, $this->getClient());
    }

    public function testSimpleProxy()

    {
        $repository = $this->getManager()->getRepository(SubEntity::class);

        $this->getClient()->push(
            $this->getResponseMock(
                true,
                (object)[
                    'id'          => 2,
                    'payload'     => 'test-payload',
                    'sub-payload' => 'sub-payload',
                ]
            ),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-entity/find', $request->getMethod());
                self::assertEquals(['id' => 2], $request->getParameters());

                return true;
            }
        );

        /** @var SubEntity $entity */
        $entity = $repository->find(2);

        //Test that we can obtain data and request was sent
        self::assertInstanceOf(SubEntity::class, $entity);
        self::assertEquals(2, $entity->getId());
        self::assertEquals('test-payload', $entity->getPayload());
        self::assertEquals('sub-payload', $entity->getSubPayload());
    }

    protected function getClientNames()
    {
        return [self::DEFAULT_CLIENT, 'test-reference-client'];
    }
}


1		<?php
2
3		namespace Bankiru\Api\Doctrine\Tests;
4
5		use Bankiru\Api\Doctrine\Test\Entity\Sub\SubEntity;
6		use Doctrine\Common\Proxy\Proxy;
7		use ScayTrase\Api\Rpc\RpcRequestInterface;
8
9		class ProxyTestAbstract extends AbstractEntityManagerTest
10		{
11		public function testLazyProxy()
12		{
13		$manager = $this->getManager();
14
15		$this->getClient()->push(
16		$this->getResponseMock(
17		true,
18		(object)[
19		'id' => 2,
20		'payload' => 'test-payload',
21		'sub-payload' => 'sub-payload',
22		]
23		),
24		function (RpcRequestInterface $request) {
25		self::assertEquals('test-entity/find', $request->getMethod());
26		self::assertEquals(['id' => 2], $request->getParameters());
27
28		return true;
29		}
30		);
31
32		/** @var SubEntity\|Proxy $entity */
33		$entity = $manager->getReference(SubEntity::class, 2);
34
35		//Test that entity is a proxy and request was not send
36		self::assertInstanceOf(Proxy::class, $entity);
37		self::assertFalse($entity->__isInitialized());
		0 ignored issues – show Bug introduced 2016-10-20 19:34 UTC by Report Bug Copy Issue Report The method `__isInitialized` does only exist in `Doctrine\Common\Proxy\Proxy`, but not in `Bankiru\Api\Doctrine\Test\Entity\Sub\SubEntity`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38		self::assertCount(1, $this->getClient());
39
40		//Test that we can obtain ID and request was still not sent
41		self::assertEquals(2, $entity->getId());
		0 ignored issues – show Bug introduced 2016-10-20 19:34 UTC by Report Bug Copy Issue Report The method `getId` does only exist in `Bankiru\Api\Doctrine\Test\Entity\Sub\SubEntity`, but not in `Doctrine\Common\Proxy\Proxy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
42		self::assertInstanceOf(Proxy::class, $entity);
43		self::assertFalse($entity->__isInitialized());
44		self::assertCount(1, $this->getClient());
45
46		//Test that we can obtain data and request was sent
47		self::assertInstanceOf(SubEntity::class, $entity);
48		self::assertEquals('test-payload', $entity->getPayload());
		0 ignored issues – show Bug introduced 2016-10-20 19:34 UTC by Report Bug Copy Issue Report The method `getPayload` does only exist in `Bankiru\Api\Doctrine\Test\Entity\Sub\SubEntity`, but not in `Doctrine\Common\Proxy\Proxy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
49		self::assertEquals('sub-payload', $entity->getSubPayload());
		0 ignored issues – show Bug introduced 2016-10-20 19:34 UTC by Report Bug Copy Issue Report The method `getSubPayload` does only exist in `Bankiru\Api\Doctrine\Test\Entity\Sub\SubEntity`, but not in `Doctrine\Common\Proxy\Proxy`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50
51		//Test that we are still a Proxy object
52		self::assertInstanceOf(Proxy::class, $entity);
53		self::assertTrue($entity->__isInitialized());
54		self::assertCount(0, $this->getClient());
55		}
56
57	View Code Duplication	public function testSimpleProxy()
		0 ignored issues – show Duplication introduced 2016-05-12 09:51 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$repository = $this->getManager()->getRepository(SubEntity::class);
60
61		$this->getClient()->push(
62		$this->getResponseMock(
63		true,
64		(object)[
65		'id' => 2,
66		'payload' => 'test-payload',
67		'sub-payload' => 'sub-payload',
68		]
69		),
70		function (RpcRequestInterface $request) {
71		self::assertEquals('test-entity/find', $request->getMethod());
72		self::assertEquals(['id' => 2], $request->getParameters());
73
74		return true;
75		}
76		);
77
78		/** @var SubEntity $entity */
79		$entity = $repository->find(2);
80
81		//Test that we can obtain data and request was sent
82		self::assertInstanceOf(SubEntity::class, $entity);
83		self::assertEquals(2, $entity->getId());
84		self::assertEquals('test-payload', $entity->getPayload());
85		self::assertEquals('sub-payload', $entity->getSubPayload());
86		}
87
88		protected function getClientNames()
89		{
90		return [self::DEFAULT_CLIENT, 'test-reference-client'];
91		}
92		}
93

bankiru / doctrine-api-client

Pull Request — master (#14)

ProxyTestAbstract::getClientNames() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like