TypeTest::testValuesConvertedToAPI() - Code Metrics - Inspection of "[WIP] Release 2.0" - bankiru/doctrine-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Pull Request — master (#14)

by Pavel

created 2017-05-03 07:00 UTC

TypeTest::testValuesConvertedToAPI() B

↳ Parent: TypeTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	32
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
c	0
b	0
f	0
rs	8.8571
cc	1
eloc	19
nc	1
nop	0

<?php

namespace Bankiru\Api\Doctrine\Tests;

use Bankiru\Api\Doctrine\Test\Entity\TypeEntity;
use ScayTrase\Api\Rpc\RpcRequestInterface;

class TypeTest extends AbstractEntityManagerTest
{
    const U_TIMESTAMP = 100500;
    const CUSTOM_DATETIME = '2010.10.10 00:00:00';

    public function testValuesConvertedToAPI()
    {
        $manager = $this->getManager();

        $entity    = new TypeEntity();
        $datetimeU = new \DateTime();
        $datetimeU->setTimestamp(self::U_TIMESTAMP);
        $entity->setDatetimeU($datetimeU);

        $datetimeC = \DateTime::createFromFormat('Y.m.d H:i:s',self::CUSTOM_DATETIME);
        $entity->setDatetimeC($datetimeC);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}

        $manager->persist($entity);

        $this->getClient()->push(
            $this->getResponseMock(true, (object)['id' => 42]),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-entity/create', $request->getMethod());
                self::assertEquals(
                    [
                        'datetime_u' => self::U_TIMESTAMP,
                        'datetime_c' => self::CUSTOM_DATETIME,
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );

        $manager->flush();
    }

    public function testValuesConvertedFromAPI()
    {
        $manager = $this->getManager();

        $this->getClient()->push(
            $this->getResponseMock(
                true,
                (object)[
                    'id'       => 1,
                    'datetime_u' => self::U_TIMESTAMP,
                    'datetime_c' => self::CUSTOM_DATETIME,
                ]
            ),
            function (RpcRequestInterface $request) {
                self::assertEquals('test-entity/find', $request->getMethod());
                self::assertEquals(
                    [
                        'id' => 1,
                    ],
                    $request->getParameters()
                );

                return true;
            }
        );

        $entity = $manager->getRepository(TypeEntity::class)->find(1);
        self::assertNotNull($entity->getDatetimeU());
        self::assertNotNull($entity->getDatetimeC());
        self::assertEquals(self::U_TIMESTAMP, $entity->getDatetimeU()->getTimestamp());
        self::assertEquals(self::CUSTOM_DATETIME, $entity->getDatetimeC()->format('Y.m.d H:i:s'));
    }
}


1			<?php
2
3			namespace Bankiru\Api\Doctrine\Tests;
4
5			use Bankiru\Api\Doctrine\Test\Entity\TypeEntity;
6			use ScayTrase\Api\Rpc\RpcRequestInterface;
7
8			class TypeTest extends AbstractEntityManagerTest
9			{
10			const U_TIMESTAMP = 100500;
11			const CUSTOM_DATETIME = '2010.10.10 00:00:00';
12
13			public function testValuesConvertedToAPI()
14			{
15			$manager = $this->getManager();
16
17			$entity = new TypeEntity();
18			$datetimeU = new \DateTime();
19			$datetimeU->setTimestamp(self::U_TIMESTAMP);
20			$entity->setDatetimeU($datetimeU);
21
22			$datetimeC = \DateTime::createFromFormat('Y.m.d H:i:s',self::CUSTOM_DATETIME);
23			$entity->setDatetimeC($datetimeC);
			0 ignored issues – show Security Bug introduced 2017-04-28 11:55 UTC by Report Bug Copy Issue Report It seems like `$datetimeC` defined by `\DateTime::createFromFor... self::CUSTOM_DATETIME)` on line `22` can also be of type `false`; however, `Bankiru\Api\Doctrine\Tes...eEntity::setDatetimeC()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
24
25			$manager->persist($entity);
26
27			$this->getClient()->push(
28			$this->getResponseMock(true, (object)['id' => 42]),
29			function (RpcRequestInterface $request) {
30			self::assertEquals('test-entity/create', $request->getMethod());
31			self::assertEquals(
32			[
33			'datetime_u' => self::U_TIMESTAMP,
34			'datetime_c' => self::CUSTOM_DATETIME,
35			],
36			$request->getParameters()
37			);
38
39			return true;
40			}
41			);
42
43			$manager->flush();
44			}
45
46			public function testValuesConvertedFromAPI()
47			{
48			$manager = $this->getManager();
49
50			$this->getClient()->push(
51			$this->getResponseMock(
52			true,
53			(object)[
54			'id' => 1,
55			'datetime_u' => self::U_TIMESTAMP,
56			'datetime_c' => self::CUSTOM_DATETIME,
57			]
58			),
59			function (RpcRequestInterface $request) {
60			self::assertEquals('test-entity/find', $request->getMethod());
61			self::assertEquals(
62			[
63			'id' => 1,
64			],
65			$request->getParameters()
66			);
67
68			return true;
69			}
70			);
71
72			$entity = $manager->getRepository(TypeEntity::class)->find(1);
73			self::assertNotNull($entity->getDatetimeU());
74			self::assertNotNull($entity->getDatetimeC());
75			self::assertEquals(self::U_TIMESTAMP, $entity->getDatetimeU()->getTimestamp());
76			self::assertEquals(self::CUSTOM_DATETIME, $entity->getDatetimeC()->format('Y.m.d H:i:s'));
77			}
78			}
79

bankiru / doctrine-api-client

Pull Request — master (#14)

TypeTest::testValuesConvertedToAPI() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like