balint777 /
POData
| Conditions | 10 |
| Paths | 18 |
| Total Lines | 24 |
| Code Lines | 16 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 49 | public function getService($serviceType) |
||
| 50 | { |
||
| 51 | if (($serviceType === 'IMetadataProvider') || |
||
| 52 | ($serviceType === 'IQueryProvider') || |
||
| 53 | ($serviceType === 'IStreamProvider')) { |
||
| 54 | if (is_null($this->_wordPressExpressionProvider)) { |
||
| 55 | $this->_wordPressExpressionProvider = new WordPressDSExpressionProvider(); |
||
| 56 | } |
||
| 57 | } |
||
| 58 | if ($serviceType === 'IMetadataProvider') { |
||
| 59 | if (is_null($this->_wordPressMetadata)) { |
||
| 60 | $this->_wordPressMetadata = CreateWordPressMetadata::create(); |
||
| 61 | // $this->_wordPressMetadata->mappedDetails = CreateWordPressMetadata::mappingInitialize(); |
||
| 62 | } |
||
| 63 | return $this->_wordPressMetadata; |
||
| 64 | } else if ($serviceType === 'IQueryProvider') { |
||
| 65 | if (is_null($this->_wordPressQueryProvider)) { |
||
| 66 | $this->_wordPressQueryProvider = new WordPressQueryProvider(); |
||
| 67 | } |
||
| 68 | return $this->_wordPressQueryProvider; |
||
| 69 | } else if ($serviceType === 'IStreamProvider') { |
||
| 70 | return new WordPressStreamProvider(); |
||
| 71 | } |
||
| 72 | return null; |
||
| 73 | } |
||
| 75 |
Loading history...