balint777 /
POData
| Total Complexity | 59 |
| Total Lines | 355 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like WordPressDSExpressionProvider often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use WordPressDSExpressionProvider, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class WordPressDSExpressionProvider implements IExpressionProvider |
||
| 11 | { |
||
| 12 | const ADD = '+'; |
||
| 13 | const CLOSE_BRACKET = ')'; |
||
| 14 | const COMMA = ','; |
||
| 15 | const DIVIDE = '/'; |
||
| 16 | const SUBTRACT = '-'; |
||
| 17 | const EQUAL = '='; |
||
| 18 | const GREATERTHAN = '>'; |
||
| 19 | const GREATERTHAN_OR_EQUAL = '>='; |
||
| 20 | const LESSTHAN = '<'; |
||
| 21 | const LESSTHAN_OR_EQUAL = '<='; |
||
| 22 | const LOGICAL_AND = '&&'; |
||
| 23 | const LOGICAL_NOT = '!'; |
||
| 24 | const LOGICAL_OR = '||'; |
||
| 25 | const MEMBERACCESS = ''; |
||
| 26 | const MODULO = '%'; |
||
| 27 | const MULTIPLY = '*'; |
||
| 28 | const NEGATE = '-'; |
||
| 29 | const NOTEQUAL = '!='; |
||
| 30 | const OPEN_BRAKET = '('; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * The type of the resource pointed by the resource path segement |
||
| 34 | * |
||
| 35 | * @var ResourceType |
||
| 36 | */ |
||
| 37 | private $_resourceType; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * |
||
| 41 | * @var array(string, array(string, string)) |
||
| 42 | */ |
||
| 43 | private $_entityMapping; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Constructs new instance of WordPressDSExpressionProvider |
||
| 47 | * |
||
| 48 | */ |
||
| 49 | public function __construct() |
||
| 50 | { |
||
| 51 | $this->_entityMapping = CreateWordPressMetadata::getEntityMapping(); |
||
| 52 | } |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Get the name of the iterator |
||
| 56 | * |
||
| 57 | * @return string |
||
| 58 | */ |
||
| 59 | public function getIteratorName() |
||
| 62 | } |
||
| 63 | |||
| 64 | /** |
||
| 65 | * call-back for setting the resource type. |
||
| 66 | * |
||
| 67 | * @param ResourceType $resourceType The resource type on which the filter |
||
| 68 | * is going to be applied. |
||
| 69 | */ |
||
| 70 | public function setResourceType(ResourceType $resourceType) |
||
| 73 | } |
||
| 74 | |||
| 75 | /** |
||
| 76 | * Call-back for logical expression |
||
| 77 | * |
||
| 78 | * @param ExpressionType $expressionType The type of logical expression. |
||
| 79 | * @param string $left The left expression. |
||
| 80 | * @param string $right The left expression. |
||
| 81 | * |
||
| 82 | * @return string |
||
| 83 | */ |
||
| 84 | public function onLogicalExpression($expressionType, $left, $right) |
||
| 85 | { |
||
| 86 | switch ($expressionType) { |
||
| 87 | case ExpressionType::AND_LOGICAL: |
||
| 88 | return $this->_prepareBinaryExpression(self::LOGICAL_AND, $left, $right); |
||
| 89 | break; |
||
|
|
|||
| 90 | case ExpressionType::OR_LOGICAL: |
||
| 91 | return $this->_prepareBinaryExpression(self::LOGICAL_OR, $left, $right); |
||
| 92 | break; |
||
| 93 | default: |
||
| 94 | throw new \InvalidArgumentException('onLogicalExpression'); |
||
| 95 | } |
||
| 96 | } |
||
| 97 | |||
| 98 | /** |
||
| 99 | * Call-back for arithmetic expression |
||
| 100 | * |
||
| 101 | * @param ExpressionType $expressionType The type of arithmetic expression. |
||
| 102 | * @param string $left The left expression. |
||
| 103 | * @param string $right The left expression. |
||
| 104 | * |
||
| 105 | * @return string |
||
| 106 | */ |
||
| 107 | public function onArithmeticExpression($expressionType, $left, $right) |
||
| 127 | } |
||
| 128 | } |
||
| 129 | |||
| 130 | /** |
||
| 131 | * Call-back for relational expression |
||
| 132 | * |
||
| 133 | * @param ExpressionType $expressionType The type of relation expression |
||
| 134 | * @param string $left The left expression |
||
| 135 | * @param string $right The left expression |
||
| 136 | * |
||
| 137 | * @return string |
||
| 138 | */ |
||
| 139 | public function onRelationalExpression($expressionType, $left, $right) |
||
| 166 | } |
||
| 167 | } |
||
| 168 | |||
| 169 | /** |
||
| 170 | * Call-back for unary expression |
||
| 171 | * |
||
| 172 | * @param ExpressionType $expressionType The type of unary expression |
||
| 173 | * @param string $child The child expression |
||
| 174 | * |
||
| 175 | * @return string |
||
| 176 | */ |
||
| 177 | public function onUnaryExpression($expressionType, $child) |
||
| 188 | } |
||
| 189 | } |
||
| 190 | |||
| 191 | /** |
||
| 192 | * Call-back for constant expression |
||
| 193 | * |
||
| 194 | * @param IType $type The type of constant |
||
| 195 | * @param objetc $value The value of the constant |
||
| 196 | * |
||
| 197 | * @return string |
||
| 198 | */ |
||
| 199 | public function onConstantExpression(IType $type, $value) |
||
| 200 | { |
||
| 201 | if (is_bool($value)) { |
||
| 202 | return var_export($value, true); |
||
| 203 | } else if (is_null($value)) { |
||
| 204 | return var_export(null, true); |
||
| 205 | } |
||
| 206 | |||
| 207 | return $value; |
||
| 208 | } |
||
| 209 | |||
| 210 | /** |
||
| 211 | * Call-back for property access expression |
||
| 212 | * |
||
| 213 | * @param PropertyAccessExpression $expression The property access expression |
||
| 214 | * |
||
| 215 | * @return string |
||
| 216 | */ |
||
| 217 | |||
| 218 | public function onPropertyAccessExpression($expression) |
||
| 233 | } |
||
| 234 | |||
| 235 | /** |
||
| 236 | * Call-back for function call expression |
||
| 237 | * |
||
| 238 | * @param FunctionDescription $functionDescription Description of the function. |
||
| 239 | * @param array<string> $params Paameters to the function. |
||
| 240 | * |
||
| 241 | * @return string |
||
| 242 | */ |
||
| 243 | public function onFunctionCallExpression($functionDescription, $params) |
||
| 325 | } |
||
| 326 | } |
||
| 327 | |||
| 328 | /** |
||
| 329 | * To format binary expression |
||
| 330 | * |
||
| 331 | * @param string $operator The binary operator. |
||
| 332 | * @param string $left The left operand. |
||
| 333 | * @param string $right The right operand. |
||
| 334 | * |
||
| 335 | * @return string |
||
| 336 | */ |
||
| 337 | private function _prepareBinaryExpression($operator, $left, $right) |
||
| 338 | { |
||
| 339 | // Special handling for DATETIMECMP |
||
| 340 | if (!substr_compare($left, "DATETIMECMP", 0, 11)) { |
||
| 341 | $str = explode(';', $left, 2); |
||
| 342 | $str[0] = str_replace('DATETIMECMP', '', $str[0]); |
||
| 343 | return self::OPEN_BRAKET |
||
| 344 | . $str[0] . ' ' . $operator |
||
| 345 | . ' ' . $str[1] . self::CLOSE_BRACKET; |
||
| 346 | } |
||
| 347 | |||
| 348 | return |
||
| 349 | self::OPEN_BRAKET |
||
| 350 | . $left . ' ' . $operator |
||
| 351 | . ' ' . $right . self::CLOSE_BRACKET; |
||
| 352 | } |
||
| 353 | |||
| 354 | /** |
||
| 355 | * To format unary expression |
||
| 356 | * |
||
| 357 | * @param string $operator The unary operator. |
||
| 358 | * @param string $child The operand. |
||
| 359 | * |
||
| 360 | * @return string |
||
| 361 | */ |
||
| 362 | private function _prepareUnaryExpression($operator, $child) |
||
| 365 | } |
||
| 366 | } |
||
| 367 |
Loading history...
The
breakstatement is not necessary if it is preceded for example by areturnstatement:If you would like to keep this construct to be consistent with other
casestatements, you can safely mark this issue as a false-positive.