OrderByParser::_buildOrderByTree() - Code Metrics - Inspection of "merge" - balint777/POData - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 55beca...b509a7 )

by Bálint
created 2018-08-08 12:59 UTC
OrderByParser::_buildOrderByTree() F

↳ Parent: OrderByParser
Complexity

Conditions	29
Paths	241
Size

Total Lines
190
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
dl	0
loc	190
rs	2.2566
c	0
b	0
f	0
cc	29
nc	241
nop	1
How to fix Long Method Complexity

<?php

namespace POData\UriProcessor\QueryProcessor\OrderByParser;

use POData\UriProcessor\QueryProcessor\AnonymousFunction;
use POData\UriProcessor\QueryProcessor\ExpressionParser\ExpressionLexer;
use POData\UriProcessor\QueryProcessor\ExpressionParser\ExpressionTokenId;
use POData\Providers\ProvidersWrapper;
use POData\Providers\Metadata\Type\Binary;
use POData\Providers\Metadata\ResourceSetWrapper;
use POData\Providers\Metadata\ResourceType;
use POData\Providers\Metadata\ResourcePropertyKind;
use POData\Common\ODataException;
use POData\Common\Messages;

/**
 * Class OrderByParser
 *
 * Class to parse $orderby query option and perform syntax validation
 * and build 'OrderBy Tree' along with next level of validation, the
 * created tree is used for building sort functions and 'OrderByInfo' structure.
 *
 * The syntax of orderby clause is:
 *
 * OrderByClause         : OrderByPathSegment [, OrderByPathSegment]*
 * OrderByPathSegment    : OrderBySubPathSegment[/OrderBySubPathSegment]*[asc|desc]?
 * OrderBySubPathSegment : identifier
 *
 * @package POData\UriProcessor\QueryProcessor\OrderByParser
 */
class OrderByParser
{

    /**
     * The top level sorter function generated from orderby path
     * segments.
     *
     * @var AnonymousFunction
     */
    private $_topLevelComparisonFunction;


    /**
     * The structure holds information about the navigation properties
     * used in the orderby clause (if any) and orderby path if IDSQP
     * implementor want to perform sorting.
     *
     * @var OrderByInfo
     */
    private $_orderByInfo;

    /**
     * Reference to metadata and query provider wrapper
     *
     * @var ProvidersWrapper
     */
    private $_providerWrapper;

    /**
     * This object will be of type of the resource set identified by the
     * request uri.
     *
     * @var mixed
     */
    private $_dummyObject;

    /**
     * Creates new instance of OrderByParser
     *
     * @param ProvidersWrapper $providerWrapper Reference to metadata
     *                                                      and query provider
     *                                                      wrapper
     */
    private function __construct(ProvidersWrapper $providerWrapper)
    {
        $this->_providerWrapper = $providerWrapper;
    }

    /**
     * This function perform the following tasks with the help of internal helper
     * functions
     * (1) Read the orderby clause and perform basic syntax errors
     * (2) Build 'Order By Tree', creates anonymous sorter function for each leaf
     *     node and check for error
     * (3) Build 'OrderInfo' structure, holds information about the navigation
     *     properties used in the orderby clause (if any) and orderby path if
     *     IDSQP implementor want to perform sorting
     * (4) Build top level anonymous sorter function
     * (4) Release resources hold by the 'Order By Tree'
     * (5) Create 'InternalOrderInfo' structure, which wraps 'OrderInfo' and top
     *     level sorter function
     *
     * @param ResourceSetWrapper           $resourceSetWrapper ResourceSetWrapper for the resource targeted by resource path.
     * @param ResourceType                 $resourceType       ResourceType for the resource targeted by resource path.
     * @param string                       $orderBy            The orderby clause.
     * @param ProvidersWrapper $providerWrapper    Reference to the wrapper for IDSQP and IDSMP impl.
     *
     * @return InternalOrderByInfo
     *
     * @throws ODataException If any error occur while parsing orderby clause
     */
    public static function parseOrderByClause(
        ResourceSetWrapper $resourceSetWrapper,
        ResourceType $resourceType,
        $orderBy,
        ProvidersWrapper $providerWrapper
    ) {
        $orderByParser = new OrderByParser($providerWrapper);
        try {
            $orderByParser->_dummyObject = $resourceType->getInstanceType()->newInstanceWithoutConstructor();
        } catch (\ReflectionException $reflectionException) {
            throw ODataException::createInternalServerError(Messages::orderByParserFailedToCreateDummyObject());
        }
        $orderByParser->_rootOrderByNode = new OrderByRootNode($resourceSetWrapper, $resourceType);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $orderByPathSegments = $orderByParser->_readOrderBy($orderBy);
        $orderByParser->_buildOrderByTree($orderByPathSegments);
        $orderByParser->_createOrderInfo($orderByPathSegments);
        //Recursively release the resources
        $orderByParser->_rootOrderByNode->free();
        //creates internal order info wrapper
        $internalOrderInfo = new InternalOrderByInfo(
            $orderByParser->_orderByInfo,
            $orderByParser->_dummyObject
        );
        unset($orderByParser->_orderByInfo);
        unset($orderByParser->_topLevelComparisonFunction);
        return $internalOrderInfo;
    }

    /**
     * Build 'OrderBy Tree' from the given orderby path segments, also build
     * comparsion function for each path segment.
     *
     * @param array(array) &$orderByPathSegments Collection of orderby path segments,
     *                                           this is passed by reference
     *                                           since we need this function to
     *                                           modify this array in two cases:
     *                                           1. if asc or desc present, then the
     *                                              corresponding sub path segment
     *                                              should be removed
     *                                           2. remove duplicate orderby path
     *                                              segment
     *
     * @return void
     *
     * @throws ODataException If any error occurs while processing the orderby path
     *                        segments
     */
    private function _buildOrderByTree(&$orderByPathSegments)
    {
        foreach ($orderByPathSegments as $index1 => &$orderBySubPathSegments) {
            $currentNode = $this->_rootOrderByNode;
            $currentObject = $this->_dummyObject;
            $ascending = true;
            $subPathCount = count($orderBySubPathSegments);
            // Check sort order is specified in the path, if so set a
            // flag and remove that segment
            if ($subPathCount > 1) {
                if ($orderBySubPathSegments[$subPathCount - 1] === '*desc') {
                    $ascending = false;
                    unset($orderBySubPathSegments[$subPathCount - 1]);
                    $subPathCount--;
                } else if ($orderBySubPathSegments[$subPathCount - 1] === '*asc') {
                    unset($orderBySubPathSegments[$subPathCount - 1]);
                    $subPathCount--;
                }
            }

            $ancestors = array($this->_rootOrderByNode->getResourceSetWrapper()->getName());
            foreach ($orderBySubPathSegments as $index2 => $orderBySubPathSegment) {
                $isLastSegment = ($index2 == $subPathCount - 1);
                $resourceSetWrapper = null;
                $resourceType = $currentNode->getResourceType();
                $resourceProperty = $resourceType->resolveProperty($orderBySubPathSegment);
                if (is_null($resourceProperty)) {
                    throw ODataException::createSyntaxError(
                        Messages::orderByParserPropertyNotFound(
                            $resourceType->getFullName(), $orderBySubPathSegment
                        )
                    );
                }

                if ($resourceProperty->isKindOf(ResourcePropertyKind::BAG)) {
                    throw ODataException::createBadRequestError(
                        Messages::orderByParserBagPropertyNotAllowed(
                            $resourceProperty->getName()
                        )
                    );
                } else if ($resourceProperty->isKindOf(ResourcePropertyKind::PRIMITIVE)) {
                    if (!$isLastSegment) {
                        throw ODataException::createBadRequestError(
                            Messages::orderByParserPrimitiveAsIntermediateSegment(
                                $resourceProperty->getName()
                            )
                        );
                    }

                    $type = $resourceProperty->getInstanceType();
                    if ($type instanceof Binary) {
                        throw ODataException::createBadRequestError(Messages::orderByParserSortByBinaryPropertyNotAllowed($resourceProperty->getName()));
                    }
                } else if ($resourceProperty->getKind() == ResourcePropertyKind::RESOURCESET_REFERENCE
                    || $resourceProperty->getKind() == ResourcePropertyKind::RESOURCE_REFERENCE
                    || $resourceProperty->getKind() == ResourcePropertyKind::KEY_RESOURCE_REFERENCE
                ) {
                    $this->_assertion($currentNode instanceof OrderByRootNode || $currentNode instanceof OrderByNode);
                    $resourceSetWrapper = $currentNode->getResourceSetWrapper();
                    $this->_assertion(!is_null($resourceSetWrapper));
                    $resourceSetWrapper
                        = $this->_providerWrapper->getResourceSetWrapperForNavigationProperty(
                            $resourceSetWrapper, $resourceType, $resourceProperty
                        );
                    if (is_null($resourceSetWrapper)) {
                        throw ODataException::createBadRequestError(
                            Messages::badRequestInvalidPropertyNameSpecified(
                                $resourceType->getFullName(), $orderBySubPathSegment
                            )
                        );
                    }

                    if ($resourceProperty->getKind() == ResourcePropertyKind::RESOURCESET_REFERENCE) {
                        throw ODataException::createBadRequestError(
                            Messages::orderByParserResourceSetReferenceNotAllowed(
                                $resourceProperty->getName(), $resourceType->getFullName()
                            )
                        );
                    }

                    $resourceSetWrapper->checkResourceSetRightsForRead(true);
                    /*

                    if ($isLastSegment) {
						throw ODataException::createBadRequestError(
                            Messages::orderByParserSortByNavigationPropertyIsNotAllowed(
                                $resourceProperty->getName()
                            )
                        );
                    }
                    */

                    $ancestors[] = $orderBySubPathSegment;
                } else if ($resourceProperty->isKindOf(ResourcePropertyKind::COMPLEX_TYPE)) {
                    if ($isLastSegment) {
                        throw ODataException::createBadRequestError(
                            Messages::orderByParserSortByComplexPropertyIsNotAllowed(
                                $resourceProperty->getName()
                            )
                        );
                    }

                    $ancestors[] = $orderBySubPathSegment;
                } else {
                    throw ODataException::createInternalServerError(
                        Messages::orderByParserUnexpectedPropertyType()
                    );
                }

                $node = $currentNode->findNode($orderBySubPathSegment);
                if (is_null($node)) {
                    if ($resourceProperty->isKindOf(ResourcePropertyKind::PRIMITIVE) || $resourceProperty->isKindOf(ResourcePropertyKind::KEY_RESOURCE_REFERENCE)) {
                        $node = new OrderByLeafNode(
                            $orderBySubPathSegment, $resourceProperty,
                            $ascending
                        );
                    } else if ($resourceProperty->getKind() == ResourcePropertyKind::RESOURCE_REFERENCE || $resourceProperty->getKind() == ResourcePropertyKind::KEY_RESOURCE_REFERENCE) {
                        $node = new OrderByNode(
                            $orderBySubPathSegment, $resourceProperty,
                            $resourceSetWrapper
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
                        );
                        // Initialize this member variable (identified by
                        // $resourceProperty) of parent object.
                        try {
                            $dummyProperty
                                = new \ReflectionProperty(
                                    $currentObject, $resourceProperty->getName()
                                );
                            $object = $resourceProperty->getInstanceType()->newInstanceWithoutConstructor();
                            $dummyProperty->setAccessible(true);
                            $dummyProperty->setValue($currentObject, $object);
                            $currentObject = $object;
                        } catch (\ReflectionException $reflectionException) {
                            throw ODataException::createInternalServerError(
                                Messages::orderByParserFailedToAccessOrInitializeProperty(
                                    $resourceProperty->getName(), $resourceType->getName()
                                )
                            );
                        }
                    } else if ($resourceProperty->getKind() == ResourcePropertyKind::COMPLEX_TYPE) {
                        $node = new OrderByNode($orderBySubPathSegment, $resourceProperty, null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        // Initialize this member variable
                        // (identified by $resourceProperty)of parent object.
                        try {
                            $dummyProperty
                                = new \ReflectionProperty(
                                    $currentObject, $resourceProperty->getName()
                                );
                            $object = $resourceProperty->getInstanceType()->newInstanceWithoutConstructor();
                            $dummyProperty->setValue($currentObject, $object);
                            $currentObject = $object;
                        } catch (\ReflectionException $reflectionException) {
                            throw ODataException::createInternalServerError(
                                Messages::orderByParserFailedToAccessOrInitializeProperty(
                                    $resourceProperty->getName(), $resourceType->getName()
                                )
                            );
                        }
                    }

                    $currentNode->addNode($node);
                } else {
                    try {
                        $reflectionClass = new \ReflectionClass(get_class($currentObject));
                        $reflectionProperty = $reflectionClass->getProperty($resourceProperty->getName());
                        $reflectionProperty->setAccessible(true);
                        $currentObject = $reflectionProperty->getValue($currentObject);

                        //$dummyProperty = new \ReflectionProperty(

                        //    $currentObject, $resourceProperty->getName()

                        //);
                        //$currentObject = $dummyProperty->getValue($currentObject);

                    } catch (\ReflectionException $reflectionException) {
                            throw ODataException::createInternalServerError(
                                Messages::orderByParserFailedToAccessOrInitializeProperty(
                                    $resourceProperty->getName(),
                                    $resourceType->getName()
                                )
                            );
                    }

                    if ($node instanceof OrderByLeafNode) {
                        //remove duplicate orderby path
                        unset($orderByPathSegments[$index1]);
                    }
                }

                $currentNode = $node;
            }
        }
    }

    /**
     * Traverse 'Order By Tree' and create 'OrderInfo' structure
     *
     * @param array(array) $orderByPaths The orderby paths.

     *
     * @return OrderByInfo
     *
     * @throws ODataException In case parser found any tree inconsisitent
     *                        state, throws unexpected state error
     */
    private function _createOrderInfo($orderByPaths)
    {
        $orderByPathSegments = array();
        $navigationPropertiesInThePath = array();
        foreach ($orderByPaths as $index => $orderBySubPaths) {
            $currentNode = $this->_rootOrderByNode;
            $orderBySubPathSegments = array();
            foreach ($orderBySubPaths as $orderBySubPath) {
                $node = $currentNode->findNode($orderBySubPath);
                $this->_assertion(!is_null($node));
                $resourceProperty = $node->getResourceProperty();
                if ($node instanceof OrderByNode && !is_null($node->getResourceSetWrapper())) {
                    if (!array_key_exists($index, $navigationPropertiesInThePath)) {
                        $navigationPropertiesInThePath[$index] = array();
                    }

                    $navigationPropertiesInThePath[$index][] = $resourceProperty;
                }

                $orderBySubPathSegments[] = new OrderBySubPathSegment($resourceProperty);
                $currentNode = $node;
            }

            $this->_assertion($currentNode instanceof OrderByLeafNode);
            $orderByPathSegments[] = new OrderByPathSegment($orderBySubPathSegments, $currentNode->isAscending());
            unset($orderBySubPathSegments);
        }

        $this->_orderByInfo = new OrderByInfo($orderByPathSegments, empty($navigationPropertiesInThePath) ? null : $navigationPropertiesInThePath);
    }

    /**
     * Read orderby clause.
     *
     * @param string $value orderby clause to read.
     *
     * @return array(array) An array of 'OrderByPathSegment's, each of which

     *                      is array of 'OrderBySubPathSegment's
     *
     * @throws ODataException If any syntax error found while reading the clause
     */
    private function _readOrderBy($value)
    {
        $orderByPathSegments = array();
        $lexer = new ExpressionLexer($value);
        $i = 0;
        while ($lexer->getCurrentToken()->Id != ExpressionTokenId::END) {
            $orderBySubPathSegment = $lexer->readDottedIdentifier();
            if (!array_key_exists($i, $orderByPathSegments)) {
                $orderByPathSegments[$i] = array();
            }

            $orderByPathSegments[$i][] = $orderBySubPathSegment;
            $tokenId = $lexer->getCurrentToken()->Id;
            if ($tokenId != ExpressionTokenId::END) {
                if ($tokenId != ExpressionTokenId::SLASH) {
                    if ($tokenId != ExpressionTokenId::COMMA) {
                        $lexer->validateToken(ExpressionTokenId::IDENTIFIER);
                        $identifier = $lexer->getCurrentToken()->Text;
                        if ($identifier !== 'asc' && $identifier !== 'desc') {
                            // force lexer to throw syntax error as we found
                            // unexpected identifier
                            $lexer->validateToken(ExpressionTokenId::DOT);
                        }

                        $orderByPathSegments[$i][] = '*' . $identifier;
                        $lexer->nextToken();
                        $tokenId = $lexer->getCurrentToken()->Id;
                        if ($tokenId != ExpressionTokenId::END) {
                            $lexer->validateToken(ExpressionTokenId::COMMA);
                            $i++;
                        }
                    } else {
                        $i++;
                    }
                }

                $lexer->nextToken();
            }
        }

        return $orderByPathSegments;
    }

    /**
     * Assert that the given condition is true, if false throw
     * ODataException for unexpected state
     *
     * @param boolean $condition The condition to assert
     *
     * @return void
     *
     * @throws ODataException
     */
    private function _assertion($condition)
    {
        if (!$condition) {
            throw ODataException::createInternalServerError(Messages::orderByParserUnExpectedState());
        }
    }
}

balint777 / POData

Push — master ( 55beca...b509a7 )

OrderByParser::_buildOrderByTree() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
