POData\Common\ErrorHandler::handleException()

Complexity

Conditions	7
Paths	36

Size

Total Lines	46
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	56

Importance

Changes

0

<?php
    public static function handleException($exception, IService $service)
    {
        $acceptTypesText = $service->getHost()->getRequestAccept();
        $responseContentType = null;

The assignment to $responseContentType is dead and can be removed.

        try {
            $responseContentType = HttpProcessUtility::selectMimeType(
                $acceptTypesText, 
                array(
                    MimeTypes::MIME_APPLICATION_XML,
                    MimeTypes::MIME_APPLICATION_JSON
                )
            );
        } catch (HttpHeaderFailure $exception) {
            $exception = new ODataException(
                $exception->getMessage(), 
                $exception->getStatusCode()
            );
        } catch (\Exception $exception) {
            // Never come here
        }

        if (is_null($responseContentType)) {

The condition is_null($responseContentType) is always false.

            $responseContentType = MimeTypes::MIME_APPLICATION_XML;
        }

        if (!($exception instanceof ODataException)) {
            $exception = new ODataException($exception->getMessage(), HttpStatus::CODE_INTERNAL_SERVER_ERROR);
        }

        $service->getHost()->setResponseVersion(ODataConstants::DATASERVICEVERSION_1_DOT_0 . ';');

        // At this point all kind of exceptions will be converted 
        //to 'ODataException' 
        if ($exception->getStatusCode() == HttpStatus::CODE_NOT_MODIFIED) {
            $service->getHost()->setResponseStatusCode(HttpStatus::CODE_NOT_MODIFIED);
        } else {
            $service->getHost()->setResponseStatusCode($exception->getStatusCode());
            $service->getHost()->setResponseContentType($responseContentType);
            $responseBody = null;
            if (strcasecmp($responseContentType, MimeTypes::MIME_APPLICATION_XML) == 0) {
                $responseBody = AtomODataWriter::serializeException($exception, true);
            } else {
                $responseBody = JsonODataV2Writer::serializeException($exception, true);
            }

            $service->getHost()->getOperationContext()->outgoingResponse()->setStream($responseBody);
        }
}