Conditions | 9 |
Paths | 1 |
Total Lines | 86 |
Code Lines | 42 |
Lines | 0 |
Ratio | 0 % |
Tests | 0 |
CRAP Score | 90 |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
37 | public function mainAction() |
||
38 | { |
||
39 | //call queue |
||
40 | $queue = new BeanstalkExtended([ |
||
41 | 'host' => $this->config->beanstalk->host, |
||
|
|||
42 | 'prefix' => $this->config->beanstalk->prefix, |
||
43 | ]); |
||
44 | |||
45 | //have 2 different type of queues for now |
||
46 | $queueName = $this->config->pusher->queue; |
||
47 | |||
48 | //dependent variables |
||
49 | $config = $this->config; |
||
50 | |||
51 | //call que que tube |
||
52 | $queue->addWorker($queueName, function (Job $job) use ($config) { |
||
53 | try { |
||
54 | //get the array from the queue |
||
55 | $notificationInfo = $job->getBody(); |
||
56 | |||
57 | $link = !array_key_exists('link', $notificationInfo) ? $this->config->application->siteUrl . '/message/' . $notificationInfo['id'] : $notificationInfo['link']; |
||
58 | $linkHtml = " <a href='{$link}'>Link</a>"; |
||
59 | |||
60 | if ($this->pusher->trigger($notificationInfo['key'], $this->pushGeneralNotification, ['message' => $notificationInfo['message'] . $linkHtml])) { |
||
61 | $this->log->info("Pusher new {$notificationInfo['message']} to {$notificationInfo['key']}"); |
||
62 | } else { |
||
63 | $this->log->error("Pusher failed {$notificationInfo['message']} to {$notificationInfo['key']}"); |
||
64 | } |
||
65 | |||
66 | //if we are not sending it to all the Users |
||
67 | if ($notificationInfo['key'] != 'gewaer_general') { |
||
68 | //find the user Informatio base on its id and try to send the push notification |
||
69 | $userData = Users::findFirst(str_replace('user_notifications_', '', $notificationInfo['key'])); |
||
70 | $sourceId = '8'; //for now only android |
||
71 | |||
72 | if ($userDevice = UserLinkedSources::findFirst(['conditions' => 'user_id = ?0 and source_id =?1', 'bind' => [$userData->getId(), $sourceId]])) { |
||
73 | $this->log->addInfo('Pusher Sending push notification'); |
||
74 | |||
75 | //send push notification |
||
76 | $pushManager = new PushManager($config->app->production ? PushManager::ENVIRONMENT_PROD : PushManager::ENVIRONMENT_DEV); |
||
77 | $gcmAdapter = new GcmAdapter([ |
||
78 | 'apiKey' => $config->pushNotifcation->android, |
||
79 | ]); |
||
80 | |||
81 | // Set the device(s) to push the notification to. |
||
82 | $devices = new DeviceCollection([ |
||
83 | new Device($userDevice->source_users_id_text), |
||
84 | ]); |
||
85 | |||
86 | if (is_null($notificationInfo['id'])) { |
||
87 | $notificationInfo['id'] = 0; |
||
88 | } |
||
89 | |||
90 | // Then, create the push skel. |
||
91 | //$message = new Message($notificationInfo['message']); |
||
92 | $message = new Message( |
||
93 | $notificationInfo['message'], |
||
94 | [ |
||
95 | 'id' => time() + $userData->getId(), |
||
96 | 'type' => 'BigText', |
||
97 | 'title' => $notificationInfo['message'], |
||
98 | 'message_id' => $notificationInfo['id'] |
||
99 | ] |
||
100 | ); |
||
101 | |||
102 | // Finally, create and add the push to the manager, and push it! |
||
103 | $push = new Push($gcmAdapter, $devices, $message); |
||
104 | $pushManager->add($push); |
||
105 | |||
106 | if ($pushManager->push()) { // Returns a collection of notified devices |
||
107 | $this->log->addInfo('Pusher Notifaction to Device sent', array_merge($userDevice->toArray(), $notificationInfo)); |
||
108 | } else { |
||
109 | $this->log->addError('Pusher Fail to push notification to device', array_merge($userDevice->toArray(), $notificationInfo)); |
||
110 | } |
||
111 | } |
||
112 | } |
||
113 | } catch (Throwable $e) { |
||
114 | $this->log->error($e->getMessage()); |
||
115 | } |
||
116 | |||
117 | // It's very important to send the right exit code! |
||
118 | exit(0); |
||
1 ignored issue
–
show
|
|||
119 | }); |
||
120 | |||
121 | // Start processing queues |
||
122 | $queue->doWork(); |
||
123 | } |
||
125 |