bakaphp / phalcon-api

library/Models/AppsPlans.php

<?php
declare(strict_types=1);

namespace Gewaer\Models;

use Gewaer\Exception\ModelException;
use Phalcon\Di;

class AppsPlans extends AbstractModel
{
    /**
     *
     * @var integer
     */
    public $id;

    /**
     *
     * @var integer
     */
    public $apps_id;

    /**
     *
     * @var string
     */
    public $name;

    /**
     *
     * @var string
     */
    public $description;

    /**
     *
     * @var string
     */
    public $stripe_id;

    /**
     *
     * @var string
     */
    public $stripe_plan;

    /**
     *
     * @var double
     */
    public $pricing;

    /**
     *
     * @var integer
     */
    public $currency_id;

    /**
     *
     * @var integer
     */
    public $free_trial_dates;

    /**
     *
     * @var integer
     */
    public $is_default;

    /**
     *
     * @var string
     */
    public $created_at;

    /**
     *
     * @var string
     */
    public $updated_at;

    /**
     *
     * @var integer
     */
    public $is_deleted;

    /**
     * Initialize method for model.
     */
    public function initialize()
    {
        $this->setSource('apps_plans');

        $this->belongsTo(
            'apps_id',
            'Gewaer\Models\Apps',
            'id',
            ['alias' => 'app']
        );
    }

    /**
     * Returns table name mapped in the model.
     *
     * @return string
     */
    public function getSource() : string
    {
        return 'apps_plans';
    }

    /**
     * Just a preatty function that returns the same object for
     *
     * $app->settings()->set(key, value);
     * $app->settings()->get(key);
     * $app->settings()->get(key)->delete();
     *
     * @return AppsPlans
     */
    public function settings(): AppsPlans
    {
        return $this;
    }

    /**
     * Get the default plan for this given app
     *
     * @return AppsPlans
     */
    public static function getDefaultPlan(): AppsPlans
    {
        return AppsPlans::findFirst([

The expression return Gewaer\Models\AppsPlans::findFirst(array('conditions' => 'apps_id = ?0 and is_default = 1', 'bind' => array(Phalcon\Di::getDefault()->getApp()->getId()))) returns the type Phalcon\Mvc\Model which includes types incompatible with the type-hinted return Gewaer\Models\AppsPlans.

            'conditions' => 'apps_id = ?0 and is_default = 1',
            'bind' => [Di::getDefault()->getApp()->getId()]
        ]);
    }

    /**
     * Get the value of the settins by it key
     *
     * @param string $key
     * @param string $value
     */
    public function get(string $key) : string
    {
        $setting = AppsPlansSettings::findFirst([
            'conditions' => 'apps_plans_id = ?0 and apps_id = ?1 and key = ?2',
            'bind' => [$this->getId(), $this->apps_id, $key]
        ]);

        if ($setting) {

$setting is of type Phalcon\Mvc\Model, thus it always evaluated to true.

            return $setting->value;

The expression return $setting->value could return the type Phalcon\Mvc\Model\Resultset which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

        }

        throw new ModelException(_('No settings found with this ' . $key));
    }

    /**
     * Set a setting for the given app
     *
     * @param string $key
     * @param string $value
     */
    public function set(string $key, string $value) : bool
    {
        $setting = new AppsPlansSettings();

The assignment to $setting is dead and can be removed.

        $settings->apps_plans_id = $this->getId();

The variable $settings does not exist. Did you maybe mean $setting?

        $settings->apps_id = $this->getId();
        $settings->key = $key;
        $settings->value = $value;

        if (!$settings->save()) {
            throw new ModelException((string) current($settings->getMessages()));
        }

        return true;
    }
}