PushNotifications::assemble() - Code Metrics - Inspection of "Add Rabbitmq as a Provider and cli function for wo..." - bakaphp/phalcon-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#70)

by Rafael

created 2019-04-08 21:01 UTC

PushNotifications::assemble() A

↳ Parent: PushNotifications

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	3
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace Gewaer\Notifications\PushNotifications;

use Namshi\Notificator\Notification;
use Gewaer\Contracts\PushNotificationsContract;
use Gewaer\Models\Users;

class PushNotifications extends Notification implements PushNotificationsContract
{
    public $user;

    public $content;

    public $notificationTypeId;

    public $systemModule;

    public function __construct( Users $user,string $content, int $notificationTypeId = 0, string $systemModule)
// $a must always be passed; it's default value is never used.
function someFunction($a = 5, $b) { }
    {
        $this->user = $user;
        $this->content  = $content;
        $this->notificationTypeId = $notificationTypeId;
        $this->systemModule = $systemModule;
    }

    /**
     * Assemble Notification
     */
    public function assemble()
    {
        return $this->content;
    }
}


1			<?php
2
3			namespace Gewaer\Notifications\PushNotifications;
4
5			use Namshi\Notificator\Notification;
6			use Gewaer\Contracts\PushNotificationsContract;
7			use Gewaer\Models\Users;
8
9			class PushNotifications extends Notification implements PushNotificationsContract
10			{
11			public $user;
12
13			public $content;
14
15			public $notificationTypeId;
16
17			public $systemModule;
18
19			public function __construct( Users $user,string $content, int $notificationTypeId = 0, string $systemModule)
			0 ignored issues – show Coding Style introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report Expected 0 spaces after opening parenthesis; 1 found Loading history... Coding Style introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report Expected 1 space between comma and type hint "string"; 0 found Loading history... Coding Style introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report Parameters which have default values should be placed at the end. If you place a parameter with a default value before a parameter with a default value, the default value of the first parameter will never be used as it will always need to be passed anyway: // $a must always be passed; it's default value is never used. function someFunction($a = 5, $b) { } Loading history...
20			{
21			$this->user = $user;
22			$this->content = $content;
23			$this->notificationTypeId = $notificationTypeId;
24			$this->systemModule = $systemModule;
25			}
26
27			/**
28			* Assemble Notification
29			*/
30			public function assemble()
31			{
32			return $this->content;
33			}
34			}
35

bakaphp / phalcon-api

Pull Request — master (#70)

PushNotifications::assemble() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like