PushNotificationsHandler::handle() - Code Metrics - Inspection of "Add Rabbitmq as a Provider and cli function for wo..." - bakaphp/phalcon-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#70)

by Rafael

created 2019-04-08 21:01 UTC

PushNotificationsHandler::handle() A

↳ Parent: PushNotificationsHandler

Complexity

Conditions	2
Paths	1

Size

Total Lines	25
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	12
nc	1
nop	1
dl	0
loc	25
ccs	0
cts	14
cp	0
crap	6
rs	9.8666
c	0
b	0
f	0

<?php

namespace Gewaer\Handlers;

use Namshi\Notificator\Notification\Handler\HandlerInterface;
use Gewaer\Contracts\PushNotificationsContract;
use Phalcon\Http\Response;
use Namshi\Notificator\NotificationInterface;
use Phalcon\Di;
use Gewaer\Notifications\PushNotifications\AppsPushNotifications;
use Gewaer\Notifications\PushNotifications\PushNotifications;
use Gewaer\Models\Notifications;
use Gewaer\Traits\NotificationsTrait;
use Gewaer\Models\SystemModules;

class PushNotificationsHandler implements HandlerInterface
{
    /**
     * Notifications Trait
     */
    use NotificationsTrait;


    /**
     * Stablishes type of handler
     */
    public function shouldHandle(NotificationInterface $notification)
    {
        return $notification instanceof PushNotificationsContract;
    }
    
    /**
     * Handles actions to take depending of notifications
     * @param NotificationInterface $notification
     */
    public function handle(NotificationInterface $notification)
    {
        $this->create($notification->user,$notification->content,$notification->notificationTypeId,$notification->systemModule);

        die();
        $notificationType = $notification->notificationTypeId;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

        switch ($notificationType) {
            case '1':
                $newTypeRecord =  new AppsPushNotifications($notification->getMessage(), $notification->notificationTypeId);
                Di::getDefault()->getLog()->info($newTypeRecord->getMessage());
                break;
            // case '2':
            // $notificationType =  new AppsPushNotifications($notification->getMessage(), $notification->source_id);
            // Di::getDefault()->getLog()->info($notificationType->getMessage());
            // break;

            // case '3':
            // $notificationType =  new AppsPushNotifications($notification->getMessage(), $notification->source_id);
            // Di::getDefault()->getLog()->info($notificationType->getMessage());
            // break;
            
            default:
                $newTypeRecord =  new PushNotifications($notification->getMessage(), $notification->notificationTypeId);
                Di::getDefault()->getLog()->info($newTypeRecord->getMessage());
                break;
        }
    }
}


1			<?php
2
3			namespace Gewaer\Handlers;
4
5			use Namshi\Notificator\Notification\Handler\HandlerInterface;
6			use Gewaer\Contracts\PushNotificationsContract;
7			use Phalcon\Http\Response;
8			use Namshi\Notificator\NotificationInterface;
9			use Phalcon\Di;
10			use Gewaer\Notifications\PushNotifications\AppsPushNotifications;
11			use Gewaer\Notifications\PushNotifications\PushNotifications;
12			use Gewaer\Models\Notifications;
13			use Gewaer\Traits\NotificationsTrait;
14			use Gewaer\Models\SystemModules;
15
16			class PushNotificationsHandler implements HandlerInterface
17			{
18			/**
19			* Notifications Trait
20			*/
21			use NotificationsTrait;
			0 ignored issues – show Bug introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report The trait `Gewaer\Traits\NotificationsTrait` requires the property `$id` which is not provided by `Gewaer\Handlers\PushNotificationsHandler`. Loading history...
22
23			/**
24			* Stablishes type of handler
25			*/
26			public function shouldHandle(NotificationInterface $notification)
27			{
28			return $notification instanceof PushNotificationsContract;
29			}
30
31			/**
32			* Handles actions to take depending of notifications
33			* @param NotificationInterface $notification
34			*/
35			public function handle(NotificationInterface $notification)
36			{
37			$this->create($notification->user,$notification->content,$notification->notificationTypeId,$notification->systemModule);
			0 ignored issues – show Bug introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report Accessing `systemModule` on the interface `Namshi\Notificator\NotificationInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history... Bug introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report Accessing `user` on the interface `Namshi\Notificator\NotificationInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history... Bug introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report Accessing `content` on the interface `Namshi\Notificator\NotificationInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history... Bug introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report Accessing `notificationTypeId` on the interface `Namshi\Notificator\NotificationInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
38			die();
39			$notificationType = $notification->notificationTypeId;
			0 ignored issues – show Unused Code introduced 2019-04-08 21:06 UTC by Report Bug Copy Issue Report `$notificationType = $not...ion->notificationTypeId` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
40
41			switch ($notificationType) {
42			case '1':
43			$newTypeRecord = new AppsPushNotifications($notification->getMessage(), $notification->notificationTypeId);
44			Di::getDefault()->getLog()->info($newTypeRecord->getMessage());
45			break;
46			// case '2':
47			// $notificationType = new AppsPushNotifications($notification->getMessage(), $notification->source_id);
48			// Di::getDefault()->getLog()->info($notificationType->getMessage());
49			// break;
50
51			// case '3':
52			// $notificationType = new AppsPushNotifications($notification->getMessage(), $notification->source_id);
53			// Di::getDefault()->getLog()->info($notificationType->getMessage());
54			// break;
55
56			default:
57			$newTypeRecord = new PushNotifications($notification->getMessage(), $notification->notificationTypeId);
58			Di::getDefault()->getLog()->info($newTypeRecord->getMessage());
59			break;
60			}
61			}
62			}
63

bakaphp / phalcon-api

Pull Request — master (#70)

PushNotificationsHandler::handle() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like