Gewaer\Handlers\PushNotificationsHandler

Complexity

Total Complexity

3

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	25	2
A	shouldHandle()	0	3	1

<?php

namespace Gewaer\Handlers;

use Namshi\Notificator\Notification\Handler\HandlerInterface;
use Gewaer\Contracts\PushNotificationsContract;
use Phalcon\Http\Response;
use Namshi\Notificator\NotificationInterface;
use Phalcon\Di;
use Gewaer\Notifications\PushNotifications\AppsPushNotifications;
use Gewaer\Notifications\PushNotifications\PushNotifications;
use Gewaer\Models\Notifications;
use Gewaer\Traits\NotificationsTrait;
use Gewaer\Models\SystemModules;

class PushNotificationsHandler implements HandlerInterface
{
    /**
     * Notifications Trait
     */
    use NotificationsTrait;

The trait Gewaer\Traits\NotificationsTrait requires the property $id which is not provided by Gewaer\Handlers\PushNotificationsHandler.

    /**
     * Stablishes type of handler
     */
    public function shouldHandle(NotificationInterface $notification)
    {
        return $notification instanceof PushNotificationsContract;
    }
    
    /**
     * Handles actions to take depending of notifications
     * @param NotificationInterface $notification
     */
    public function handle(NotificationInterface $notification)
    {
        $this->create($notification->user,$notification->content,$notification->notificationTypeId,$notification->systemModule);

Accessing systemModule on the interface Namshi\Notificator\NotificationInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing user on the interface Namshi\Notificator\NotificationInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing content on the interface Namshi\Notificator\NotificationInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing notificationTypeId on the interface Namshi\Notificator\NotificationInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        die();
        $notificationType = $notification->notificationTypeId;

$notificationType = $notification->notificationTypeId is not reachable.

        switch ($notificationType) {
            case '1':
                $newTypeRecord =  new AppsPushNotifications($notification->getMessage(), $notification->notificationTypeId);
                Di::getDefault()->getLog()->info($newTypeRecord->getMessage());
                break;
            // case '2':
            // $notificationType =  new AppsPushNotifications($notification->getMessage(), $notification->source_id);
            // Di::getDefault()->getLog()->info($notificationType->getMessage());
            // break;

            // case '3':
            // $notificationType =  new AppsPushNotifications($notification->getMessage(), $notification->source_id);
            // Di::getDefault()->getLog()->info($notificationType->getMessage());
            // break;
            
            default:
                $newTypeRecord =  new PushNotifications($notification->getMessage(), $notification->notificationTypeId);
                Di::getDefault()->getLog()->info($newTypeRecord->getMessage());
                break;
        }
    }
}