RolesController::onConstruct() - Code Metrics - Inspection of "php 7.2 #6" - bakaphp/phalcon-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Pull Request — master (#9)

by Maximo

created 2018-12-01 03:03 UTC

RolesController::onConstruct() A

↳ Parent: RolesController

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	8
ccs	0
cts	6
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Gewaer\Api\Controllers;

use Gewaer\Models\Roles;

/**
 * Base controller
 *
 */
class RolesController extends BaseController
{
    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $createFields = [];

    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $updateFields = [];

    /**
     * set objects
     *
     * @return void
     */
    public function onConstruct()
    {
        $this->model = new Roles();


        //get the list of roes for the systema + my company
        $this->additionalSearchFields = [
            ['is_deleted', ':', 0],
            ['company_id', ':', '(0,' . $this->userData->default_company . ')'],

        ];
    }
}


1			<?php
			0 ignored issues – show Coding Style introduced 2018-11-30 00:56 UTC by Report Bug Copy Issue Report End of line character is invalid; expected "\n" but found "\r\n" Loading history...
2			declare(strict_types=1);
3
4			namespace Gewaer\Api\Controllers;
5
6			use Gewaer\Models\Roles;
7
8			/**
9			* Base controller
10			*
11			*/
12			class RolesController extends BaseController
13			{
14			/*
15			* fields we accept to create
16			*
17			* @var array
18			*/
19			protected $createFields = [];
20
21			/*
22			* fields we accept to create
23			*
24			* @var array
25			*/
26			protected $updateFields = [];
27
28			/**
29			* set objects
30			*
31			* @return void
32			*/
33			public function onConstruct()
34			{
35			$this->model = new Roles();
			0 ignored issues – show Documentation Bug introduced 2018-11-30 00:56 UTC by Report Bug Copy Issue Report It seems like `new Gewaer\Models\Roles()` of type `Gewaer\Models\Roles` is incompatible with the declared type `array` of property `$model`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
36
37			//get the list of roes for the systema + my company
38			$this->additionalSearchFields = [
39			['is_deleted', ':', 0],
40			['company_id', ':', '(0,' . $this->userData->default_company . ')'],
			0 ignored issues – show Bug Best Practice introduced 2018-11-30 00:56 UTC by Report Bug Copy Issue Report The property `userData` does not exist on `Gewaer\Api\Controllers\RolesController`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
41			];
42			}
43			}
44

bakaphp / phalcon-api

Pull Request — master (#9)

RolesController::onConstruct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like