Apps::getACLApp() - Code Metrics - Inspection of "add ACL testing suit" - bakaphp/phalcon-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3b9ce6...02c765 )

by Maximo

created 2018-11-29 01:45 UTC

Apps::getACLApp() A

↳ Parent: Apps

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.2559

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	9
ccs	3
cts	5
cp	0.6
crap	2.2559
rs	10
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Gewaer\Models;

class Apps extends \Baka\Auth\Models\Apps
{
    /**
     *
     * @var integer
     */
    public $id;

    /**
     *
     * @var string
     */
    public $name;

    /**
     *
     * @var string
     */
    public $description;

    /**
     *
     * @var string
     */
    public $created_at;

    /**
     *
     * @var string
     */
    public $updated_at;

    /**
     *
     * @var integer
     */
    public $is_deleted;

    /**
     * Ecosystem default app
     * @var string
     */
    const GEWAER_DEFAULT_APP_NAME = 'Default';

    /**
     * Initialize method for model.
     */
    public function initialize()
    {
        parent::initialize();

        $this->setSource('apps');
    }

    /**
     * You can only get 2 variations or default in DB or the api app
     *
     * @param string $name
     * @return Apps
     */
    public function getACLApp(string $name): Apps
    {
        if (trim($name) == self::GEWAER_DEFAULT_APP_NAME) {
            $app = self::findFirst(0);
        } else {
            $app = self::findFirst(\Phalcon\DI::getDefault()->getConfig()->app->id);
        }

        return $app;

    }

    /**
     * Returns table name mapped in the model.
     *
     * @return string
     */
    public function getSource() : string
    {
        return 'apps';
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Gewaer\Models;
5
6		class Apps extends \Baka\Auth\Models\Apps
7		{
8		/**
9		*
10		* @var integer
11		*/
12		public $id;
13
14		/**
15		*
16		* @var string
17		*/
18		public $name;
19
20		/**
21		*
22		* @var string
23		*/
24		public $description;
25
26		/**
27		*
28		* @var string
29		*/
30		public $created_at;
31
32		/**
33		*
34		* @var string
35		*/
36		public $updated_at;
37
38		/**
39		*
40		* @var integer
41		*/
42		public $is_deleted;
43
44		/**
45		* Ecosystem default app
46		* @var string
47		*/
48		const GEWAER_DEFAULT_APP_NAME = 'Default';
49
50		/**
51		* Initialize method for model.
52		*/
53	4	public function initialize()
54		{
55	4	parent::initialize();
56
57	4	$this->setSource('apps');
58	4	}
59
60		/**
61		* You can only get 2 variations or default in DB or the api app
62		*
63		* @param string $name
64		* @return Apps
65		*/
66	4	public function getACLApp(string $name): Apps
67		{
68	4	if (trim($name) == self::GEWAER_DEFAULT_APP_NAME) {
69		$app = self::findFirst(0);
70		} else {
71	4	$app = self::findFirst(\Phalcon\DI::getDefault()->getConfig()->app->id);
72		}
73
74		return $app;
		1 ignored issue – show Bug Best Practice introduced 2018-11-29 01:47 UTC by Report Bug Copy Issue Report The expression `return $app` returns the type `Phalcon\Mvc\Model` which includes types incompatible with the type-hinted return `Gewaer\Models\Apps`. Loading history...
75		}
76
77		/**
78		* Returns table name mapped in the model.
79		*
80		* @return string
81		*/
82	4	public function getSource() : string
83		{
84	4	return 'apps';
85		}
86		}
87

bakaphp / phalcon-api

Push — master ( 3b9ce6...02c765 )

Apps::getACLApp() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like