bakaphp / phalcon-api

api/controllers/UsersInviteController.php

<?php

declare(strict_types=1);

namespace Gewaer\Api\Controllers;

use Gewaer\Models\UsersInvite;
use Gewaer\Models\Users;
use Phalcon\Security\Random;
use Phalcon\Validation;
use Phalcon\Validation\Validator\PresenceOf;
use Phalcon\Validation\Validator\StringLength;
use Gewaer\Exception\UnprocessableEntityHttpException;
use Gewaer\Exception\NotFoundHttpException;
use Phalcon\Http\Response;

/**
 * Class LanguagesController
 *
 * @package Gewaer\Api\Controllers
 *
 */
class UsersInviteController extends BaseController
{
    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $createFields = ['invite_hash', 'company_id', 'role_id', 'app_id', 'email'];

    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $updateFields = ['invite_hash', 'company_id', 'role_id', 'app_id', 'email'];

    /**
     * set objects
     *
     * @return void
     */
    public function onConstruct()
    {
        $this->model = new UsersInvite();
    }

    /**
     * Sets up invitation information for a would be user
     * @return Response
     */
    public function insertInvite(): Response
    {
        $request = $this->request->getPost();
        $random = new Random();

        $validation = new Validation();
        $validation->add('email', new PresenceOf(['message' => _('The email is required.')]));
        $validation->add('role', new PresenceOf(['message' => _('The role is required.')]));

        //validate this form for password
        $messages = $validation->validate($this->request->getPost());
        if (count($messages)) {
            foreach ($messages as $message) {
                throw new ServerErrorHttpException((string)$message);

The type Gewaer\Api\Controllers\ServerErrorHttpException was not found. Maybe you did not declare it correctly or list all dependencies?

            }
        }

        //Save data to users_invite table and generate a hash for the invite
        $userInvite = $this->model;
        $userInvite->company_id = $this->userData->default_company;

The property userData does not exist on Gewaer\Api\Controllers\UsersInviteController. Since you implemented __get, consider adding a @property annotation.

        $userInvite->app_id = $this->app->getId();

The property app does not exist on Gewaer\Api\Controllers\UsersInviteController. Since you implemented __get, consider adding a @property annotation.

        $userInvite->role_id = $request['role'] == 'Admins' ? 1 : 2;
        $userInvite->email = $request['email'];
        $userInvite->invite_hash = $random->base58();
        $userInvite->created_at = date('Y-m-d H:m:s');

        if (!$userInvite->save()) {
            throw new UnprocessableEntityHttpException((string) current($userInvite->getMessages()));
        }

        $userInviteArray = $userInvite->toArray();

        return $this->response($userInviteArray);
    }

    /**
     * Add invited user to our system
     * @return Response
     */
    public function processUserInvite(string $hash): Response
    {
        $request = $this->request->getPost();

        if (empty($request)) {
            $request = $this->request->getJsonRawBody(true);
        }

        //Ok let validate user password
        $validation = new Validation();
        $validation->add('password', new PresenceOf(['message' => _('The password is required.')]));

        $validation->add(
            'password',
            new StringLength([
                'min' => 8,
                'messageMinimum' => _('Password is too short. Minimum 8 characters.'),
            ])
        );

        //validate this form for password
        $messages = $validation->validate($request);

It seems like $request can also be of type boolean; however, parameter $data of Phalcon\Validation::validate() does only seem to accept array|object, maybe add an additional type check?

        if (count($messages)) {
            foreach ($messages as $message) {
                throw new ServerErrorHttpException((string)$message);
            }
        }

        //Lets find users_invite by hash on our database
        $usersInvite = $this->model::findFirst([
                'conditions' => 'invite_hash = ?0 and is_deleted = 0',
                'bind' => [$hash]
            ]);

        if (!$usersInvite) {
            throw new NotFoundHttpException('Users Invite not found');
        }
        $newUser = new Users();
        $newUser->firstname = $request['firstname'];
        $newUser->lastname = $request['lastname'];
        $newUser->displayname = $request['displayname'];
        $newUser->password = $request['password'];
        $newUser->email = $usersInvite->email;
        $newUser->user_active = 1;
        $newUser->roles_id = $usersInvite->role_id;
        $newUser->created_at = date('Y-m-d H:m:s');
        // $newUser->name = $this->userData->defaultCompany; //Como puedo agregar este campo si es de una relacion ?
        $newUser->default_company = $this->userData->default_company;

The property userData does not exist on Gewaer\Api\Controllers\UsersInviteController. Since you implemented __get, consider adding a @property annotation.

        //Lets insert the new user to our system.

        if ($newUser->save()) {
            return $this->response($newUser->toArray());
        } else {
            //if not thorw exception
            throw new UnprocessableEntityHttpException((string) current($newUser->getMessages()));
        }
    }
}