Gewaer\Models\Roles

Complexity

Total Complexity

10

Size/Duplication

Total Lines	207
Duplicated Lines	0 %

Test Coverage

Coverage

61.9%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getSource()	0	3	1
A	initialize()	0	9	1
A	validation()	0	29	1
A	getByName()	0	5	1
A	getByAppName()	0	19	3
A	copy()	0	24	2
A	getById()	0	5	1

<?php
declare(strict_types=1);

namespace Gewaer\Models;

use Gewaer\Exception\ServerErrorHttpException;
use Baka\Auth\Models\Companies as BakaCompanies;
use Phalcon\Di;
use Phalcon\Validation;
use Phalcon\Validation\Validator\PresenceOf;
use Phalcon\Validation\Validator\StringLength;

class Roles extends AbstractModel
{
    /**
     *
     * @var integer
     */
    public $id;

    /**
     *
     * @var integer
     */
    public $name;

    /**
     *
     * @var integer
     */
    public $description;

    /**
     *
     * @var integer
     */
    public $scope;

    /**
     *
     * @var integer
     */
    public $company_id;

    /**
     *
     * @var int
     */
    public $apps_id;

    /**
     *
     * @var string
     */
    public $created_at;

    /**
     *
     * @var string
     */
    public $updated_at;

    /**
     *
     * @var integer
     */
    public $is_deleted;

    /**
     * Default ACL company
     *
     */
    const DEFAULT_ACL_COMPANY_ID = 0;
    const DEFAULT_ACL_APP_ID = 0;

    /**
     * Initialize method for model.
     */
    public function initialize()
    {
        $this->setSource('roles');

        $this->hasMany(
            'id',
            'Gewaer\Models\AccessList',
            'roles_id',
            ['alias' => 'accesList']
        );
    }

    /**
     * Validations and business logic
     */
    public function validation()
    {
        $validator = new Validation();

        $validator->add(
            'name',
            new PresenceOf([
                'field' => 'name',
                'required' => true,
            ])
        );

        $validator->add(
            'description',
            new PresenceOf([
                'field' => 'description',
                'required' => true,
            ])
        );

        $validator->add(
            'name',
            new StringLength([
                'max' => 32,
                'messageMinimum' => _('Role Name. Maxium 32 characters.'),
            ])
        );

        return $this->validate($validator);
    }

    /**
     * Returns table name mapped in the model.
     *
     * @return string
     */
    public function getSource(): string
    {
        return 'roles';
    }

    /**
     * Get the entity by its name
     *
     * @param string $name
     * @return void
     */
    public static function getByName(string $name)
    {
        return self::findFirst([

The expression return self::findFirst(array('conditions' => 'name = ?0 AND company_id = ?1 AND apps_id = ?2 AND is_deleted = 0', 'bind' => array($name, Phalcon\Di::getDefault()->getUserData()->default_company, Phalcon\Di::getDefault()->getApp()->getId()))) returns the type Phalcon\Mvc\Model which is incompatible with the documented return type void.

            'conditions' => 'name = ?0 AND company_id = ?1 AND apps_id = ?2 AND is_deleted = 0',
            'bind' => [$name, Di::getDefault()->getUserData()->default_company, Di::getDefault()->getApp()->getId()]
        ]);
    }

    /**
     * Get the entity by its name
     *
     * @param string $name
     * @return void
     */
    public static function getById(int $id)
    {
        return self::findFirst([

The expression return self::findFirst(array('conditions' => 'id = ?0 AND company_id in (?1, ?2) AND apps_id in (?3, ?4) AND is_deleted = 0', 'bind' => array($id, Phalcon\Di::getDefault()->getUserData()->default_company, Gewaer\Models\Apps::GEWAER_DEFAULT_APP_ID, Phalcon\Di::getDefault()->getApp()->getId(), Gewaer\Models\Apps::GEWAER_DEFAULT_APP_ID))) returns the type Phalcon\Mvc\Model which is incompatible with the documented return type void.

            'conditions' => 'id = ?0 AND company_id in (?1, ?2) AND apps_id in (?3, ?4) AND is_deleted = 0',
            'bind' => [$id, Di::getDefault()->getUserData()->default_company, Apps::GEWAER_DEFAULT_APP_ID, Di::getDefault()->getApp()->getId(), Apps::GEWAER_DEFAULT_APP_ID]
        ]);
    }

    /**
     * Get the Role by it app name
     *
     * @param string $role
     * @return Roles
     */
    public static function getByAppName(string $role, BakaCompanies $company): Roles
    {
        //echeck if we have a dot , taht means we are sending the specific app to use
        if (strpos($role, '.') === false) {
            throw new ServerErrorHttpException('ACL - We are expecting the app for this role');
        }

        $appRole = explode('.', $role);
        $role = $appRole[1];

The assignment to $role is dead and can be removed.

        $appName = $appRole[0];

        //look for the app and set it
        if (!$app = Apps::getACLApp($appName)) {
            throw new ServerErrorHttpException('ACL - No app found for this role');
        }

        return self::findFirst([
            'conditions' => 'apps_id in (?0, ?1) AND company_id in (?2 , ?3)',
            'bind' => [$app->getId(), self::DEFAULT_ACL_APP_ID, $company->getId(), self::DEFAULT_ACL_COMPANY_ID]
        ]);
    }

    /**
     * Duplicate a role with it access list
     *
     * @return bool
     */
    public function copy(): Roles
    {
        $accesList = $this->accesList;

The property accesList does not exist on Gewaer\Models\Roles. Since you implemented __get, consider adding a @property annotation.

        //remove id to create new record
        $this->name .= 'Copie';
        $this->scope = 1;
        $this->id = null;
        $this->company_id = $this->di->getUserData()->default_company;

The property di does not exist on Gewaer\Models\Roles. Since you implemented __get, consider adding a @property annotation.

The method getUserData() does not exist on Phalcon\Mvc\Model\Resultset.

        $this->apps_id = $this->di->getApp()->getId();

The method getApp() does not exist on Phalcon\Mvc\Model\Resultset.

        $this->save();

        foreach ($accesList as $access) {
            $copyAccessList = new AccessList();
            $copyAccessList->apps_id = $this->apps_id;
            $copyAccessList->roles_id = $this->getId();
            $copyAccessList->roles_name = $this->name;

The property $name was declared of type integer, but $this->name is of type string. Maybe add a type cast?

            $copyAccessList->resources_name = $access->resources_name;
            $copyAccessList->access_name = $access->access_name;
            $copyAccessList->allowed = $access->allowed;
            $copyAccessList->create();
        }

        return $this;

The expression return $this returns the type Gewaer\Models\Roles which is incompatible with the documented return type boolean.

    }
}