Roles::getByAppName() - Code Metrics - Inspection of "php 7.2 #6" - bakaphp/phalcon-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Pull Request — master (#9)

by Maximo

created 2018-12-01 04:05 UTC

Roles::getByAppName() A

↳ Parent: Roles

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3.054

Importance

Changes

Metric	Value
cc	3
eloc	10
nc	3
nop	2
dl	0
loc	19
ccs	9
cts	11
cp	0.8182
crap	3.054
rs	9.9332
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Gewaer\Models;

use Gewaer\Exception\ServerErrorHttpException;
use Baka\Auth\Models\Companies;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

class Roles extends AbstractModel
{
    /**
     *
     * @var integer
     */
    public $id;

    /**
     *
     * @var integer
     */
    public $name;

    /**
     *
     * @var integer
     */
    public $description;

    /**
     *
     * @var integer
     */
    public $scope;

    /**
     *
     * @var integer
     */
    public $company_id;

    /**
     *
     * @var int
     */
    public $apps_id;

    /**
     *
     * @var string
     */
    public $created_at;

    /**
     *
     * @var string
     */
    public $updated_at;

    /**
     *
     * @var integer
     */
    public $is_deleted;

    /**
     * Default ACL company
     *
     */
    const DEFAULT_ACL_COMPANY_ID = 0;
    const DEFAULT_ACL_APP_ID = 0;

    /**
     * Initialize method for model.
     */
    public function initialize()
    {
        $this->setSource('roles');
    }

    /**
     * Returns table name mapped in the model.
     *
     * @return string
     */
    public function getSource(): string
    {
        return 'roles';
    }

    /**
     * Get the Role by it app name
     *
     * @param string $role
     * @return Roles
     */
    public function getByAppName(string $role, Companies $company): Roles
    {
        //echeck if we have a dot , taht means we are sending the specific app to use
        if (strpos($role, '.') == false) {

            throw new ServerErrorHttpException('ACL - We are expecting the app for this role');
        }

        $appRole = explode('.', $role);
        $role = $appRole[1];

        $appName = $appRole[0];

        //look for the app and set it
        if (!$app = Apps::getACLApp($appName)) {
            throw new ServerErrorHttpException('ACL - No app found for this role');
        }

        return self::findFirst([

            'conditions' => 'apps_id in (?0, ?1) AND company_id in (?2 , ?3)',
            'bind' => [$app->getId(), self::DEFAULT_ACL_APP_ID, $company->getId(), self::DEFAULT_ACL_COMPANY_ID]
        ]);
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Gewaer\Models;
5
6		use Gewaer\Exception\ServerErrorHttpException;
7		use Baka\Auth\Models\Companies;
		0 ignored issues – show Bug introduced 2018-11-29 01:47 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Gewaer\Models\Companies`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8
9		class Roles extends AbstractModel
10		{
11		/**
12		*
13		* @var integer
14		*/
15		public $id;
16
17		/**
18		*
19		* @var integer
20		*/
21		public $name;
22
23		/**
24		*
25		* @var integer
26		*/
27		public $description;
28
29		/**
30		*
31		* @var integer
32		*/
33		public $scope;
34
35		/**
36		*
37		* @var integer
38		*/
39		public $company_id;
40
41		/**
42		*
43		* @var int
44		*/
45		public $apps_id;
46
47		/**
48		*
49		* @var string
50		*/
51		public $created_at;
52
53		/**
54		*
55		* @var string
56		*/
57		public $updated_at;
58
59		/**
60		*
61		* @var integer
62		*/
63		public $is_deleted;
64
65		/**
66		* Default ACL company
67		*
68		*/
69		const DEFAULT_ACL_COMPANY_ID = 0;
70		const DEFAULT_ACL_APP_ID = 0;
71
72		/**
73		* Initialize method for model.
74		*/
75	4	public function initialize()
76		{
77	4	$this->setSource('roles');
78	4	}
79
80		/**
81		* Returns table name mapped in the model.
82		*
83		* @return string
84		*/
85	4	public function getSource(): string
86		{
87	4	return 'roles';
88		}
89
90		/**
91		* Get the Role by it app name
92		*
93		* @param string $role
94		* @return Roles
95		*/
96	2	public function getByAppName(string $role, Companies $company): Roles
97		{
98		//echeck if we have a dot , taht means we are sending the specific app to use
99	2	if (strpos($role, '.') == false) {
		0 ignored issues – show Bug Best Practice introduced 2018-11-29 01:47 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `strpos($role, '.')` of type `integer` to the boolean `false`. If you are specifically checking for 0, consider using something more explicit like `=== 0` instead. Loading history...
100		throw new ServerErrorHttpException('ACL - We are expecting the app for this role');
101		}
102
103	2	$appRole = explode('.', $role);
104	2	$role = $appRole[1];
		1 ignored issue – show Unused Code introduced 2018-11-29 01:47 UTC by Report Bug Copy Issue Report The assignment to `$role` is dead and can be removed. Loading history...
105	2	$appName = $appRole[0];
106
107		//look for the app and set it
108	2	if (!$app = Apps::getACLApp($appName)) {
109		throw new ServerErrorHttpException('ACL - No app found for this role');
110		}
111
112	2	return self::findFirst([
		1 ignored issue – show Bug Best Practice introduced 2018-11-29 01:47 UTC by Report Bug Copy Issue Report The expression `return self::findFirst(a...FAULT_ACL_COMPANY_ID)))` returns the type `Phalcon\Mvc\Model` which includes types incompatible with the type-hinted return `Gewaer\Models\Roles`. Loading history...
113	2	'conditions' => 'apps_id in (?0, ?1) AND company_id in (?2 , ?3)',
114	2	'bind' => [$app->getId(), self::DEFAULT_ACL_APP_ID, $company->getId(), self::DEFAULT_ACL_COMPANY_ID]
115		]);
116		}
117		}
118

bakaphp / phalcon-api

Pull Request — master (#9)

Roles::getByAppName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like