bakaphp /
phalcon-api
| Conditions | 9 |
| Paths | 1 |
| Total Lines | 87 |
| Code Lines | 43 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 90 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | public function mainAction() |
||
| 33 | {
|
||
| 34 | //call queue |
||
| 35 | $queue = new BeanstalkExtended([ |
||
| 36 | 'host' => $this->config->beanstalk->host, |
||
| 37 | 'prefix' => $this->config->beanstalk->prefix, |
||
| 38 | ]); |
||
| 39 | |||
| 40 | //have 2 different type of queues for now |
||
| 41 | $queueName = $this->config->pusher->queue; |
||
| 42 | |||
| 43 | //dependent variables |
||
| 44 | $config = $this->config; |
||
| 45 | $di = FactoryDefault::getDefault(); |
||
| 46 | |||
| 47 | //call que que tube |
||
| 48 | $queue->addWorker($queueName, function (Job $job) use ($di, $config) {
|
||
| 49 | try {
|
||
| 50 | //get the array from the queue |
||
| 51 | $notificationInfo = $job->getBody(); |
||
| 52 | |||
| 53 | $link = !array_key_exists('link', $notificationInfo) ? $this->config->application->siteUrl . '/message/' . $notificationInfo['id'] : $notificationInfo['link'];
|
||
| 54 | $linkHtml = " <a href='{$link}'>Link</a>";
|
||
| 55 | |||
| 56 | if ($this->pusher->trigger($notificationInfo['key'], $this->pushGeneralNotification, ['message' => $notificationInfo['message'] . $linkHtml])) {
|
||
| 57 | $this->log->info("Pusher new {$notificationInfo['message']} to {$notificationInfo['key']}");
|
||
| 58 | } else {
|
||
| 59 | $this->log->error("Pusher failed {$notificationInfo['message']} to {$notificationInfo['key']}");
|
||
| 60 | } |
||
| 61 | |||
| 62 | //if we are not sending it to all the Users |
||
| 63 | if ($notificationInfo['key'] != 'gewaer_general') {
|
||
| 64 | //find the user Informatio base on its id and try to send the push notification |
||
| 65 | $userData = Users::findFirst(str_replace('user_notifications_', '', $notificationInfo['key']));
|
||
| 66 | $sourceId = '8'; //for now only android |
||
| 67 | |||
| 68 | if ($userDevice = UserLinkedSources::findFirst(['conditions' => 'user_id = ?0 and source_id =?1', 'bind' => [$userData->getId(), $sourceId]])) {
|
||
| 69 | $this->log->addInfo('Pusher Sending push notification');
|
||
| 70 | |||
| 71 | //send push notification |
||
| 72 | $pushManager = new PushManager($config->application->production ? PushManager::ENVIRONMENT_PROD : PushManager::ENVIRONMENT_DEV); |
||
| 73 | $gcmAdapter = new GcmAdapter([ |
||
| 74 | 'apiKey' => $config->pushNotifcation->android, |
||
| 75 | ]); |
||
| 76 | |||
| 77 | // Set the device(s) to push the notification to. |
||
| 78 | $devices = new DeviceCollection([ |
||
| 79 | new Device($userDevice->source_user_id_text), |
||
| 80 | ]); |
||
| 81 | |||
| 82 | if (is_null($notificationInfo['id'])) {
|
||
| 83 | $notificationInfo['id'] = 0; |
||
| 84 | } |
||
| 85 | |||
| 86 | // Then, create the push skel. |
||
| 87 | //$message = new Message($notificationInfo['message']); |
||
| 88 | $message = new Message( |
||
| 89 | $notificationInfo['message'], |
||
| 90 | [ |
||
| 91 | 'id' => time() + $userData->getId(), |
||
| 92 | 'type' => 'BigText', |
||
| 93 | 'title' => $notificationInfo['message'], |
||
| 94 | 'message_id' => $notificationInfo['id'] |
||
| 95 | ] |
||
| 96 | ); |
||
| 97 | |||
| 98 | // Finally, create and add the push to the manager, and push it! |
||
| 99 | $push = new Push($gcmAdapter, $devices, $message); |
||
| 100 | $pushManager->add($push); |
||
| 101 | |||
| 102 | if ($pushManager->push()) { // Returns a collection of notified devices
|
||
| 103 | $this->log->addInfo('Pusher Notifaction to Device sent', array_merge($userDevice->toArray(), $notificationInfo));
|
||
| 104 | } else {
|
||
| 105 | $this->log->addError('Pusher Fail to push notification to device', array_merge($userDevice->toArray(), $notificationInfo));
|
||
| 106 | } |
||
| 107 | } |
||
| 108 | } |
||
| 109 | } catch (Throwable $e) {
|
||
| 110 | $this->log->error($e->getMessage()); |
||
| 111 | } |
||
| 112 | |||
| 113 | // It's very important to send the right exit code! |
||
| 114 | exit(0); |
||
|
1 ignored issue
–
show
|
|||
| 115 | }); |
||
| 116 | |||
| 117 | // Start processing queues |
||
| 118 | $queue->doWork(); |
||
| 119 | } |
||
| 121 |
Loading history...