AppsSettings::getDefaultAppsSettingsByName() - Code Metrics - Inspection of "Hotfixs general system bugs" - bakaphp/phalcon-api - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#55)

by Rafael

created 2019-03-04 17:15 UTC

AppsSettings::getDefaultAppsSettingsByName() A

↳ Parent: AppsSettings

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	1
dl	0
loc	6
ccs	5
cts	5
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Gewaer\Models;
use Gewaer\Models\Apps;

class AppsSettings extends AbstractModel
{
    /**
     *
     * @var integer
     */
    public $apps_id;

    /**
     *
     * @var string
     */
    public $name;

    /**
     *
     * @var string
     */
    public $value;

    /**
     *
     * @var string
     */
    public $created_at;

    /**
     *
     * @var string
     */
    public $updated_at;

    /**
     *
     * @var integer
     */
    public $is_deleted;

    /**
     * Initialize method for model.
     */
    public function initialize()
    {

        $this->setSource('apps_settings');

        $this->belongsTo(
            'apps_id',
            'Gewaer\Models\Apps',
            'id',
            ['alias' => 'app']
        );
    }

    /**
     * Returns table name mapped in the model.
     *
     * @return string
     */
    public function getSource() : string
    {
        return 'apps_settings';
    }

    /**
     * Get default Apps Settings value by name
     * @param $name
     * @return string
     */
    public static function getDefaultAppsSettingsByName(string $name): string
    {
        return self::findFirst([

            'conditions'=>'apps_id = ?0 and name = ?1 and is_deleted = 0',
            'bind'=>[Apps::GEWAER_DEFAULT_APP_ID,$name]
        ])->value;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace Gewaer\Models;
5		use Gewaer\Models\Apps;
6
7		class AppsSettings extends AbstractModel
8		{
9		/**
10		*
11		* @var integer
12		*/
13		public $apps_id;
14
15		/**
16		*
17		* @var string
18		*/
19		public $name;
20
21		/**
22		*
23		* @var string
24		*/
25		public $value;
26
27		/**
28		*
29		* @var string
30		*/
31		public $created_at;
32
33		/**
34		*
35		* @var string
36		*/
37		public $updated_at;
38
39		/**
40		*
41		* @var integer
42		*/
43		public $is_deleted;
44
45		/**
46		* Initialize method for model.
47		*/
48	3	public function initialize()
49		{
50
51	3	$this->setSource('apps_settings');
52
53	3	$this->belongsTo(
54	3	'apps_id',
55	3	'Gewaer\Models\Apps',
56	3	'id',
57	3	['alias' => 'app']
58		);
59	3	}
60
61		/**
62		* Returns table name mapped in the model.
63		*
64		* @return string
65		*/
66	3	public function getSource() : string
67		{
68	3	return 'apps_settings';
69		}
70
71		/**
72		* Get default Apps Settings value by name
73		* @param $name
74		* @return string
75		*/
76	3	public static function getDefaultAppsSettingsByName(string $name): string
77		{
78	3	return self::findFirst([
		1 ignored issue – show Bug Best Practice introduced 2019-03-04 17:22 UTC by Report Bug Copy Issue Report The expression `return self::findFirst(a...APP_ID, $name)))->value` could return the type `Phalcon\Mvc\Model\Resultset` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
79	3	'conditions'=>'apps_id = ?0 and name = ?1 and is_deleted = 0',
80	3	'bind'=>[Apps::GEWAER_DEFAULT_APP_ID,$name]
81	3	])->value;
82		}
83		}
84

bakaphp / phalcon-api

Pull Request — master (#55)

AppsSettings::getDefaultAppsSettingsByName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like