AppsPlansController::delete() - Code Metrics - Inspection of "Add missing Reference" - bakaphp/canvas-core - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#342)

by Maximo

created 2020-04-02 15:48 UTC

AppsPlansController::delete() A

↳ Parent: AppsPlansController

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	9
nc	3
nop	1
dl	0
loc	19
ccs	0
cts	15
cp	0
crap	12
rs	9.9666
c	1
b	0
f	0

<?php

declare(strict_types=1);

namespace Canvas\Api\Controllers;

use Canvas\Models\AppsPlans;
use Stripe\Token as StripeToken;
filter:
    dependency_paths: ["lib/*"]
use Phalcon\Http\Response;
filter:
    dependency_paths: ["lib/*"]
use Stripe\Customer as StripeCustomer;
filter:
    dependency_paths: ["lib/*"]
use Phalcon\Validation\Validator\PresenceOf;
filter:
    dependency_paths: ["lib/*"]
use Canvas\Http\Exception\NotFoundException;
use Canvas\Http\Exception\UnauthorizedException;
use Canvas\Http\Exception\UnprocessableEntityException;
use Canvas\Models\Subscription as CanvasSubscription;
use Phalcon\Cashier\Subscription;
filter:
    dependency_paths: ["lib/*"]
use Canvas\Models\UserCompanyApps;
use function Canvas\Core\paymentGatewayIsActive;
use Canvas\Validation as CanvasValidation;
use Canvas\Models\PaymentMethodsCreds;

/**
 * Class LanguagesController.
 *
 * @package Canvas\Api\Controllers
 *
 * @property Users $userData
 * @property Request $request
 * @property Config $config
 * @property Apps $app
 * @property \Phalcon\Db\Adapter\Pdo\Mysql $db
 */
class AppsPlansController extends BaseController
{
    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $createFields = [];

    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $updateFields = [];

    /**
     * set objects.
     *
     * @return void
     */
    public function onConstruct()
    {
        if (!$this->userData->hasRole('Default.Admins') || (int) $id === 0) {

            $id = $this->userData->getId();

        }

        $this->userData->can('Apps-plans.update', true);

        $this->model = new AppsPlans();

        $this->additionalSearchFields = [

            ['is_deleted', ':', '0'],
            ['apps_id', ':', $this->app->getId()],
        ];
    }

    /**
     * Update a given subscription.
     *
     * @param string $stripeId
     * @return Response
     */
    public function edit($stripeId) : Response
    {
        $appPlan = $this->model->findFirstByStripeId($stripeId);

        if (!is_object($appPlan)) {
            throw new NotFoundException(_('This plan doesnt exist'));
        }

        $userSubscription = CanvasSubscription::getActiveForThisApp();

        $this->db->begin();

        $subscription = $this->userData->subscription($userSubscription->name);

        if ($subscription->onTrial()) {
            $subscription->name = $appPlan->name;
            $subscription->stripe_plan = $appPlan->stripe_plan;
        } else {
            $subscription->swap($stripeId);
        }

        //update company app
        $companyApp = UserCompanyApps::getCurrentApp();

        //update the company app to the new plan
        if (is_object($companyApp)) {
            $subscription->name = $stripeId;
            $subscription->save();

            $companyApp->stripe_id = $stripeId;
            $companyApp->subscriptions_id = $subscription->getId();
            if (!$companyApp->update()) {
                $this->db->rollback();
                throw new UnprocessableEntityException((string) current($companyApp->getMessages()));
            }

            //update the subscription with the plan
            $subscription->apps_plans_id = $appPlan->getId();
            if (!$subscription->update()) {
                $this->db->rollback();

                throw new UnprocessableEntityException((string) current($subscription->getMessages()));
            }
        }

        $this->db->commit();

        //return the new subscription plan
        return $this->response($appPlan);
    }

    /**
     * Cancel a given subscription.
     *
     * @param string $stripeId
     * @return Response
     */
    public function delete($stripeId): Response
    {
        $appPlan = $this->model->findFirstByStripeId($stripeId);

        if (!is_object($appPlan)) {
            throw new NotFoundException(_('This plan doesnt exist'));
        }

        $subscription = CanvasSubscription::getActiveSubscription();

        //if on trial you can cancel without going to stripe
        if (!$subscription->onTrial()) {
            $subscription->cancel();
        }

        $subscription->is_cancelled = 1;
        $subscription->update();

        return $this->response($appPlan);
    }

    /**
     * Reactivate a given subscription.
     *
     * @param string $stripeId
     * @return Response
     */
    public function reactivateSubscription($stripeId): Response
    {
        $appPlan = $this->model->findFirstByStripeId($stripeId);

        if (!is_object($appPlan)) {
            throw new NotFoundException(_('This plan doesnt exist'));
        }

        $subscription = CanvasSubscription::getActiveSubscription();

        //if on trial you can cancel without going to stripe
        if (!$subscription->onTrial()) {
            $subscription->reactivate();
        }

        $subscription->is_cancelled = 0;
        $subscription->update();

        return $this->response($appPlan);
    }

    /**
     * Update payment method.
     * @param integer $id
     * @return Response
     */
    public function updatePaymentMethod(string $id): Response
    {
        if (empty($this->request->hasPut('card_token'))) {
            $validation = new CanvasValidation();
            $validation->add('card_number', new PresenceOf(['message' => _('Credit Card Number is required.')]));
            $validation->add('card_exp_month', new PresenceOf(['message' => _('Credit Card expiration month is required.')]));
            $validation->add('card_exp_year', new PresenceOf(['message' => _('Credit Card expiration year is required.')]));
            $validation->add('card_cvc', new PresenceOf(['message' => _('CVC is required.')]));

            //validate this form for password
            $validation->validate($this->request->getPut());

            $cardNumber = $this->request->getPut('card_number', 'string');
            $expMonth = $this->request->getPut('card_exp_month', 'string');
            $expYear = $this->request->getPut('card_exp_year', 'string');
            $cvc = $this->request->getPut('card_cvc', 'string');

            //Create a new card token
            $token = StripeToken::create([
                'card' => [
                    'number' => $cardNumber,
                    'exp_month' => $expMonth,
                    'exp_year' => $expYear,
                    'cvc' => $cvc,
                ],
            ], [
                'api_key' => $this->config->stripe->secret
            ])->id;
        } else {
            $token = $this->request->getPut('card_token');
        }

        $address = $this->request->getPut('address', 'string');
        $zipcode = $this->request->getPut('zipcode', 'string');

        //update the default company info
        $this->userData->getDefaultCompany()->address = $address;
        $this->userData->getDefaultCompany()->zipcode = $zipcode;
        $this->userData->getDefaultCompany()->update();

        $customerId = $this->userData->getDefaultCompany()->get('payment_gateway_customer_id');

        //Update default payment method with new card.
        $stripeCustomer = $this->userData->updatePaymentMethod($customerId, $token);

        $subscription = CanvasSubscription::getActiveForThisApp();

        //not valid? ok then lets charge the credit card to active your subscription
        if (!$subscription->valid()) {
            $subscription->activate();
        }

        if (is_object($stripeCustomer) && $stripeCustomer instanceof StripeCustomer) {

            //We now create a partially persist the payment method data
            PaymentMethodsCreds::createByStripeToken($token);
            return $this->response($subscription);
        }
        return $this->response('Card could not be updated');
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Canvas\Api\Controllers;
6
7			use Canvas\Models\AppsPlans;
8			use Stripe\Token as StripeToken;
			0 ignored issues – show Bug introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The type `Stripe\Token` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9			use Phalcon\Http\Response;
			0 ignored issues – show Bug introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The type `Phalcon\Http\Response` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
10			use Stripe\Customer as StripeCustomer;
			0 ignored issues – show Bug introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The type `Stripe\Customer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11			use Phalcon\Validation\Validator\PresenceOf;
			0 ignored issues – show Bug introduced 2019-06-06 18:47 UTC by Report Bug Copy Issue Report The type `Phalcon\Validation\Validator\PresenceOf` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12			use Canvas\Http\Exception\NotFoundException;
13			use Canvas\Http\Exception\UnauthorizedException;
14			use Canvas\Http\Exception\UnprocessableEntityException;
15			use Canvas\Models\Subscription as CanvasSubscription;
16			use Phalcon\Cashier\Subscription;
			0 ignored issues – show Bug introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The type `Phalcon\Cashier\Subscription` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
17			use Canvas\Models\UserCompanyApps;
18			use function Canvas\Core\paymentGatewayIsActive;
19			use Canvas\Validation as CanvasValidation;
20			use Canvas\Models\PaymentMethodsCreds;
21
22			/**
23			* Class LanguagesController.
24			*
25			* @package Canvas\Api\Controllers
26			*
27			* @property Users $userData
28			* @property Request $request
29			* @property Config $config
30			* @property Apps $app
31			* @property \Phalcon\Db\Adapter\Pdo\Mysql $db
32			*/
33			class AppsPlansController extends BaseController
34			{
35			/*
36			* fields we accept to create
37			*
38			* @var array
39			*/
40			protected $createFields = [];
41
42			/*
43			* fields we accept to create
44			*
45			* @var array
46			*/
47			protected $updateFields = [];
48
49			/**
50			* set objects.
51			*
52			* @return void
53			*/
54			public function onConstruct()
55			{
56			if (!$this->userData->hasRole('Default.Admins') \|\| (int) $id === 0) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The variable `$id` seems to be never defined. Loading history...
57			$id = $this->userData->getId();
			0 ignored issues – show Unused Code introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The assignment to `$id` is dead and can be removed. Loading history...
58			}
59
60			$this->userData->can('Apps-plans.update', true);
61
62			$this->model = new AppsPlans();
			0 ignored issues – show Bug Best Practice introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The property `model` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
63			$this->additionalSearchFields = [
			0 ignored issues – show Bug Best Practice introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The property `additionalSearchFields` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
64			['is_deleted', ':', '0'],
65			['apps_id', ':', $this->app->getId()],
66			];
67			}
68
69			/**
70			* Update a given subscription.
71			*
72			* @param string $stripeId
73			* @return Response
74			*/
75			public function edit($stripeId) : Response
76			{
77			$appPlan = $this->model->findFirstByStripeId($stripeId);
78
79			if (!is_object($appPlan)) {
80			throw new NotFoundException(_('This plan doesnt exist'));
81			}
82
83			$userSubscription = CanvasSubscription::getActiveForThisApp();
84
85			$this->db->begin();
86
87			$subscription = $this->userData->subscription($userSubscription->name);
88
89			if ($subscription->onTrial()) {
90			$subscription->name = $appPlan->name;
91			$subscription->stripe_plan = $appPlan->stripe_plan;
92			} else {
93			$subscription->swap($stripeId);
94			}
95
96			//update company app
97			$companyApp = UserCompanyApps::getCurrentApp();
98
99			//update the company app to the new plan
100			if (is_object($companyApp)) {
101			$subscription->name = $stripeId;
102			$subscription->save();
103
104			$companyApp->stripe_id = $stripeId;
105			$companyApp->subscriptions_id = $subscription->getId();
106			if (!$companyApp->update()) {
107			$this->db->rollback();
108			throw new UnprocessableEntityException((string) current($companyApp->getMessages()));
109			}
110
111			//update the subscription with the plan
112			$subscription->apps_plans_id = $appPlan->getId();
113			if (!$subscription->update()) {
114			$this->db->rollback();
115
116			throw new UnprocessableEntityException((string) current($subscription->getMessages()));
117			}
118			}
119
120			$this->db->commit();
121
122			//return the new subscription plan
123			return $this->response($appPlan);
124			}
125
126			/**
127			* Cancel a given subscription.
128			*
129			* @param string $stripeId
130			* @return Response
131			*/
132			public function delete($stripeId): Response
133			{
134			$appPlan = $this->model->findFirstByStripeId($stripeId);
135
136			if (!is_object($appPlan)) {
137			throw new NotFoundException(_('This plan doesnt exist'));
138			}
139
140			$subscription = CanvasSubscription::getActiveSubscription();
141
142			//if on trial you can cancel without going to stripe
143			if (!$subscription->onTrial()) {
144			$subscription->cancel();
145			}
146
147			$subscription->is_cancelled = 1;
148			$subscription->update();
149
150			return $this->response($appPlan);
151			}
152
153			/**
154			* Reactivate a given subscription.
155			*
156			* @param string $stripeId
157			* @return Response
158			*/
159			public function reactivateSubscription($stripeId): Response
160			{
161			$appPlan = $this->model->findFirstByStripeId($stripeId);
162
163			if (!is_object($appPlan)) {
164			throw new NotFoundException(_('This plan doesnt exist'));
165			}
166
167			$subscription = CanvasSubscription::getActiveSubscription();
168
169			//if on trial you can cancel without going to stripe
170			if (!$subscription->onTrial()) {
171			$subscription->reactivate();
172			}
173
174			$subscription->is_cancelled = 0;
175			$subscription->update();
176
177			return $this->response($appPlan);
178			}
179
180			/**
181			* Update payment method.
182			* @param integer $id
183			* @return Response
184			*/
185			public function updatePaymentMethod(string $id): Response
186			{
187			if (empty($this->request->hasPut('card_token'))) {
188			$validation = new CanvasValidation();
189			$validation->add('card_number', new PresenceOf(['message' => _('Credit Card Number is required.')]));
190			$validation->add('card_exp_month', new PresenceOf(['message' => _('Credit Card expiration month is required.')]));
191			$validation->add('card_exp_year', new PresenceOf(['message' => _('Credit Card expiration year is required.')]));
192			$validation->add('card_cvc', new PresenceOf(['message' => _('CVC is required.')]));
193
194			//validate this form for password
195			$validation->validate($this->request->getPut());
196
197			$cardNumber = $this->request->getPut('card_number', 'string');
198			$expMonth = $this->request->getPut('card_exp_month', 'string');
199			$expYear = $this->request->getPut('card_exp_year', 'string');
200			$cvc = $this->request->getPut('card_cvc', 'string');
201
202			//Create a new card token
203			$token = StripeToken::create([
204			'card' => [
205			'number' => $cardNumber,
206			'exp_month' => $expMonth,
207			'exp_year' => $expYear,
208			'cvc' => $cvc,
209			],
210			], [
211			'api_key' => $this->config->stripe->secret
212			])->id;
213			} else {
214			$token = $this->request->getPut('card_token');
215			}
216
217			$address = $this->request->getPut('address', 'string');
218			$zipcode = $this->request->getPut('zipcode', 'string');
219
220			//update the default company info
221			$this->userData->getDefaultCompany()->address = $address;
222			$this->userData->getDefaultCompany()->zipcode = $zipcode;
223			$this->userData->getDefaultCompany()->update();
224
225			$customerId = $this->userData->getDefaultCompany()->get('payment_gateway_customer_id');
226
227			//Update default payment method with new card.
228			$stripeCustomer = $this->userData->updatePaymentMethod($customerId, $token);
229
230			$subscription = CanvasSubscription::getActiveForThisApp();
231
232			//not valid? ok then lets charge the credit card to active your subscription
233			if (!$subscription->valid()) {
234			$subscription->activate();
235			}
236
237			if (is_object($stripeCustomer) && $stripeCustomer instanceof StripeCustomer) {
238
239			//We now create a partially persist the payment method data
240			PaymentMethodsCreds::createByStripeToken($token);
241			return $this->response($subscription);
242			}
243			return $this->response('Card could not be updated');
244			}
245			}
246

bakaphp / canvas-core

Pull Request — master (#342)

AppsPlansController::delete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like