Canvas\Notifications\Notify

Complexity

Total Complexity

3

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	all()	0	4	2
A	one()	0	8	1

<?php

declare(strict_types=1);

namespace Canvas\Notifications;

use Canvas\Contracts\Notifications\NotificationInterfase;
use Canvas\Models\Users;
use Phalcon\Di;

class Notify
{
    /**
     * Send the nofitication to all the users.
     *
     * @param array $users
     * @param NotificationInterfase $notification
     * @return void
     */
    public static function all(array $users, NotificationInterfase $notification)
    {
        foreach ($users as $user) {
            $this->one($user, $notification);

Using $this inside a static method is generally not recommended and can lead to errors in newer PHP versions.

        }
    }

    /**
     * Process just one.
     *
     * @param Users $user
     * @param NotificationInterfase $notification
     * @return void
     */
    public static function one(Users $user, NotificationInterfase $notification): bool
    {
        $from = Di::getDefault()->getUserData();

        $notification->setTo($user);
        $notification->setFrom($from);

        return $notification->process();

The expression return $notification->process() returns the type boolean which is incompatible with the documented return type void.

    }
}