AppsSettingsController::onConstruct() - Code Metrics - bakaphp/canvas-core - Measure and Improve Code Quality continuously with Scrutinizer

AppsSettingsController::onConstruct() A
last analyzed 2020-06-20 15:42 UTC

↳ Parent: AppsSettingsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	3
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Canvas\Api\Controllers;

use Baka\Http\Api\BaseController as BakaBaseController;
filter:
    dependency_paths: ["lib/*"]
use Canvas\Models\Apps;
use Canvas\Dto\AppsSettings;
use Phalcon\Http\Response;
filter:
    dependency_paths: ["lib/*"]

/**
 * Class LanguagesController.
 *
 * @package Canvas\Api\Controllers
 *
 */
class AppsSettingsController extends BakaBaseController
{
    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $createFields = [];

    /*
     * fields we accept to create
     *
     * @var array
     */
    protected $updateFields = [];

    /**
     * set objects.
     *
     * @return void
     */
    public function onConstruct()
    {
        $this->model = new Apps();

    }

    /**
     * Format output.
     *
     * @param mixed $results
     * @return void
     */
    protected function processOutput($results)
    {
        //DTOAppsSettings
        $this->dtoConfig->registerMapping(Apps::class, AppsSettings::class)
          ->forMember('settings', function (Apps $app) {
              $settings = [];
              foreach ($app->settingsApp->toArray() as $setting) {
                  $settings[$setting['name']] = $setting['value'];
              }
              return $settings;
          });

        return is_iterable($results) ?
                $this->mapper->mapMultiple(iterator_to_array($results), AppsSettings::class)
                : $this->mapper->map($results, AppsSettings::class);
    }

    /**
     * get item.
     *
     * @param mixed $id
     *
     * @method GET
     * @url /v1/data/{id}
     *
     * @return \Phalcon\Http\Response
     */
    public function getByKey($key = null): Response
    {
        //find the info
        $record = $this->model->findFirstOrFail([
            'key = ?0 AND is_deleted = 0',
            'bind' => [$key],
        ]);

        return $this->response($this->processOutput($record));
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Canvas\Api\Controllers;
6
7			use Baka\Http\Api\BaseController as BakaBaseController;
			0 ignored issues – show Bug introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The type `Baka\Http\Api\BaseController` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use Canvas\Models\Apps;
9			use Canvas\Dto\AppsSettings;
10			use Phalcon\Http\Response;
			0 ignored issues – show Bug introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The type `Phalcon\Http\Response` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
11
12			/**
13			* Class LanguagesController.
14			*
15			* @package Canvas\Api\Controllers
16			*
17			*/
18			class AppsSettingsController extends BakaBaseController
19			{
20			/*
21			* fields we accept to create
22			*
23			* @var array
24			*/
25			protected $createFields = [];
26
27			/*
28			* fields we accept to create
29			*
30			* @var array
31			*/
32			protected $updateFields = [];
33
34			/**
35			* set objects.
36			*
37			* @return void
38			*/
39			public function onConstruct()
40			{
41			$this->model = new Apps();
			0 ignored issues – show Bug Best Practice introduced 2020-04-02 15:50 UTC by Report Bug Copy Issue Report The property `model` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
42			}
43
44			/**
45			* Format output.
46			*
47			* @param mixed $results
48			* @return void
49			*/
50			protected function processOutput($results)
51			{
52			//DTOAppsSettings
53			$this->dtoConfig->registerMapping(Apps::class, AppsSettings::class)
54			->forMember('settings', function (Apps $app) {
55			$settings = [];
56			foreach ($app->settingsApp->toArray() as $setting) {
57			$settings[$setting['name']] = $setting['value'];
58			}
59			return $settings;
60			});
61
62			return is_iterable($results) ?
63			$this->mapper->mapMultiple(iterator_to_array($results), AppsSettings::class)
64			: $this->mapper->map($results, AppsSettings::class);
65			}
66
67			/**
68			* get item.
69			*
70			* @param mixed $id
71			*
72			* @method GET
73			* @url /v1/data/{id}
74			*
75			* @return \Phalcon\Http\Response
76			*/
77			public function getByKey($key = null): Response
78			{
79			//find the info
80			$record = $this->model->findFirstOrFail([
81			'key = ?0 AND is_deleted = 0',
82			'bind' => [$key],
83			]);
84
85			return $this->response($this->processOutput($record));
			0 ignored issues – show Bug introduced 2019-06-12 19:23 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->processOutput($record)` targeting `Canvas\Api\Controllers\A...roller::processOutput()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
86			}
87			}
88

bakaphp / canvas-core

AppsSettingsController::onConstruct() A last analyzed 2020-06-20 15:42 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AppsSettingsController::onConstruct() A
last analyzed 2020-06-20 15:42 UTC