Canvas\Notifications\Notify

Complexity

Total Complexity

7

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	all()	0	4	2
A	one()	0	13	5

<?php

declare (strict_types = 1);

namespace Canvas\Notifications;

use Canvas\Contracts\Auth\UserInterface;
use Canvas\Contracts\Notifications\NotificationInterface;
use Canvas\Models\Users;

This use statement conflicts with another class in this namespace, Canvas\Notifications\Users. Consider defining an alias.

use Phalcon\Di;

class Notify
{
    /**
     * Send the nofitication to all the users.
     *
     * @param array | ResultsetInterface $users

The type Canvas\Notifications\ResultsetInterface was not found. Maybe you did not declare it correctly or list all dependencies?

     * @param NotificationInterface $notification
     *
     * @return void
     */
    public static function all($users, NotificationInterface $notification)
    {
        foreach ($users as $user) {
            self::one($user, $notification);
        }
    }

    /**
     * Process just one.
     *
     * @param Users $user
     * @param NotificationInterface $notification
     *
     * @return void
     */
    public static function one(UserInterface $user, NotificationInterface $notification): bool
    {
        $user = !$notification->getTo() ? $user : $notification->getTo();

The method getTo() does not exist on Canvas\Contracts\Notifications\NotificationInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Canvas\Contracts\Notifications\NotificationInterface.

        if (Di::getDefault()->has('userData') && !$notification->getFrom()) {

The method getFrom() does not exist on Canvas\Contracts\Notifications\NotificationInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Canvas\Contracts\Notifications\NotificationInterface.

            $from = Di::getDefault()->getUserData();
        } else {
            $from = !$notification->getFrom() ? $user : $notification->getFrom();
        }
        $notification->setTo($user);
        $notification->setFrom($from);

        return $notification->process();

The expression return $notification->process() returns the type boolean which is incompatible with the documented return type void.

    }
}