Canvas\Cli\Jobs\Apps

Complexity

Total Complexity

3

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	handle()	0	33	2

<?php

namespace Canvas\Cli\Jobs;

use Canvas\Contracts\Queue\QueueableJobInterface;
use Canvas\Jobs\Job;
use Phalcon\Di;
use Canvas\Models\Apps as CanvasApps;
use Phalcon\Security\Random;

The type Phalcon\Security\Random was not found. Maybe you did not declare it correctly or list all dependencies?

class Apps extends Job implements QueueableJobInterface
{
    /**
     * Realtime channel
     *
     * @var string
     */
    protected $appName;

    /**
     * Realtime event
     *
     * @var string
     */
    protected $appDescription;

    /**
     * Realtime params
     *
     * @var array
     */
    protected $params;

    /**
     * Constructor setup info for Pusher
     *
     * @param string $channel
     * @param string $event
     * @param array $params
     */
    public function __construct(string $appName, string $appDescription, array $params)
    {
        $this->appName = $appName;
        $this->appDescription = $appDescription;
        $this->params = $params;
    }

    /**
     * Handle the pusher request
     * @todo New Apps can't be created, the system does not take into account the creation of other apps apart from the default. Need to change this
     * @return void
     */
    public function handle()
    {
        $random = new Random();
        $appDescription = $this->appDescription;

        $app = new CanvasApps();
        $app->name = $this->appName;
        $app->description = $appDescription;
        $app->key = $random->uuid();
        $app->is_public = 1;
        $app->default_apps_plan_id = 1;
        $app->created_at = date('Y-m-d H:i:s');
        $app->is_deleted = 0;
        $app->payments_active = 0;

        if (!$app->save()) {
            Di::getDefault()->getLog()->error('App could not be created');
            return false;

The expression return false returns the type false which is incompatible with the documented return type void.

        }

        /**
         * @todo Only works for default app
         */
        Di::getDefault()->getAcl()->setApp($app);

        Di::getDefault()->getAcl()->addRole($appName .'.Admins');

The variable $appName seems to be never defined.

        Di::getDefault()->getAcl()->addRole($appName .'.Agents');
        Di::getDefault()->getAcl()->addRole($appName .'.Users');

        Di::getDefault()->getAcl()->addResource($appName .'.Users', ['read', 'list', 'create', 'update', 'delete']);
        Di::getDefault()->getAcl()->allow('Admins', $appName .'.Users', ['read', 'list', 'create', 'update', 'delete']);

        return true;

The expression return true returns the type true which is incompatible with the documented return type void.

    }
}