bSecureCheckout /
bsecure-payments-js
| Conditions | 25 |
| Total Lines | 126 |
| Code Lines | 93 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like index.js ➔ prepareFrameListener often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | let { errorHandlers, bSecurePaymentsHandler, bSecurePaymentsEventHandler } = require("../utils/listeners"); |
||
| 13 | function prepareFrameListener() { |
||
| 14 | /* |
||
| 15 | * CHECK TRANSACTION PARAMETERS |
||
| 16 | */ |
||
| 17 | if (isEmpty(TransactionParameters.__00trid__)) { |
||
|
Bug
introduced
by
|
|||
| 18 | return { |
||
| 19 | status: false, |
||
| 20 | exception: errorHandlers.formatValidationError("pp_OrderId is required."), |
||
| 21 | }; |
||
| 22 | } else if (isEmpty(TransactionParameters.__01curr__)) { |
||
| 23 | return { |
||
| 24 | status: false, |
||
| 25 | exception: errorHandlers.formatValidationError("pp_TxnCurrency is required."), |
||
| 26 | }; |
||
| 27 | } else if (isEmpty(TransactionParameters.__02trdt__)) { |
||
| 28 | return { |
||
| 29 | status: false, |
||
| 30 | exception: errorHandlers.formatValidationError("pp_TxnDateTime is required."), |
||
| 31 | }; |
||
| 32 | } else if (isEmpty(TransactionParameters.__03stamt__)) { |
||
| 33 | return { |
||
| 34 | status: false, |
||
| 35 | exception: errorHandlers.formatValidationError("pp_TxnSubTotal is required."), |
||
| 36 | }; |
||
| 37 | } else if (isEmpty(TransactionParameters.__04damt__)) { |
||
| 38 | return { |
||
| 39 | status: false, |
||
| 40 | exception: errorHandlers.formatValidationError("pp_TxnDiscount is required."), |
||
| 41 | }; |
||
| 42 | } else if (isEmpty(TransactionParameters.__05tamt__)) { |
||
| 43 | return { |
||
| 44 | status: false, |
||
| 45 | exception: errorHandlers.formatValidationError("pp_TxnTotal is required."), |
||
| 46 | }; |
||
| 47 | } else if (isEmpty(TransactionParameters.__06cname__)) { |
||
| 48 | return { |
||
| 49 | status: false, |
||
| 50 | exception: errorHandlers.formatValidationError("pp_CustomerName is required."), |
||
| 51 | }; |
||
| 52 | } else if (isEmpty(TransactionParameters.__07ccc__)) { |
||
| 53 | return { |
||
| 54 | status: false, |
||
| 55 | exception: errorHandlers.formatValidationError("pp_CustomerCountryCode is required."), |
||
| 56 | }; |
||
| 57 | } else if (isEmpty(TransactionParameters.__08cphn__)) { |
||
| 58 | return { |
||
| 59 | status: false, |
||
| 60 | exception: errorHandlers.formatValidationError("pp_CustomerPhoneNumber is required."), |
||
| 61 | }; |
||
| 62 | } else if (isEmpty(TransactionParameters.__10ccc__)) { |
||
| 63 | return { |
||
| 64 | status: false, |
||
| 65 | exception: errorHandlers.formatValidationError("pp_CustomerCountry is required."), |
||
| 66 | }; |
||
| 67 | } else if (isEmpty(TransactionParameters.__11cstate__)) { |
||
| 68 | return { |
||
| 69 | status: false, |
||
| 70 | exception: errorHandlers.formatValidationError("pp_CustomerState is required."), |
||
| 71 | }; |
||
| 72 | } else if (isEmpty(TransactionParameters.__12ccity__)) { |
||
| 73 | return { |
||
| 74 | status: false, |
||
| 75 | exception: errorHandlers.formatValidationError("pp_CustomerCity is required."), |
||
| 76 | }; |
||
| 77 | } else if (isEmpty(TransactionParameters.__13carea__)) { |
||
| 78 | return { |
||
| 79 | status: false, |
||
| 80 | exception: errorHandlers.formatValidationError("pp_CustomerArea is required."), |
||
| 81 | }; |
||
| 82 | } else if (isEmpty(TransactionParameters.__14cfadd__)) { |
||
| 83 | return { |
||
| 84 | status: false, |
||
| 85 | exception: errorHandlers.formatValidationError("pp_CustomerFormattedAddress is required."), |
||
| 86 | }; |
||
| 87 | } else if (isEmpty(TransactionParameters.__15mid__)) { |
||
| 88 | return { |
||
| 89 | status: false, |
||
| 90 | exception: errorHandlers.formatValidationError("pp_MerchantID is required."), |
||
| 91 | }; |
||
| 92 | } else if (isEmpty(TransactionParameters.__16stid__)) { |
||
| 93 | return { |
||
| 94 | status: false, |
||
| 95 | exception: errorHandlers.formatValidationError("pp_StoreSlug is required."), |
||
| 96 | }; |
||
| 97 | } else if (isEmpty(TransactionParameters.__17seh__)) { |
||
| 98 | return { |
||
| 99 | status: false, |
||
| 100 | exception: errorHandlers.formatValidationError("pp_SecureId is required."), |
||
| 101 | }; |
||
| 102 | } else if (isEmpty(TransactionParameters.__18ver__)) { |
||
| 103 | return { |
||
| 104 | status: false, |
||
| 105 | exception: errorHandlers.formatValidationError("pp_Version is required."), |
||
| 106 | }; |
||
| 107 | } else if (isEmpty(TransactionParameters.__20red__)) { |
||
| 108 | return { |
||
| 109 | status: false, |
||
| 110 | exception: errorHandlers.formatValidationError("pp_RedirectURL is required."), |
||
| 111 | }; |
||
| 112 | } else if (isEmpty(TransactionParameters.__21cenv__)) { |
||
| 113 | return { |
||
| 114 | status: false, |
||
| 115 | exception: errorHandlers.formatValidationError("pp_ClientEnviromentId is required."), |
||
| 116 | }; |
||
| 117 | } else if (!navigator.cookieEnabled) { |
||
| 118 | return { |
||
| 119 | status: false, |
||
| 120 | exception: errorHandlers.formatValidationError("Please Allow All Cookies from your browser settings."), |
||
| 121 | }; |
||
| 122 | } |
||
| 123 | /* |
||
| 124 | * RECEIVE MESSAGE FROM CHILD |
||
| 125 | */ |
||
| 126 | window.addEventListener("message", (e) => { |
||
| 127 | if (e.data.source === "embeddableShakehand") { |
||
| 128 | errorHandlers.handleErrors(e.data.data) |
||
| 129 | } |
||
| 130 | if (e.data.source === "embeddableShakehandSuccess") { |
||
| 131 | errorHandlers.handlePayments(e.data.data) |
||
| 132 | } |
||
| 133 | }); |
||
| 134 | return { |
||
| 135 | status: true, |
||
| 136 | exception: '', |
||
| 137 | }; |
||
| 138 | } |
||
| 139 | |||
| 194 |
Loading history...