b2pweb / parroauth2-client

src/Extension/AbstractEndPointTransformerExtension.php

<?php

namespace Parroauth2\Client\Extension;

use Parroauth2\Client\ClientInterface;
use Parroauth2\Client\EndPoint\EndPointTransformerInterface;

/**
 * Implements extension for EndPointTransformer
 */
abstract class AbstractEndPointTransformerExtension implements ExtensionInterface, EndPointTransformerInterface
{
    /**
     * @var ClientInterface|null
     */
    private $client;

    /**
     * {@inheritdoc}
     */
    final public function configure(ClientInterface $client): void
    {
        $extension = $this->client === null ? $this : clone $this;
        $extension->client = $client;

        $client->endPoints()->register($extension);
    }

    /**
     * Get the configured client
     *
     * @return ClientInterface
     *
     * @psalm-mutation-free
     *
     * @psalm-suppress InvalidNullableReturnType
     * @psalm-suppress NullableReturnStatement
     */
    final protected function client(): ClientInterface
    {
        return $this->client;

The expression return $this->client could return the type null which is incompatible with the type-hinted return Parroauth2\Client\ClientInterface. Consider adding an additional type-check to rule them out.

    }
}