ObjectNormalizer::instantiate() - Code Metrics - b2pweb/bdf-serializer - Measure and Improve Code Quality continuously with Scrutinizer

ObjectNormalizer::instantiate() A
last analyzed 2023-03-02 14:56 UTC

↳ Parent: ObjectNormalizer

Complexity

Conditions	2
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	1
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	2
rs	10

<?php

namespace Bdf\Serializer\Normalizer;

use Bdf\Serializer\Context\DenormalizationContext;
use Bdf\Serializer\Context\NormalizationContext;
use Bdf\Serializer\Type\Type;
use Bdf\Serializer\Type\TypeFactory;
use stdClass;

/**
 * ObjectNormalizer
 *
 * @author  Seb
 *
 * @implements NormalizerInterface<stdClass>
 */
class ObjectNormalizer implements NormalizerInterface, AutoRegisterInterface
{
    /**
     * {@inheritdoc}
     */
    public function normalize($data, NormalizationContext $context)
    {
        $hash = $context->assertNoCircularReference($data);

        $normalized = [];

        foreach ((array)$data as $property => $value) {
            $value = $context->root()->normalize($value, $context);

            if ($value === null && !$context->shouldAddNull()) {
                continue;
            }

            $normalized[$property] = $value;
        }

        $context->releaseReference($hash);

        return $normalized;
    }

    /**
     * {@inheritdoc}
     */
    public function denormalize($data, Type $type, DenormalizationContext $context)
    {
        $object = $this->instantiate($type);

        foreach ((array)$data as $name => $propertyData) {
            $object->$name = $context->root()->denormalize($propertyData, TypeFactory::mixedType(), $context);
        }

        return $object;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * Instanciate an object
     *
     * @param Type $type
     *
     * @return stdClass
     */
    private function instantiate($type)
    {
        return $type->target() ?: new stdClass();
    }

    /**
     * {@inheritdoc}
     */
    public function supports(string $className): bool
    {
        return $className === stdClass::class;
    }

    /**
     * {@inheritdoc}
     */
    public function registerTo(NormalizerLoaderInterface $loader): void
    {
        $loader->associate(stdClass::class, $this);
    }
}


1		<?php
2
3		namespace Bdf\Serializer\Normalizer;
4
5		use Bdf\Serializer\Context\DenormalizationContext;
6		use Bdf\Serializer\Context\NormalizationContext;
7		use Bdf\Serializer\Type\Type;
8		use Bdf\Serializer\Type\TypeFactory;
9		use stdClass;
10
11		/**
12		* ObjectNormalizer
13		*
14		* @author Seb
15		*
16		* @implements NormalizerInterface<stdClass>
17		*/
18		class ObjectNormalizer implements NormalizerInterface, AutoRegisterInterface
19		{
20		/**
21		* {@inheritdoc}
22		*/
23	6	public function normalize($data, NormalizationContext $context)
24		{
25	6	$hash = $context->assertNoCircularReference($data);
26
27	6	$normalized = [];
28
29	6	foreach ((array)$data as $property => $value) {
30	6	$value = $context->root()->normalize($value, $context);
31
32	4	if ($value === null && !$context->shouldAddNull()) {
33		continue;
34		}
35
36	4	$normalized[$property] = $value;
37		}
38
39	4	$context->releaseReference($hash);
40
41	4	return $normalized;
42		}
43
44		/**
45		* {@inheritdoc}
46		*/
47	4	public function denormalize($data, Type $type, DenormalizationContext $context)
48		{
49	4	$object = $this->instantiate($type);
50
51	4	foreach ((array)$data as $name => $propertyData) {
52	4	$object->$name = $context->root()->denormalize($propertyData, TypeFactory::mixedType(), $context);
53		}
54
55	4	return $object;
		0 ignored issues – show Bug Best Practice introduced 2022-02-04 15:22 UTC by Report Bug Copy Issue Report The expression `return $object` returns the type `stdClass` which is incompatible with the return type mandated by `Bdf\Serializer\Normalize...nterface::denormalize()` of `Bdf\Serializer\Normalizer\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
56		}
57
58		/**
59		* Instanciate an object
60		*
61		* @param Type $type
62		*
63		* @return stdClass
64		*/
65	4	private function instantiate($type)
66		{
67	4	return $type->target() ?: new stdClass();
68		}
69
70		/**
71		* {@inheritdoc}
72		*/
73	2	public function supports(string $className): bool
74		{
75	2	return $className === stdClass::class;
76		}
77
78		/**
79		* {@inheritdoc}
80		*/
81	12	public function registerTo(NormalizerLoaderInterface $loader): void
82		{
83	12	$loader->associate(stdClass::class, $this);
84		}
85		}
86

b2pweb / bdf-serializer

ObjectNormalizer::instantiate() A last analyzed 2023-03-02 14:56 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ObjectNormalizer::instantiate() A
last analyzed 2023-03-02 14:56 UTC