DoctrineConnectionProviderAdapter::getConnection() - Code Metrics - Inspection of "feat: Adding console command to run sql" - b2pweb/bdf-prime - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 9a0773...1fd30e )

by Sébastien

created 2021-09-14 11:43 UTC

DoctrineConnectionProviderAdapter::getConnection() A

↳ Parent: DoctrineConnectionProviderAdapter

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	13
rs	10
cc	3
nc	3
nop	1

<?php

namespace Bdf\Prime\Console\ConnectionProvider;

use Bdf\Prime\ConnectionManager;
use Bdf\Prime\Exception\DBALException;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Connection as DoctrineConnection;
use Doctrine\DBAL\Tools\Console\ConnectionNotFound;
use Doctrine\DBAL\Tools\Console\ConnectionProvider;

/**
 * The prime adapter for doctrine connection provider used by doctrine in console command
 */
class DoctrineConnectionProviderAdapter implements ConnectionProvider
{
    /**
     * @var ConnectionManager
     */
    private $connectionManager;

    /**
     * @param ConnectionManager $connectionManager
     */
    public function __construct(ConnectionManager $connectionManager)
    {
        $this->connectionManager = $connectionManager;
    }

    /**
     * {@inheritDoc}
     */
    public function getDefaultConnection(): Connection
    {
        return $this->getConnection($this->connectionManager->getDefaultConnection());
    }

    /**

     * {@inheritDoc}
     */

    public function getConnection(string $name): Connection
    {
        try {
            $connection = $this->connectionManager->getConnection($name);
        } catch (DBALException $exception) {
            throw new ConnectionNotFound("The connection '$name' is not found.", 0, $exception);
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        if (!$connection instanceof DoctrineConnection) {
            throw new ConnectionNotFound("The connection '$name' is not a doctrine connection.");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        return $connection;
    }
}

1			<?php
2
3			namespace Bdf\Prime\Console\ConnectionProvider;
4
5			use Bdf\Prime\ConnectionManager;
6			use Bdf\Prime\Exception\DBALException;
7			use Doctrine\DBAL\Connection;
8			use Doctrine\DBAL\Connection as DoctrineConnection;
9			use Doctrine\DBAL\Tools\Console\ConnectionNotFound;
10			use Doctrine\DBAL\Tools\Console\ConnectionProvider;
11
12			/**
13			* The prime adapter for doctrine connection provider used by doctrine in console command
14			*/
15			class DoctrineConnectionProviderAdapter implements ConnectionProvider
16			{
17			/**
18			* @var ConnectionManager
19			*/
20			private $connectionManager;
21
22			/**
23			* @param ConnectionManager $connectionManager
24			*/
25			public function __construct(ConnectionManager $connectionManager)
26			{
27			$this->connectionManager = $connectionManager;
28			}
29
30			/**
31			* {@inheritDoc}
32			*/
33			public function getDefaultConnection(): Connection
34			{
35			return $this->getConnection($this->connectionManager->getDefaultConnection());
36			}
37
38			/**
			0 ignored issues – show Coding Style introduced 2021-09-14 11:50 UTC by Report Bug Copy Issue Report Parameter `$name` should have a doc-comment as per coding-style. Loading history...
39			* {@inheritDoc}
40			*/
			0 ignored issues – show Coding Style Documentation introduced 2021-09-14 11:50 UTC by Report Bug Copy Issue Report Missing @throws tag in function comment Loading history...
41			public function getConnection(string $name): Connection
42			{
43			try {
44			$connection = $this->connectionManager->getConnection($name);
45			} catch (DBALException $exception) {
46			throw new ConnectionNotFound("The connection '$name' is not found.", 0, $exception);
			0 ignored issues – show Coding Style Best Practice introduced 2021-09-14 11:50 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$name` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
47			}
48
49			if (!$connection instanceof DoctrineConnection) {
50			throw new ConnectionNotFound("The connection '$name' is not a doctrine connection.");
			0 ignored issues – show Coding Style Best Practice introduced 2021-09-14 11:50 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$name` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
51			}
52
53			return $connection;
54			}
55			}

b2pweb / bdf-prime

Push — master ( 9a0773...1fd30e )

DoctrineConnectionProviderAdapter::getConnection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like