b2pweb / bdf-form

src/View/FieldSetViewTrait.php

<?php

namespace Bdf\Form\View;

use ArrayIterator;
use BadMethodCallException;
use Iterator;

/**
 * Implements @see FieldSetViewInterface
 *
 * @psalm-require-implements FieldSetViewInterface
 */
trait FieldSetViewTrait
{
    /**
     * @var array<string, ElementViewInterface>
     */
    private $elements = [];

    /**
     * {@inheritdoc}
     */
    public function offsetExists($offset): bool
    {
        return isset($this->elements[$offset]);
    }

    /**
     * {@inheritdoc}
     */
    public function offsetGet($offset): ElementViewInterface
    {
        return $this->elements[$offset];
    }

    /**
     * {@inheritdoc}
     */
    public function offsetSet($offset, $value): void

The parameter $offset is not used and could be removed.

The parameter $value is not used and could be removed.

    {
        throw new BadMethodCallException('FormView is read only');
    }

    /**
     * {@inheritdoc}
     */
    public function offsetUnset($offset): void

The parameter $offset is not used and could be removed.

    {
        throw new BadMethodCallException('FormView is read only');
    }

    /**
     * {@inheritdoc}
     */
    public function hasError(): bool
    {
        if ($this->error() !== null) {

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return true;
        }

        foreach ($this->elements as $element) {
            if ($element->hasError()) {
                return true;
            }
        }

        return false;
    }

    /**
     * {@inheritdoc}
     *
     * @return Iterator<string, ElementViewInterface>
     * @psalm-suppress ImplementedReturnTypeMismatch
     */
    public function getIterator(): Iterator
    {
        return new ArrayIterator($this->elements);
    }
}