SelectHtmlRenderer::render() - Code Metrics - Inspection of "PHP 8.1 compatibility" - b2pweb/bdf-form - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3)

by Vincent

created 2022-02-01 14:40 UTC

SelectHtmlRenderer::render() A

↳ Parent: SelectHtmlRenderer

Complexity

Conditions	4
Paths	5

Size

Total Lines	20
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	10
dl	0
loc	20
ccs	11
cts	11
cp	1
rs	9.9332
c	1
b	0
f	0
cc	4
nc	5
nop	2
crap	4

<?php

namespace Bdf\Form\Leaf\View;

use Bdf\Form\View\FieldViewInterface;
use Bdf\Form\View\FieldViewRendererInterface;
use Bdf\Form\View\HtmlRenderer;
use InvalidArgumentException;

/**
 * Renderer for select element
 * Should be used for element with choices
 */
final class SelectHtmlRenderer implements FieldViewRendererInterface
{
    /**
     * @var SelectHtmlRenderer|null
     */
    private static $instance;

    /**
     * {@inheritdoc}
     */
    public function render(FieldViewInterface $view, array $attributes): string
    {
        if (!$choices = $view->choices()) {
            throw new InvalidArgumentException('Choices must be provided for render a select element.');
        }

        $attributes['name'] = $view->name();
        $attributes['required'] = $view->required();

        if (!empty($attributes['multiple'])) {
            $attributes['name'] .= '[]';
        }

        $options = '';

        foreach ($choices as $choice) {
            $options .= HtmlRenderer::element('option', ['value' => $choice->value(), 'selected' => $choice->selected()], htmlentities($choice->label()));
        }

        return HtmlRenderer::element('select', $attributes, $options);
    }

    /**
     * Get the renderer instance
     *
     * @return self
     */
    public static function instance(): self
    {
        if (self::$instance) {
            return self::$instance;
        }

        return self::$instance = new self;
    }
}


1		<?php
2
3		namespace Bdf\Form\Leaf\View;
4
5		use Bdf\Form\View\FieldViewInterface;
6		use Bdf\Form\View\FieldViewRendererInterface;
7		use Bdf\Form\View\HtmlRenderer;
8		use InvalidArgumentException;
9
10		/**
11		* Renderer for select element
12		* Should be used for element with choices
13		*/
14		final class SelectHtmlRenderer implements FieldViewRendererInterface
15		{
16		/**
17		* @var SelectHtmlRenderer\|null
18		*/
19		private static $instance;
20
21		/**
22		* {@inheritdoc}
23		*/
24	12	public function render(FieldViewInterface $view, array $attributes): string
25		{
26	12	if (!$choices = $view->choices()) {
27	1	throw new InvalidArgumentException('Choices must be provided for render a select element.');
28		}
29
30	11	$attributes['name'] = $view->name();
31	11	$attributes['required'] = $view->required();
32
33	11	if (!empty($attributes['multiple'])) {
34	2	$attributes['name'] .= '[]';
35		}
36
37	11	$options = '';
38
39	11	foreach ($choices as $choice) {
40	11	$options .= HtmlRenderer::element('option', ['value' => $choice->value(), 'selected' => $choice->selected()], htmlentities($choice->label()));
41		}
42
43	11	return HtmlRenderer::element('select', $attributes, $options);
44		}
45
46		/**
47		* Get the renderer instance
48		*
49		* @return self
50		*/
51	19	public static function instance(): self
52		{
53	19	if (self::$instance) {
54	18	return self::$instance;
55		}
56
57	1	return self::$instance = new self;
58		}
59		}
60

b2pweb / bdf-form

Pull Request — master (#3)

SelectHtmlRenderer::render() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like