b2binpay / magento2

Helper/Wallets.php

<?php

namespace B2Binpay\Payment\Helper;

/**
 * Wallets value manipulation helper
 */
class Wallets
{
    /**
     * Check whether value is in form retrieved by _encodeArrayFieldValue()
     *
     * @param string|array $value
     * @return bool
     */
    protected function isEncodedArrayFieldValue($value)
    {
        if (!is_array($value)) {
            return false;
        }
        unset($value['__empty']);
        foreach ($value as $row) {
            if (!is_array($row)
                || !array_key_exists('wallet', $row)
                || !array_key_exists('currency', $row)
            ) {
                return false;
            }
        }
        return true;
    }

    /**
     * Encode value to be used in \Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray
     *
     * @param array $value
     * @return array
     */
    protected function encodeArrayFieldValue($value)
    {
        if (!is_array($value)) {

The condition is_array($value) is always true.

            return null;
        }
        $result = [];
        foreach ($value as $wallet => $currency) {
            $result[] = ['wallet' => $wallet, 'currency' => $currency];
        }
        return $result;
    }

    /**
     * Decode value from used in \Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray
     *
     * @param array $value
     * @return array
     */
    protected function decodeArrayFieldValue(array $value)
    {
        $result = [];
        unset($value['__empty']);
        foreach ($value as $row) {
            $wallet = $row['wallet'];
            $currency = $row['currency'];
            $result[$wallet] = $currency;
        }
        return $result;
    }

    /**
     * Make value readable by \Magento\Config\Block\System\Config\Form\Field\FieldArray\AbstractFieldArray
     *
     * @param string|array $value
     * @return array
     */
    public function makeArrayFieldValue($value)
    {
        $value = json_decode($value, true);

It seems like $value can also be of type array; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        if (!$this->isEncodedArrayFieldValue($value)) {
            $value = $this->encodeArrayFieldValue($value);
        }
        return $value;
    }

    /**
     * Make value ready for store
     *
     * @param string|array $value
     * @return string
     */
    public function makeStorableArrayFieldValue($value)
    {
        if ($this->isEncodedArrayFieldValue($value)) {
            $value = $this->decodeArrayFieldValue($value);

It seems like $value can also be of type string; however, parameter $value of B2Binpay\Payment\Helper\Wallets::decodeArrayFieldValue() does only seem to accept array, maybe add an additional type check?

        }
        $value = json_encode($value);
        return $value;
    }
}