Index::execute() - Code Metrics - Inspection of "magento2.3 compatible" - b2binpay/magento2 - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — 2.3 (92ba2c)

by Alexander

created 2018-11-30 11:13 UTC

Index::execute() A

↳ Parent: Index

Complexity

Conditions	5
Paths	7

Size

Total Lines	61
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	37
dl	0
loc	61
rs	9.0168
c	0
b	0
f	0
cc	5
nc	7
nop	0

How to fix Long Method

<?php

namespace B2Binpay\Payment\Controller\Callback;

use Magento\Sales\Model\Order;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\Action\Context;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\Action\Action;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\CsrfAwareActionInterface;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\Request\InvalidRequestException;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\App\RequestInterface;
filter:
    dependency_paths: ["lib/*"]
use Magento\Framework\Controller\Result\RawFactory;
filter:
    dependency_paths: ["lib/*"]
use B2Binpay\Payment\Gateway\Validator\CallbackValidator;
use B2Binpay\AmountFactory;
filter:
    dependency_paths: ["lib/*"]
use Psr\Log\LoggerInterface;
filter:
    dependency_paths: ["lib/*"]

class Index extends Action implements CsrfAwareActionInterface
{
    /**
     * @var RawFactory
     */
    protected $rawResultFactory;

    /**
     * @var Context
     */
    protected $context;

    /**
     * @var CallbackValidator
     */
    protected $validator;

    /**
     * @var LoggerInterface
     */
    protected $logger;

    /**
     * @var AmountFactory
     */
    private $amountFactory;

    /**
     * Callback controller.
     *
     * @param Context $context
     * @param RawFactory $rawResultFactory
     * @param CallbackValidator $validator
     * @param AmountFactory $amountFactory
     * @param LoggerInterface $logger
     */
    public function __construct(
        Context $context,
        RawFactory $rawResultFactory,
        CallbackValidator $validator,
        AmountFactory $amountFactory,
        LoggerInterface $logger
    ) {
        $this->context = $context;
        $this->rawResultFactory = $rawResultFactory;
        $this->validator = $validator;
        $this->amountFactory = $amountFactory;
        $this->logger = $logger;
        parent::__construct($context);
    }

    /**
     * @inheritDoc
     */
    public function createCsrfValidationException(
        RequestInterface $request
    ): ?InvalidRequestException {
        return null;
    }

    /**
     * @inheritDoc
     */
    public function validateForCsrf(RequestInterface $request): ?bool
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function execute()
    {
        $request = $this->context->getRequest();
        $result = $this->rawResultFactory->create();

        $validationResult = $this->validator->validate(['request' => $request]);

        $validation = $validationResult->getFailsDescription();

        if (!$validationResult->isValid()) {
            $result->setStatusHeader($validation['status'], '1.1', $validation['message']);

            return $result;
        }

        $order = $validation['order'];
        $payment = $order->getPayment();
        $params = $request->getParams();

        $billStatus = (string)$params['status'];

        if ('2' === $billStatus) {
            if ($params['amount'] === $params['actual_amount']) {
                $totalDue = $order->getTotalDue();

                $payment->authorize(false, $totalDue);
                $payment->registerCaptureNotification($totalDue);

                $order->addStatusToHistory(
                    $order::STATE_PROCESSING,
                    __('B2BinPay payment complete!')
                    __('B2BinPay payment complete!')
                );
            } else {
                $actualAmount = $this->amountFactory->create(
                    $params['actual_amount'],
                    $params['currency']['iso'],
                    $params['pow']
                )->getValue();

                $order->addStatusToHistory(
                    $order::STATE_PAYMENT_REVIEW,
                    __('B2BinPay received payment: ' . $actualAmount . $params['currency']['alpha'])
                );
            }
        }

        $stateList = $this->getStateDesc();

        if (!empty($stateList[$billStatus])) {
            $order->addStatusToHistory(
                $stateList[$billStatus]['state'],
                $stateList[$billStatus]['message']
            );
        }

        $order->save();

        $result->setStatusHeader('200', '1.1', 'OK');
        $result->setContents('OK');

        return $result;
    }

    /**
     * @return array
     */
    private function getStateDesc()
    {
        return [
            '-2' => [
                'state' => Order::STATE_CLOSED,
                'message' => __('B2BinPay payment error!')
                'message' => /** @scrutinizer ignore-call */ __('B2BinPay payment error!')
            ],
            '-1' => [
                'state' => Order::STATE_CANCELED,
                'message' => __('B2BinPay payment expired!')
            ],
            '3' => [
                'state' => Order::STATE_PAYMENT_REVIEW,
                'message' => __('B2BinPay payment freeze!')
            ],
            '4' => [
                'state' => Order::STATE_CLOSED,
                'message' => __('B2BinPay payment closed!')
            ]
        ];
    }
}


b2binpay / magento2

Branch — 2.3 (92ba2c)

Index::execute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like