Alchemy\Zippy\Resource\ReaderResolver\ProtocolBasedReaderResolver

Complexity

Total Complexity

5

Size/Duplication

Total Lines	46
Duplicated Lines	30.43 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addFactory()	11	11	3
A	resolveReader()	3	11	2

<?php

namespace Alchemy\Zippy\Resource\ReaderResolver;

use Alchemy\Zippy\Resource\ResourceReader;
use Alchemy\Zippy\Resource\ResourceReaderFactory;
use Alchemy\Zippy\Resource\ResourceReaderResolver;
use Alchemy\Zippy\Resource\ResourceUri;

class ProtocolBasedReaderResolver implements ResourceReaderResolver
{
    /**
     * @var ResourceReaderFactory[]
     */
    private $factories = [];

    /**
     * @var int[] Dictionary of factory indexes, indexed by resource protocol name
     */
    private $protocolFactoryIndexes = [];

    /**
     * @param ResourceReaderFactory $factory
     * @param string|string[] $protocols List of compatible protocols
     */
    public function addFactory(ResourceReaderFactory $factory, $protocols)

This method seems to be duplicated in your project.

    {
        $protocols = is_array($protocols) ? $protocols : [ $protocols ];
        $index = count($this->factories);

        $this->factories[$index] = $factory;

        foreach ($protocols as $protocol) {
            $this->protocolFactoryIndexes[$protocol] = $index;
        }
    }

    /**
     * Resolves a reader for the given resource URI.
     *
     * @param ResourceUri $resource
     * @return ResourceReader
     */
    public function resolveReader(ResourceUri $resource)
    {
        if (! array_key_exists($resource->getProtocol(), $this->protocolFactoryIndexes)) {

This code seems to be duplicated across your project.

            throw new \RuntimeException('Unsupported protocol: ' . $resource->getProtocol() . '( ' . $resource  . ')');
        }

        $index = $this->protocolFactoryIndexes[$resource->getProtocol()];
        $factory = $this->factories[$index];

        return $factory->getReader($resource);
    }
}