Alchemy\Zippy\Resource\Reader\StreamReader

Complexity

Total Complexity

6

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	__destruct()	0	6	2
A	getContents()	0	4	1
A	getContentsAsStream()	0	12	2

<?php

namespace Alchemy\Zippy\Resource\Reader;

use Alchemy\Zippy\Resource\Resource;
use Alchemy\Zippy\Resource\ResourceReader;
use Alchemy\Zippy\Resource\ResourceUri;

class StreamReader implements ResourceReader
{
    /**
     * @var \Alchemy\Zippy\Resource\Resource
     */
    private $resource;

    /**
     * @var resource[]
     */
    private $streams = [];

    /**
     * @param ResourceUri $resource
     */
    public function __construct(ResourceUri $resource)
    {
        $this->resource = $resource;

It seems like $resource of type object<Alchemy\Zippy\Resource\ResourceUri> is incompatible with the declared type object<Alchemy\Zippy\Resource\Resource> of property $resource.

    }

    public function __destruct()
    {
        foreach ($this->streams as $stream) {
            @fclose($stream);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }
    }

    /**
     * @return string
     */
    public function getContents()
    {
        return stream_get_contents($this->getContentsAsStream());
    }

    /**
     * @return resource
     */
    public function getContentsAsStream()
    {
        $stream = @fopen(rawurldecode($this->resource), 'r');

        if ($stream === false) {
            throw new \RuntimeException('Unable to open stream resource for ' . rawurldecode($this->resource));
        }

        $this->streams[] = $stream;

        return $stream;
    }
}