Conditions | 15 |
Paths | 120 |
Total Lines | 47 |
Code Lines | 32 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
141 | public function createOrUpdateMessageSummary(MailgunEvent $event){ |
||
142 | $messageSummary = $this->findOneBy(array('id' => $event->getMessageId())); |
||
143 | if ($messageSummary == null) { |
||
144 | $ip = $event->getIp() != null ? $event->getIp() : "unknown"; |
||
145 | $messageSummary = new MailgunMessageSummary($event->getMessageId(), $event->getDateTime(), $event->getSender(), $event->getRecipient(), "no subject found yet", $ip); |
||
146 | } |
||
147 | $messageSummary->updateDeliveryStatus($event->getEvent()); |
||
148 | |||
149 | if ($event->getEvent() == 'opened') { |
||
150 | if ($messageSummary->getFirstOpened() == null || $messageSummary->getFirstOpened() > $event->getDateTime()) { |
||
151 | $messageSummary->setFirstOpened($event->getDateTime()); |
||
152 | } |
||
153 | if($messageSummary->getLastOpened() == null || $messageSummary->getLastOpened() < $event->getDateTime()) { |
||
154 | $messageSummary->setLastOpened($event->getDateTime()); |
||
155 | } |
||
156 | $messageSummary->increaseOpenCount(); |
||
157 | } |
||
158 | |||
159 | foreach ($event->getMessageHeaders() as $header) { |
||
160 | if($header[0] == 'X-Mailgun-Sending-Ip') { |
||
161 | $messageSummary->setSenderIp($header[1]); |
||
162 | } else |
||
163 | |||
164 | if($header[0] == 'Subject') { |
||
165 | $messageSummary->setSubject($header[1]); |
||
166 | } else |
||
167 | |||
168 | if($header[0] == 'Sender') { |
||
169 | $messageSummary->setFromAddress($header[1]); |
||
170 | } else |
||
171 | |||
172 | if($header[0] == 'To') { |
||
173 | $messageSummary->appendToToAddress($header[1]); |
||
174 | } else |
||
175 | |||
176 | if($header[0] == 'Cc') { |
||
177 | $messageSummary->appendToToAddress($header[1]); |
||
178 | } else |
||
179 | |||
180 | if($header[0] == 'Bcc') { |
||
181 | $messageSummary->appendToToAddress($header[1]); |
||
182 | } |
||
183 | } |
||
184 | |||
185 | $manager = $this->getEntityManager(); |
||
186 | $manager->persist($messageSummary); |
||
187 | $manager->flush($messageSummary); |
||
188 | } |
||
190 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.