HetrixtoolsServiceResponse::fromJson() - Code Metrics - Inspection of "Command for checking if ip is in blacklist" - azine/AzineMailgunWebhooksBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

unknown

created 2017-11-21 00:45 UTC

HetrixtoolsServiceResponse::fromJson() A

↳ Parent: HetrixtoolsServiceResponse

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
ccs	11
cts	11
cp	1
rs	9.2
cc	4
eloc	9
nc	4
nop	1
crap	4

<?php


namespace Azine\MailgunWebhooksBundle\Services\HetrixtoolsService;


class HetrixtoolsServiceResponse
{
    const RESPONSE_STATUS_SUCCESS = 'SUCCESS';
    const RESPONSE_STATUS_ERROR = 'ERROR';

    /**
     * @var string
     */
    public $status;

    /**
     * @var int
     */
    public $api_calls_left;

    /**
     * @var int
     */
    public $blacklist_check_credits_left;

    /**
     * @var int
     */
    public $blacklisted_count;

    /**
     * @var array
     */
    public $blacklisted_on;

    /**
     * @var array
     */
    public $links;

    /**
     * @var string
     */
    public $error_message;

    /**
     * @param string $response
     * @throws \InvalidArgumentException
     * @return HetrixtoolsServiceResponse $responseObject
     */
    public static function fromJson($response)
    {
        $response = json_decode($response, true);

        if(!is_array($response)) {
            throw new \InvalidArgumentException('Invalid JSON provided');
        }

        $responseObject = new self();

        foreach($responseObject as $key => $value){


            if(isset($response[$key])){

                $responseObject->$key = $response[$key];
            }
        }

        return $responseObject;
    }
}

1		<?php
2
3
4		namespace Azine\MailgunWebhooksBundle\Services\HetrixtoolsService;
5
6
7		class HetrixtoolsServiceResponse
8		{
9		const RESPONSE_STATUS_SUCCESS = 'SUCCESS';
10		const RESPONSE_STATUS_ERROR = 'ERROR';
11
12		/**
13		* @var string
14		*/
15		public $status;
16
17		/**
18		* @var int
19		*/
20		public $api_calls_left;
21
22		/**
23		* @var int
24		*/
25		public $blacklist_check_credits_left;
26
27		/**
28		* @var int
29		*/
30		public $blacklisted_count;
31
32		/**
33		* @var array
34		*/
35		public $blacklisted_on;
36
37		/**
38		* @var array
39		*/
40		public $links;
41
42		/**
43		* @var string
44		*/
45		public $error_message;
46
47		/**
48		* @param string $response
49		* @throws \InvalidArgumentException
50		* @return HetrixtoolsServiceResponse $responseObject
51		*/
52	2	public static function fromJson($response)
53		{
54	2	$response = json_decode($response, true);
55
56	2	if(!is_array($response)) {
57	1	throw new \InvalidArgumentException('Invalid JSON provided');
58		}
59
60	1	$responseObject = new self();
61
62	1	foreach($responseObject as $key => $value){
		0 ignored issues – show Bug introduced 2017-11-13 15:52 UTC by Report Bug Copy Issue Report The expression `$responseObject` of type `object<Azine\MailgunWebh...ixtoolsServiceResponse>` is not traversable. Loading history...
63
64	1	if(isset($response[$key])){
65
66	1	$responseObject->$key = $response[$key];
67	1	}
68	1	}
69
70	1	return $responseObject;
71		}
72		}

azine / AzineMailgunWebhooksBundle

Pull Request — master (#30)

HetrixtoolsServiceResponse::fromJson() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like