AzineMailgunCockpitService::getLastKnownSenderIp() - Code Metrics - Inspection of "Implemented Mailgun-Cockpit with a set of useful l..." - azine/AzineMailgunWebhooksBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

unknown

created 2017-07-25 13:34 UTC

AzineMailgunCockpitService::getLastKnownSenderIp() A

↳ Parent: AzineMailgunCockpitService

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	2
eloc	7
nc	2
nop	0

<?php


namespace Azine\MailgunWebhooksBundle\Services;

use Azine\MailgunWebhooksBundle\Entity\Repositories\MailgunEventRepository;

class AzineMailgunCockpitService
{
    private $emailDomain;
    private $eventRepository;
    private $twig;
    
    private $cachedLastKnownIp;
    
    public function __construct(MailgunEventRepository $eventRepository, \Twig_Environment $twig, $emailDomain)
    {
        $this->emailDomain = $emailDomain;
        $this->eventRepository = $eventRepository;
        $this->twig = $twig;
    }

    public function getLastKnownSenderIp()
    {
        if (is_null($this->cachedLastKnownIp)) {                    
            $lastKnownIp = $this->eventRepository->getLastKnownSenderIp();
            $this->cachedLastKnownIp = $lastKnownIp;
        } else {
            $lastKnownIp = $this->cachedLastKnownIp;
        }
        return $this->getValueOrEmptyString($lastKnownIp);
    }

    public function getEmailDomain()
    {
        return $this->getValueOrEmptyString($this->emailDomain);
    }

    public function getCockpitDataAsArray()
    {
        return array(
            'lastKnownIp' => $this->getLastKnownSenderIp(),
            'emailDomain' => $this->getEmailDomain()
        );
    }

    private function getValueOrEmptyString($value)
    {
        return is_null($value) ? '' : $value;
    }
}

1			<?php
2
3
4			namespace Azine\MailgunWebhooksBundle\Services;
5
6			use Azine\MailgunWebhooksBundle\Entity\Repositories\MailgunEventRepository;
7
8			class AzineMailgunCockpitService
9			{
10			private $emailDomain;
11			private $eventRepository;
12			private $twig;
13
14			private $cachedLastKnownIp;
15
16			public function __construct(MailgunEventRepository $eventRepository, \Twig_Environment $twig, $emailDomain)
17			{
18			$this->emailDomain = $emailDomain;
19			$this->eventRepository = $eventRepository;
20			$this->twig = $twig;
21			}
22
23			public function getLastKnownSenderIp()
24			{
25			if (is_null($this->cachedLastKnownIp)) {
26			$lastKnownIp = $this->eventRepository->getLastKnownSenderIp();
27			$this->cachedLastKnownIp = $lastKnownIp;
28			} else {
29			$lastKnownIp = $this->cachedLastKnownIp;
30			}
31			return $this->getValueOrEmptyString($lastKnownIp);
32			}
33
34			public function getEmailDomain()
35			{
36			return $this->getValueOrEmptyString($this->emailDomain);
37			}
38
39			public function getCockpitDataAsArray()
40			{
41			return array(
42			'lastKnownIp' => $this->getLastKnownSenderIp(),
43			'emailDomain' => $this->getEmailDomain()
44			);
45			}
46
47			private function getValueOrEmptyString($value)
48			{
49			return is_null($value) ? '' : $value;
50			}
51			}

azine / AzineMailgunWebhooksBundle

Pull Request — master (#6)

AzineMailgunCockpitService::getLastKnownSenderIp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like