AzineMailgunCockpitService::getLastKnownSenderIp() - Code Metrics - azine/AzineMailgunWebhooksBundle - Measure and Improve Code Quality continuously with Scrutinizer

AzineMailgunCockpitService::getLastKnownSenderIp() A
last analyzed 2021-01-11 10:47 UTC

↳ Parent: AzineMailgunCockpitService

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	3
Bugs	2	Features	1

Metric	Value
cc	3
eloc	10
c	3
b	2
f	1
nc	3
nop	0
dl	0
loc	18
ccs	0
cts	10
cp	0
crap	12
rs	9.9332

<?php

namespace Azine\MailgunWebhooksBundle\Services;

use Azine\MailgunWebhooksBundle\Entity\MailgunEvent;
use Azine\MailgunWebhooksBundle\Entity\Repositories\MailgunEventRepository;
use Symfony\Bridge\Doctrine\ManagerRegistry;
filter:
    dependency_paths: ["lib/*"]

class AzineMailgunCockpitService
{
    private $emailDomain;
    /** @var ManagerRegistry */
    private $managerRegistry;
    /** @var \Twig_Environment */
    private $twig;

    private $cachedLastKnownIp;

    public function __construct(ManagerRegistry $managerRegistry, \Twig_Environment $twig, $emailDomain)
    {
        $this->emailDomain = $emailDomain;
        $this->managerRegistry = $managerRegistry;
        $this->twig = $twig;
    }

    public function getLastKnownSenderIp()
    {
        if (is_null($this->cachedLastKnownIp)) {
            /** @var MailgunEventRepository $eventRepository */
            $eventRepository = $this->managerRegistry->getRepository(MailgunEvent::class);
            $lastKnownIp = null;
            $ipAddressData = $eventRepository->getLastKnownSenderIpData();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

            if (isset($ipAddressData['id'])) {
                $lastKnownIp = $ipAddressData['id'];
            }

            $this->cachedLastKnownIp = $lastKnownIp;
        } else {
            $lastKnownIp = $this->cachedLastKnownIp;
        }

        return $this->getValueOrEmptyString($lastKnownIp);
    }

    public function getEmailDomain()
    {
        return $this->getValueOrEmptyString($this->emailDomain);
    }

    public function getCockpitDataAsArray()
    {
        return array(
            'lastKnownIp' => $this->getLastKnownSenderIp(),
            'emailDomain' => $this->getEmailDomain(),
        );
    }

    private function getValueOrEmptyString($value)
    {
        return is_null($value) ? '' : $value;
    }
}


1			<?php
2
3			namespace Azine\MailgunWebhooksBundle\Services;
4
5			use Azine\MailgunWebhooksBundle\Entity\MailgunEvent;
6			use Azine\MailgunWebhooksBundle\Entity\Repositories\MailgunEventRepository;
7			use Symfony\Bridge\Doctrine\ManagerRegistry;
			0 ignored issues – show Bug introduced 2021-01-01 17:16 UTC by Report Bug Copy Issue Report The type `Symfony\Bridge\Doctrine\ManagerRegistry` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8
9			class AzineMailgunCockpitService
10			{
11			private $emailDomain;
12			/** @var ManagerRegistry */
13			private $managerRegistry;
14			/** @var \Twig_Environment */
15			private $twig;
16
17			private $cachedLastKnownIp;
18
19			public function __construct(ManagerRegistry $managerRegistry, \Twig_Environment $twig, $emailDomain)
20			{
21			$this->emailDomain = $emailDomain;
22			$this->managerRegistry = $managerRegistry;
23			$this->twig = $twig;
24			}
25
26			public function getLastKnownSenderIp()
27			{
28			if (is_null($this->cachedLastKnownIp)) {
29			/** @var MailgunEventRepository $eventRepository */
30			$eventRepository = $this->managerRegistry->getRepository(MailgunEvent::class);
31			$lastKnownIp = null;
32			$ipAddressData = $eventRepository->getLastKnownSenderIpData();
			0 ignored issues – show Bug introduced 2019-07-17 15:48 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$ipAddressData` is correct as `$eventRepository->getLastKnownSenderIpData()` targeting `Azine\MailgunWebhooksBun...LastKnownSenderIpData()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
33
34			if (isset($ipAddressData['id'])) {
35			$lastKnownIp = $ipAddressData['id'];
36			}
37
38			$this->cachedLastKnownIp = $lastKnownIp;
39			} else {
40			$lastKnownIp = $this->cachedLastKnownIp;
41			}
42
43			return $this->getValueOrEmptyString($lastKnownIp);
44			}
45
46			public function getEmailDomain()
47			{
48			return $this->getValueOrEmptyString($this->emailDomain);
49			}
50
51			public function getCockpitDataAsArray()
52			{
53			return array(
54			'lastKnownIp' => $this->getLastKnownSenderIp(),
55			'emailDomain' => $this->getEmailDomain(),
56			);
57			}
58
59			private function getValueOrEmptyString($value)
60			{
61			return is_null($value) ? '' : $value;
62			}
63			}
64

azine / AzineMailgunWebhooksBundle

AzineMailgunCockpitService::getLastKnownSenderIp() A last analyzed 2021-01-11 10:47 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AzineMailgunCockpitService::getLastKnownSenderIp() A
last analyzed 2021-01-11 10:47 UTC