azine / AzineHybridAuthBundle

Controller/AzineHybridAuthJsonController.php

<?php

namespace Azine\HybridAuthBundle\Controller;

use Azine\HybridAuthBundle\Services\AzineGenderGuesser;
use Azine\HybridAuthBundle\Services\AzineHybridAuth;
use Azine\HybridAuthBundle\Services\AzineMergedBusinessNetworksProvider;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;

class AzineHybridAuthJsonController extends Controller

The class Symfony\Bundle\FrameworkBundle\Controller\Controller has been deprecated: since Symfony 4.2, use "Symfony\Bundle\FrameworkBundle\Controller\AbstractController" instead.

{
    /**
     * Check if the user is connected to the requested provider.
     *
     * @param Request $request
     * @param string  $provider
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function isConnectedAction(Request $request, $provider)
    {
        try {
            $connected = $this->getAzineHybridAuthService()->isConnected($request, $provider);

            return new JsonResponse(array('connected' => $connected));
        } catch (\Exception $e) {
            return new JsonResponse(array('connected' => false, 'message' => $e->getMessage()."\n\n\n".$e->getTraceAsString()));
        }
    }

    /**
     * Try to connect to the provider.
     *
     * @param Request $request
     * @param string  $provider
     * @param null    $callbackRoute

Are you sure the doc-type for parameter $callbackRoute is correct as it would always require null to be passed?

     *
     * @return RedirectResponse
     *
     * @throws \Exception e.g. if the api-connection is invalid
     */
    public function connectUserAction(Request $request, $provider, $callbackRoute = null)
    {
        $params = $request->query->all();
        $callbackUrl = $this->generateUrl($callbackRoute, $params);

$callbackRoute of type null is incompatible with the type string expected by parameter $route of Symfony\Bundle\FrameworkBundle\Controller\Controller::generateUrl().

        $deleteSessionData = $request->query->get('force', false);
        $cookieName = $this->getAzineHybridAuthService()->getCookieName($provider);
        if ($deleteSessionData) {
            $this->getAzineHybridAuthService()->deleteSession($provider);
        }
        try {
            $adapter = $this->getAzineHybridAuthService()->getInstance($request->cookies->get($cookieName), $provider);
            $adapter->getStorage()->set("hauth_session.$provider.hauth_return_to", $callbackUrl);
            $connected = $adapter->isConnected();
        } catch (\Exception $e) {
            $response = new RedirectResponse($callbackUrl);
            if ($deleteSessionData) {
                $response->headers->clearCookie($cookieName, '/', $request->getHost(), $request->isSecure(), true);
            }

            return $response;
        }

        if (!$connected || $deleteSessionData) {
            try {
                setcookie($cookieName, null, -1, '/', $request->getHost(), $request->isSecure(), true);
                $adapter->authenticate();
            } catch (\Exception $e) {
                throw new \Exception("Unable to create adapter for provider '$provider'. Is it configured properly?", $e->getCode(), $e);
            }
        }

        if (!$callbackUrl) {
            throw new \Exception('Callback route not defined');
        }
        $response = new RedirectResponse($callbackUrl);
        if ($deleteSessionData) {
            $response->headers->clearCookie($cookieName, '/', $request->getHost(), $request->isSecure(), true);
        }

        return $response;
    }

    /**
     * Get the users Profile for the requested provider.
     *
     * @param Request $request
     * @param string  $provider
     * @param string  $userId
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     *
     * @throws \Exception e.g. if the api-connection is invalid
     */
    public function profileAction(Request $request, $provider, $userId = null)
    {
        if (null == $userId) {

It seems like you are loosely comparing $userId of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $cookieName = $this->getAzineHybridAuthService()->getCookieName($provider);
            $providerAdapter = $this->getAzineHybridAuthService()->getProvider($request->cookies->get($cookieName), $provider);
            $profile = $providerAdapter->getUserProfile();
            if (!$profile->gender) {
                /* @var $genderGuesser AzineGenderGuesser */
                $genderGuesser = $this->get('azine_hybrid_auth_gender_guesser');
                $gender = $genderGuesser->guess($profile->firstName);
                $profile->gender = is_array($gender) ? $gender['gender'] : null;
            }
            if (!$profile->profileURL) {
                $profile->profileURL = "LinkedIn doesn't allow to access this. :-/";
            }
        } else {
            $profile = $this->getBusinessNetworkProviderService()->getUserContactBasicProfile($provider, $userId);
        }

        return new JsonResponse(array('profile' => $profile));
    }

    /**
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     *
     * @throws \Exception e.g. if the api-connection is invalid
     */
    public function profileByUrlAction(Request $request)
    {
        $profileUrl = $request->get('searchByUrl');
        $profile = $this->getBusinessNetworkProviderService()->getUserProfileByUrl($profileUrl);

        return new JsonResponse(array('profile' => $profile));
    }

    /**
     * Get all users contacts for the requested provider.
     *
     * @param Request $request
     * @param string  $provider
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     *
     * @throws \Exception e.g. if the api-connection is invalid
     */
    public function contactsAction(Request $request, $provider)
    {
        $cookieName = $this->getAzineHybridAuthService()->getCookieName($provider);
        $contacts = $this->getAzineHybridAuthService()->getProvider($request->cookies->get($cookieName), $provider)->getUserContacts();

        return new JsonResponse(array('contacts' => $contacts));
    }

    /**
     * Get all contacts from Xing and LinkedIn.
     *
     * @param Request $request
     * @param int     $pageSize
     * @param int     $offset
     *
     * @return JsonResponse
     *
     * @throws \Exception e.g. if the api-connection is invalid
     */
    public function mergedContactsAction(Request $request, $pageSize, $offset)
    {
        $filterParams = $request->query->all();
        $contacts = $this->getBusinessNetworkProviderService()->getContactProfiles($pageSize, $offset, $filterParams);

        return new JsonResponse(array('contacts' => $contacts));
    }

    /**
     * @return AzineMergedBusinessNetworksProvider
     */
    private function getBusinessNetworkProviderService()
    {
        return $this->get('azine_business_networks_provider_service');
    }

    /**
     * @return AzineHybridAuth
     */
    private function getAzineHybridAuthService()
    {
        return $this->get('azine_hybrid_auth_service');
    }
}