ConsoleForm

Complexity

Total Complexity

10

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	submitForm()	0	6	1
A	getCustomFields()	0	8	1
A	getCustomActions()	0	8	1
A	getCustomValidator()	0	8	1
B	setRequiredFieldsLabels()	0	13	5

<?php

/**
 * Class ConsoleForm
 */
class ConsoleForm extends Form

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var ContentController
     */
    protected $controller;

    /**
     * @param Controller $controller
     * @param string $name
     */
    public function __construct(Controller $controller, $name)
    {
        $this->controller = $controller;

$controller is of type object<Controller>, but the property $controller was declared to be of type object<ContentController>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $fields    = $this->getCustomFields();
        $actions   = $this->getCustomActions();
        $validator = $this->getCustomValidator($fields);

        parent::__construct($controller, $name, $fields, $actions, $validator);

        $this->setFormAction('/console/'.$name);
    }

    /**
     * @param array $data
     * @param ConsoleForm $form
     * @param SS_HTTPRequest $request
     */
    public function submitForm($data, ConsoleForm $form, SS_HTTPRequest $request)

The parameter $form is not used and could be removed.

The parameter $request is not used and could be removed.

    {
        //TODO : do something with data or form

        return $this->controller->redirect('/console/index/'.$data['Name']);
    }

    /**
     * @return FieldList
     */
    public function getCustomFields()
    {
        $fields = new FieldList(
            new TextField('Name', 'Name')
        );

        return $fields;
    }

    /**
     * @return FieldList
     */
    public function getCustomActions()
    {
        $fields = new FieldList(
            new FormAction('submitForm', _t('Site.Submit', 'Submit'))
        );

        return $fields;
    }

    public function getCustomValidator(FieldList $fields)
    {
        $required = [];

        $this->setRequiredFieldsLabels($required, $fields);

        return RequiredFields::create($required);
    }

    /**
     * Add required stars to field labels
     *
     * @param array $required
     * @param FieldList $fields
     */
    protected function setRequiredFieldsLabels($required, FieldList $fields)
    {
        foreach ((array)$required as $req) {
            $field = $fields->dataFieldByName($req);
            if ($field && $title = trim($field->Title())) {
                if (!$field->getCustomValidationMessage()) {
                    $message = strip_tags($title) . ' ' . _t('Site.IsRequired', ' is required');
                    $field->setCustomValidationMessage($message);
                }
                $field->setTitle($title . ' *');
            }
        }
    }

}