Application

Complexity

Total Complexity

12

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	call()	0	14	1
A	output()	0	4	2
A	addToParent()	0	4	1
A	getDefaultInputDefinition()	0	8	1
A	getEnvironmentOption()	0	6	1
A	loadCommands()	0	18	4

<?php

use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\Console\Application as SymfonyApplication;
use Symfony\Component\Console\Command\Command as SymfonyCommand;

/**
 * Class Application
 *
 * Shameless copy/paste from Taylor Otwell's Laravel
 */
class Application extends SymfonyApplication

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * The output from the previous command.
     *
     * @var \Symfony\Component\Console\Output\BufferedOutput
     */
    protected $lastOutput;

    public function __construct()
    {
        parent::__construct();

        $this->loadCommands();

        $this->setAutoExit(false);
        $this->setCatchExceptions(false);
    }

    /**
     * Run an Artisan console command by name.
     *
     * @param  string  $command
     * @param  array  $parameters
     * @return int

Should the return type not be null|integer?

     */
    public function call($command, array $parameters = [])
    {
        $parameters = array_merge((array)$command, $parameters);

        $this->lastOutput = new BufferedOutput;

        $this->setCatchExceptions(false);

        $result = $this->run(new ArrayInput($parameters), $this->lastOutput);

        $this->setCatchExceptions(true);

        return $result;
    }

    /**
     * Get the output for the last run command.
     *
     * @return string
     */
    public function output()
    {
        return $this->lastOutput ? $this->lastOutput->fetch() : '';
    }

    /**
     * Add a command to the console.
     *
     * @param  \Symfony\Component\Console\Command\Command  $command
     * @return \Symfony\Component\Console\Command\Command

Should the return type not be SymfonyCommand|null?

     */
    public function add(SymfonyCommand $command)
    {
        return $this->addToParent($command);
    }

    /**
     * Add the command to the parent instance.
     *
     * @param  \Symfony\Component\Console\Command\Command  $command
     * @return \Symfony\Component\Console\Command\Command

Should the return type not be SymfonyCommand|null?

     */
    protected function addToParent(SymfonyCommand $command)
    {
        return parent::add($command);

It seems like you call parent on a different method (add() instead of addToParent()). Are you sure this is correct? If so, you might want to change this to $this->add().

    }

    /**
     * Get the default input definitions for the applications.
     *
     * This is used to add the --env option to every available command.
     *
     * @return \Symfony\Component\Console\Input\InputDefinition
     */
    protected function getDefaultInputDefinition()
    {
        $definition = parent::getDefaultInputDefinition();

        $definition->addOption($this->getEnvironmentOption());

        return $definition;
    }

    /**
     * Get the global environment option for the definition.
     *
     * @return \Symfony\Component\Console\Input\InputOption
     */
    protected function getEnvironmentOption()
    {
        $message = 'The environment the command should run under.';

        return new InputOption('--env', null, InputOption::VALUE_OPTIONAL, $message);
    }

    /**
     * Load all available commands into the console application
     */
    protected function loadCommands()
    {
        /**
         * Why does this not work
         */
        $commands = ClassInfo::subclassesFor('SilverstripeCommand'); //var_dump($commands);exit();

$commands is not used, you could remove the assignment.

89% of this comment could be valid code. Did you maybe forget this after debugging?

        // This works, but does not load custom Commands
        $commands = ClassInfo::classes_for_folder(BASE_PATH . '/console/code/');

        /** @var SilverstripeCommand $command */
        foreach ($commands as $command) {
            $reflection = new ReflectionClass($command);
            if (!$reflection->isAbstract() && $reflection->isSubclassOf('SilverstripeCommand')) {
                $this->add(new $command());
            }
        }
    }

}