BackupCommand::getOptions() - Code Metrics - Inspection of "$ sake console clear:tmpdbs" - axyr/silverstripe-console - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 69c507...0da94d )

by Martijn van

created 2016-04-19 17:24 UTC

BackupCommand::getOptions() A

↳ Parent: BackupCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php


use Symfony\Component\Console\Input\InputOption;

class BackupCommand extends SilverstripeCommand
namespace YourVendor;

class YourClass { }
{
    protected $name = 'task:backup';

    public function fire()
    {
        $this->error('Not implemented yet');

        if($this->option('assets')) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //$this->backupAssets();

        }

        if($this->option('database')) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //$this->backupDatabase();

        }
    }

    protected function backupAssets()
    {
        $this->info('Assets backupped in file :');
    }

    protected function backupDatabase()
    {
        $this->info('Database backupped in file :');
    }

    /**
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['assets', 'a', InputOption::VALUE_OPTIONAL, 'Backup assets'],
            ['database', 'd', InputOption::VALUE_OPTIONAL, 'Backup database'],
        ];
    }
}


1			<?php
2
3
4			use Symfony\Component\Console\Input\InputOption;
5
6			class BackupCommand extends SilverstripeCommand
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-19 16:01 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			protected $name = 'task:backup';
9
10			public function fire()
11			{
12			$this->error('Not implemented yet');
13
14			if($this->option('assets')) {
			0 ignored issues – show Unused Code introduced 2016-04-19 17:27 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
15			//$this->backupAssets();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-19 17:27 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16			}
17
18			if($this->option('database')) {
			0 ignored issues – show Unused Code introduced 2016-04-19 17:27 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
19			//$this->backupDatabase();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-19 17:27 UTC by Report Bug Copy Issue Report `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20			}
21			}
22
23			protected function backupAssets()
24			{
25			$this->info('Assets backupped in file :');
26			}
27
28			protected function backupDatabase()
29			{
30			$this->info('Database backupped in file :');
31			}
32
33			/**
34			* @return array
35			*/
36			protected function getOptions()
37			{
38			return [
39			['assets', 'a', InputOption::VALUE_OPTIONAL, 'Backup assets'],
40			['database', 'd', InputOption::VALUE_OPTIONAL, 'Backup database'],
41			];
42			}
43			}
44

axyr / silverstripe-console

Push — master ( 69c507...0da94d )

BackupCommand::getOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like