SilverstripeApplication

Complexity

Total Complexity

16

Size/Duplication

Total Lines	150
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	8

Importance

Changes	4
Bugs	1	Features	1

10 Methods

Rating	Name	Duplication	Size	Complexity
A	output()	0	4	2
A	__construct()	0	12	1
A	run()	0	4	1
A	call()	0	14	1
A	add()	0	4	1
A	addToParent()	0	4	1
A	getDefaultInputDefinition()	0	8	1
A	getEnvironmentOption()	0	6	1
A	loadCommands()	0	14	2
B	addCommandOrSilentlyFail()	0	9	5

<?php

use Symfony\Component\Console\Application as SymfonyApplication;
use Symfony\Component\Console\Command\Command as SymfonyCommand;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Application.
 *
 * Shameless copy/paste from Taylor Otwell's Laravel
 */
class SilverstripeApplication extends SymfonyApplication

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * The output from the previous command.
     *
     * @var \Symfony\Component\Console\Output\BufferedOutput
     */
    protected $lastOutput;

    public function __construct()
    {
        parent::__construct();

        $this->loadCommands();

        $this->add($default = new DefaultCommand());
        $this->setDefaultCommand($default->getName());

        $this->setAutoExit(false);
        $this->setCatchExceptions(false);
    }

    public function run(InputInterface $input = null, OutputInterface $output = null)
    {
        return parent::run($input, $output);
    }

    /**
     * Run an Artisan console command by name.
     *
     * @param string $command
     * @param array  $parameters
     *
     * @return int

Should the return type not be null|integer?

     */
    public function call($command, array $parameters = [])
    {
        $parameters = array_merge((array) $command, $parameters);

        $this->lastOutput = new BufferedOutput();

        $this->setCatchExceptions(false);

        $result = $this->run(new ArrayInput($parameters), $this->lastOutput);

        $this->setCatchExceptions(true);

        return $result;
    }

    /**
     * Get the output for the last run command.
     *
     * @return string
     */
    public function output()
    {
        return $this->lastOutput ? $this->lastOutput->fetch() : '';
    }

    /**
     * Add a command to the console.
     *
     * @param \Symfony\Component\Console\Command\Command $command
     *
     * @return \Symfony\Component\Console\Command\Command

Should the return type not be SymfonyCommand|null?

     */
    public function add(SymfonyCommand $command)
    {
        return $this->addToParent($command);
    }

    /**
     * Add the command to the parent instance.
     *
     * @param \Symfony\Component\Console\Command\Command $command
     *
     * @return \Symfony\Component\Console\Command\Command

Should the return type not be SymfonyCommand|null?

     */
    protected function addToParent(SymfonyCommand $command)
    {
        return parent::add($command);

It seems like you call parent on a different method (add() instead of addToParent()). Are you sure this is correct? If so, you might want to change this to $this->add().

    }

    /**
     * Get the default input definitions for the applications.
     *
     * This is used to add the --env option to every available command.
     *
     * @return \Symfony\Component\Console\Input\InputDefinition
     */
    protected function getDefaultInputDefinition()
    {
        $definition = parent::getDefaultInputDefinition();

        $definition->addOption($this->getEnvironmentOption());

        return $definition;
    }

    /**
     * Get the global environment option for the definition.
     *
     * @return \Symfony\Component\Console\Input\InputOption
     */
    protected function getEnvironmentOption()
    {
        $message = 'The environment the command should run under.';

        return new InputOption('--env', null, InputOption::VALUE_OPTIONAL, $message);
    }

    /**
     * Load all available commands into the console application.
     */
    protected function loadCommands()
    {
        /*
         * Why does this not work
         */
        //$commands = ClassInfo::subclassesFor('SilverstripeCommand'); //var_dump($commands);exit();

50% of this comment could be valid code. Did you maybe forget this after debugging?

        $classes = SS_ClassLoader::instance()->getManifest()->getClasses();

        /** @var SilverstripeCommand $command */
        foreach ($classes as $class => $path) {
            $this->addCommandOrSilentlyFail($class, $path);
        }
    }

    /**
     * When developing and renaming or removing a Command, the manifest is not always updated.
     *
     * We don't want file_not_found or class_does_not_exists error for commands,
     * because that prevente running commands like cache:clear etc.
     *
     * @param string $class
     * @param string $path
     */
    protected function addCommandOrSilentlyFail($class, $path)
    {
        if(is_file($path) && class_exists($class)) {
            $reflection = new ReflectionClass($class);
            if (!$reflection->isAbstract() && $reflection->isSubclassOf('SilverstripeCommand')) {
                $this->add(new $class());
            }
        }
    }

}