ConsoleController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	7
Bugs	3	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	6	1
A	index()	0	16	3
A	callFromConsole()	0	7	1
A	callFromBrowser()	0	18	1

<?php

use SensioLabs\AnsiConverter\AnsiToHtmlConverter;
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\Console\Output\ConsoleOutput;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class ConsoleController
 * The Central Command Access Point and Bootstrapper.
 */
class ConsoleController extends Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var array
     */
    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'publish',
    ];

    /**
     * @var SilverstripeApplication
     */
    protected $application;

    public function init()
    {
        parent::init();

        $this->application = new SilverstripeApplication();
    }

    public function index(SS_HTTPRequest $request)
    {
        /**
         * Lets be clear when calling commands
         */
        ini_set('display_errors', 1);

        if(!Director::is_cli()) {
            if(!Permission::check("ADMIN")) {
                return Security::permissionFailure();
            }
            return $this->callFromBrowser($request);
        }

        return $this->callFromConsole();
    }

    protected function callFromConsole()

callFromConsole uses the super-global variable $_SERVER which is generally not recommended.

    {
        // remove the framework/cli-script.php argument
        array_shift($_SERVER['argv']);

        $this->application->run(new ArgvInput($_SERVER['argv']), new ConsoleOutput());
    }

    protected function callFromBrowser(SS_HTTPRequest $request)
    {
        $input = new ArrayInput(array(
            'command' => $request->param('ID')
        ));

        $output = new BufferedOutput(
            OutputInterface::VERBOSITY_NORMAL,
            true // true for decorated
        );
        $this->application->run($input, $output);

        // return the output
        $converter = new AnsiToHtmlConverter();
        $content = $output->fetch();
        
        return ['ConsoleOutput' => $converter->convert($content)];
    }
}